Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Apr 2023 22:47:29 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Enric Balletbo i Serra <eballetbo@redhat.com>,
        Brendan Higgins <brendanhiggins@google.com>,
        linux-kselftest@vger.kernel.org,
        =?iso-8859-1?Q?Ma=EDra?= Canal <mcanal@igalia.com>,
        David Gow <davidgow@google.com>,
        Daniel Latypov <dlatypov@google.com>,
        kunit-dev@googlegroups.com, Maxime Ripard <maxime@cerno.tech>,
        linux-input@vger.kernel.org
Subject: Re: [PATCH v2] Input: Add KUnit tests for some of the input core
 helper functions
Message-ID: <ZCkW8bFjy0GA0C34@google.com>
References: <20230330081831.2291351-1-javierm@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230330081831.2291351-1-javierm@redhat.com>
Precedence: bulk

On Thu, Mar 30, 2023 at 10:18:31AM +0200, Javier Martinez Canillas wrote:
> The input subsystem doesn't currently have any unit tests, let's add a
> CONFIG_INPUT_KUNIT_TEST option that builds a test suite to be executed
> with the KUnit test infrastructure.
> 
> For now, only three tests were added for some of the input core helper
> functions that are trivial to test:
> 
>   * input_test_polling: set/get poll interval and set-up a poll handler.
> 
>   * input_test_timestamp: set/get input event timestamps.
> 
>   * input_test_match_device_id: match a device by bus, vendor, product,
>                                 version and events capable of handling.
> 
> But having the minimal KUnit support allows to add more tests and suites
> as follow-up changes. The tests can be run with the following command:
> 
>   $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/input/tests/
> 
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> Tested-by: Enric Balletbo i Serra <eballetbo@redhat.com>

Applied, thank you.

-- 
Dmitry