Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3183567rwl; Sun, 2 Apr 2023 02:06:38 -0700 (PDT) X-Google-Smtp-Source: AKy350YZ8m9UuwmE/evG2RolsoCNZX3dCOqgkYjf9scMdiEp4k7/pzLTEKz/iyecxgXBRAOlpgVz X-Received: by 2002:a17:906:e99:b0:930:8590:95ef with SMTP id p25-20020a1709060e9900b00930859095efmr14683499ejf.18.1680426398199; Sun, 02 Apr 2023 02:06:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680426398; cv=none; d=google.com; s=arc-20160816; b=f3MGrKMkVV5F1+6NHZ/41ebn9m+hX5JWNk5rKaRkSepNoSiI45sLfGRF92TWi4sOsS l3chlY/SknBgt0YYqS63EIixHsetHd9+CPjRVECQRG/qZT8/lk0WdRR/zgn6RKXGo9Ov ri/nUyaTgqfhbfjLeyEyiYtwnmDj2U2XGJAv+sN1naJCvl5Ta9UmNm52+gXGelcu2Xop cC6PDc2QDObsb/hM04qTj2UPifsR8ZAcpjdLLm88f6bnKUSjS6vr4Xq3ic/2KzNinTS9 S61Jlv4RjEo709iJEM6rAmUCwgwAjd9bKEVTmvpiydx/LFMNc/EBYXtX4NxJRy0SUYgA FbPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UknYS6HloGrubqoqUfND0nBg3T3wkoV9wtjdkEiVsi8=; b=r7UG8KfZ+XFA0X6igccV3dM8bAikN43TDqnn41rxTyRhOYp2RIj3UIWPxZywgnlqQ5 +S3szrP6c99MRjyLcsHEcqNzIdhURa3PMUfIVgv60pMXkS7fPlUeb3Eg/cia16D8HtOz SALB7rz+qKPAMYvaDCq1GC8/147w0mlrOPlhkQrluhS//A+aHMh3neEip5/DB07GQRXQ OZz/r+f6CL/y+AMFn/R7F5UeLTQfPn1Ls7oNjZLmrd64L2EQQ2gsX+glfkg0ZeRxtvhU +cqWmz1RsUWCkZ7A3fes6DInSpOcpxKqQ2NxFv1/8vb/mjweY7q0VwP1sZLiAOwoQ2kU TSLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aRXTcZE3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g4-20020a170906198400b0093e7ed91726si5078218ejd.480.2023.04.02.02.06.12; Sun, 02 Apr 2023 02:06:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aRXTcZE3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230174AbjDBI5o (ORCPT + 99 others); Sun, 2 Apr 2023 04:57:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjDBI5n (ORCPT ); Sun, 2 Apr 2023 04:57:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC9FEAD1B; Sun, 2 Apr 2023 01:57:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 782BC60F7D; Sun, 2 Apr 2023 08:57:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8466FC433D2; Sun, 2 Apr 2023 08:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680425861; bh=2Sp/WGMz3fqu0IaXp63wNcBNSGfhlqXDZ2bdpCKy3QE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aRXTcZE3mYfA7PFSOhgoQRvNu2hl66627nKgFVoEkrtOXff0lKGsaPS2a9VguB77m ZyRjfqO1xodz/u05Do9gX9pyJ/kbag6WxBBe6sUQlDTcjl6qVG3mzPyX8bWDo9DxRm AjNiDSm/ogxaogNW5RevI3uddevvVX3DKBXhie8c= Date: Sun, 2 Apr 2023 10:57:39 +0200 From: Greg Kroah-Hartman To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] pktcdvd: simplify the class_pktcdvd logic Message-ID: <2023040213-plop-krypton-b853@gregkh> References: <20230331164724.319703-1-gregkh@linuxfoundation.org> <87e110f9-a57d-520b-6fae-f75d16a71108@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87e110f9-a57d-520b-6fae-f75d16a71108@kernel.dk> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 01, 2023 at 08:25:10PM -0600, Jens Axboe wrote: > On 3/31/23 10:47 AM, Greg Kroah-Hartman wrote: > > There is no need to dynamically create and destroy the class_pktcdvd > > structure, just make it static and remove the memory allocation logic > > which simplifies and cleans up the logic a lot. > > > > Cc: linux-block@vger.kernel.org > > Cc: Jens Axboe > > Signed-off-by: Greg Kroah-Hartman > > --- > > Note, I would like to take this through my driver-core tree as it is > > needed for other struct class cleanup work I have done and am continuing > > to do there. > > I'm going to defer to you on this kind of stuff, so if you think it's > fine, then go for it. Thanks! And sorry for sending this twice, I forgot I had previously sent this a few days prior. Too many patches to juggle over here... greg k-h