Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 2 Apr 2023 10:51:19 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] iio: addac: stx104: Migrate to the regmap API
Message-ID: <ZCmWZyEOnfknvSLg@fedora>
References: <cover.1679867815.git.william.gray@linaro.org>
 <4ebc1b6b609a086846420954b893e914fd395384.1679867815.git.william.gray@linaro.org>
 <ZCGBIAvr7OQLwNXv@smile.fi.intel.com>
 <ZCg6bhkxGKmkMloM@fedora>
 <20230402174657.55159879@jic23-huawei>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yEXAaY2iei/+iClt"
Content-Disposition: inline
In-Reply-To: <20230402174657.55159879@jic23-huawei>
Precedence: bulk


--yEXAaY2iei/+iClt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 02, 2023 at 05:46:57PM +0100, Jonathan Cameron wrote:
>=20
> > > > +	.wr_table =3D &aio_ctl_wr_table,
> > > > +	.rd_table =3D &aio_ctl_rd_table,
> > > > +	.volatile_table =3D &aio_ctl_volatile_table,
> > > > +	.cache_type =3D REGCACHE_FLAT,
> > > > +}; =20
> > >=20
> > > Do we need regmap lock? =20
> >=20
> > I think the regmap lock is opt-out, so I don't think we need to set an
> > custom lock callback for the regmaps in this driver.
> >=20
> > Jonathan, do read_raw() and write_raw() require explicit locking?
>=20
> The don't provide their own locking.  Depending on the access pattern the
> underlying bus locking may be sufficient.  If you have read modify write
> cycles though you'll want locking at the appropriate level for that
> which might well be at the level of regmap.
>=20
> Jonathan

If read_raw() can be called concurrently multiple times then we risk
changing the ADC channel while the analog-to-digital conversion is in
progress, thus resulting in an incorrect reported value. Looks like
we'll need an explicit lock for this after all, so I'll create a
precursor patch addressing that.

William Breathitt Gray

--yEXAaY2iei/+iClt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZCmWZwAKCRC1SFbKvhIj
KwOXAQCxIk2C5V1TsQ/IO+hSQKNUJQofrl9yPD5Cj7Hqhm8krAD+LwqxOaNPKZ86
T4S/v73bD/2MaFkSBaC1sEQcyfSBqA4=
=jsa1
-----END PGP SIGNATURE-----

--yEXAaY2iei/+iClt--