Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3636984rwl; Sun, 2 Apr 2023 11:46:15 -0700 (PDT) X-Google-Smtp-Source: AKy350ZQ5+H1xyERIWUyZW9xD+Yt8435Yoc7GyFFU1j7s+QmH6khAIABS1vUwLeBTsgyvRvdeio6 X-Received: by 2002:a17:902:fb86:b0:1a2:17b1:70d with SMTP id lg6-20020a170902fb8600b001a217b1070dmr29253285plb.42.1680461175678; Sun, 02 Apr 2023 11:46:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680461175; cv=none; d=google.com; s=arc-20160816; b=A01RbHcfvKXWJ/v7AUIfHgJCkk33+SrqBJbtWNJqYqVL+RHEQH97CU07j7eyuXlmeH F5ZdzObXa+VLpb/qM415JC+Lq6EHv/VSs5uSp3WA2ws4/JiaoMi7Q7hcm0n783BGFESd REAcu9V0cHDkottbS3+oMgIP1Ka44ZNC8oIrAscCGMip4z8I6Ar70gHc1srazGAfoB8l mP6G25BVm8MW8MfAx3AMXUONigl3k+jBAd8eTnoTAN+/ZnUWKkGVq9L8022UmqW44Z8Z slUDDRsLslWWz2oZPSS50epkQO5SvxoldAMC+iVZGhL+rGh+GbVKWCqIR9eqD0GWxHEr LSFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=vOAe02m0v3qDETcBzJiDSGNWOB01qggz4Kl6zoi37XU=; b=VI72UEC8eVO378EMeCaF32E8gb5a8pZe/Gfkzb72uLdbvvboA9+sq0Xwf8GC5kTIgt ZugXA660/w6DXbWko/DpB5zZcDLsST9B1oZsfLD7cCDWqIxUL/vWJp6bBwpMG08oxB0Z n9c7tVDpUMkInndBcEH6vErY2675vkdPJhrJ1aQisJG12JqZL8Wl0iwwblizAk0oOeDR nj6L7DS3yE4MeNF/QH08GnqDctrQlrpafUgnkUbM5akavMwm6fAIV5dvnHE7xuQAhEee 8qNoGWrkx+TLyb6/Bdfm/mqmfl/sqPmYk9HbxImL6pc5iFAug6oPm0MzcHklY2GAB+Xr Ge6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=wyGqL9lM; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=XlX+XaVh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 9-20020a630709000000b0050fae5d3584si7188543pgh.570.2023.04.02.11.46.02; Sun, 02 Apr 2023 11:46:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=wyGqL9lM; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=XlX+XaVh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230433AbjDBSlQ (ORCPT + 99 others); Sun, 2 Apr 2023 14:41:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjDBSlP (ORCPT ); Sun, 2 Apr 2023 14:41:15 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73CFE1BDA for ; Sun, 2 Apr 2023 11:41:14 -0700 (PDT) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1680460872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vOAe02m0v3qDETcBzJiDSGNWOB01qggz4Kl6zoi37XU=; b=wyGqL9lMerN9OZdPk08ub4F9a1DhP3JEe6JuaNIDjK2ZLolaYKrfASJZfSNMB8tbIKsFzU SPp/rMxWHP8JCucf7dXS5m4hMV4z99Y6ol1cJuzhCRY3ziKM9Ra/hW7Etam+4/C7dhqC9M RboNXVvG8DegcjDfVlY6MV3qemTYKimVwrUZ59zJBlPQs2YRiyy9prcFKLGGEIyXzRhFk2 FhB2h0kOOB+VNW6NxrRoIFwT/H17FhMDt+xXixaajzquMepepMJoAYGTYSIrbJU4ufULRR /Uh+8FCs2MDGH/Hh+kSPmGfmgY2FG+KN+I9mbzcdVKdVA6u8LPDDtLImlMaBJw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1680460872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vOAe02m0v3qDETcBzJiDSGNWOB01qggz4Kl6zoi37XU=; b=XlX+XaVh1vMbwHKbwGiJaohCm3pWyGmwsYWu0Oq49Nkaybn5/9zR29tq2eI2KQQC0x22CT smAwAbGQYlLfASAw== To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: simplify: was: Re: [PATCH printk v1 06/18] printk: nobkl: Add acquire/release logic In-Reply-To: References: <20230302195618.156940-1-john.ogness@linutronix.de> <20230302195618.156940-7-john.ogness@linutronix.de> Date: Sun, 02 Apr 2023 20:45:27 +0206 Message-ID: <87h6ty9li8.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,INVALID_DATE_TZ_ABSURD,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-03-21, Petr Mladek wrote: > I would prefer to do the logic change. It might help with review > and also with the long term maintenance. As a test I have implemented many of your suggestions. Following your ideas of simplification, I have also found other areas where things can be simplified without sacrificing functionality. Thanks for taking the time to propose an alternate simplified implementation. John