Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-238-g746678b8b6-fm-20230329.001-g746678b8
Mime-Version: 1.0
Message-Id: <dfd65bd6-26d8-4ef4-8eaa-3cc412f381ec@app.fastmail.com>
In-Reply-To: <f2bbd848-2079-d5cb-6a59-9040708dc429@amd.com>
References: <mpearson-lenovo@squebb.ca>
 <20230401184345.208960-1-mpearson-lenovo@squebb.ca>
 <f2bbd848-2079-d5cb-6a59-9040708dc429@amd.com>
Date:   Sun, 02 Apr 2023 15:23:31 -0400
From:   "Mark Pearson" <mpearson-lenovo@squebb.ca>
To:     "Limonciello, Mario" <mario.limonciello@amd.com>
Cc:     "Hans de Goede" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "Armin Wolf" <W_Armin@gmx.de>,
        "Mirsad Goran Todorovac" <mirsad.todorovac@alu.unizg.hr>,
        =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: think-lmi: Fix memory leaks when parsing
 ThinkStation WMI strings
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Mario

On Sun, Apr 2, 2023, at 10:04 AM, Mario Limonciello wrote:
> On 4/1/23 13:43, Mark Pearson wrote:
>
>> My previous commit introduced a memory leak where the item allocated
>> from tlmi_setting was not freed.
>> This commit also renames it to avoid confusion with the similarly name
>> variable in the same function.
>>
>> Fixes: 8a02d70679fc ("platform/x86: think-lmi: Add possible_values fo=
r ThinkStation")
>> Reported-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
>> Link: https://lore.kernel.org/lkml/df26ff45-8933-f2b3-25f4-6ee51ccda7=
d8@gmx.de/T/
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> ---
>> This patch series builds on top of the proposed patch from Armin Wolf
>> "platform/x86: think-lmi: Fix memory leak when showing current settin=
gs"
>
> Which version of the patch did you do it from?=C2=A0 I tried to apply =
v3 of=20
> Armin's patch
> to Linus' tree and then apply these two.
>
> The first applied, but the second had conflicts.=C2=A0 Here was my bas=
e (with=20
> patch 1 in
> this series applied).

I was using v2 - but there shouldn't be any code changes between v3 and =
v2....so I hadn't re-based.

I'm working in the fixes branch from pdx86.git (with the aim of making i=
t easier for Hans to pull in the patches). It's possible I've goofed som=
ehow...though not sure how :(

I'll go double check - but likely won't be until tomorrow I'm afraid. I =
should probably just wait for the patch to be accepted and then work fro=
m there....

Mark