Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 2 Apr 2023 14:24:04 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Willy Tarreau <w@1wt.eu>
Cc:     linux@weissschuh.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] tools/nolibc: add testcases for vfprintf
Message-ID: <530708ce-92af-41ad-84da-a691a518852b@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <20230402184806.12440-1-w@1wt.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230402184806.12440-1-w@1wt.eu>
Precedence: bulk

On Sun, Apr 02, 2023 at 08:48:02PM +0200, Willy Tarreau wrote:
> Hello Paul,
> 
> Thomas added new tests for vfprintf(), which is a good idea because it
> was a new implementation, we use it a lot in the tests so we'd rather
> make sure it works! This required to implement support for memfd_create()
> that is used to collect the output into a buffer, as well as to complete
> a little bit the minimalistic FILE emulation with fileno(), fdopen(),
> fflush() and fclose(). The result is neat and works equally on glibc and
> nolibc. We just had to cheat on the pointer test because for NULL nolibc
> prints "0x0" while glibc prints "(nil)" so we check 0x1 instead to avoid
> this special case.
> 
> Finally Thomas added a new target to the makefile to ease building the
> test against the default libc. This should help detect incompatibilities
> when new features are added.
> 
> I've tested it locally with my libc and against all supported architectures
> (userland tests only), and all tests passed.
> 
> This can be added to your dev tree for 6.5 on top of the previous series.

Looks like some useful code to make testing more comprehensive, thank
you both!  Queued and pushed.

							Thanx, Paul

> Thanks!
> Willy
> 
> Thomas Wei?schuh (4):
>   tools/nolibc: add libc-test binary
>   tools/nolibc: add wrapper for memfd_create
>   tools/nolibc: implement fd-based FILE streams
>   tools/nolibc: add testcases for vfprintf
> 
>  tools/include/nolibc/stdio.h                 | 95 ++++++++++++++------
>  tools/include/nolibc/sys.h                   | 23 +++++
>  tools/testing/selftests/nolibc/.gitignore    |  1 +
>  tools/testing/selftests/nolibc/Makefile      |  6 ++
>  tools/testing/selftests/nolibc/nolibc-test.c | 86 ++++++++++++++++++
>  5 files changed, 184 insertions(+), 27 deletions(-)
> 
> -- 
> 2.17.5
>