Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754991AbXIVW6a (ORCPT ); Sat, 22 Sep 2007 18:58:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753078AbXIVW6W (ORCPT ); Sat, 22 Sep 2007 18:58:22 -0400 Received: from barikada.upol.cz ([158.194.242.200]:39485 "EHLO barikada.upol.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752897AbXIVW6V (ORCPT ); Sat, 22 Sep 2007 18:58:21 -0400 To: Bernhard Walle Cc: kexec@lists.infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [patch 1/7] Extended crashkernel command line In-Reply-To: <20070920171846.062209000@stravinsky.suse.de> References: <20070920171845.774383000@stravinsky.suse.de> <20070920171846.062209000@stravinsky.suse.de> User-Agent: slrn + jed (x86_64-pc-linux-glibc-debian) Date: Sun, 23 Sep 2007 01:14:00 +0200 Message-Id: From: Oleg Verych Organization: Palacky University in Olomouc, experimental physics department X-OS: x86_64-pc-linux-glibc-debian Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 36 * Thu, 20 Sep 2007 19:18:46 +0200 [] > extern u32 vmcoreinfo_note[VMCOREINFO_NOTE_SIZE/4]; > extern unsigned int vmcoreinfo_size; > extern unsigned int vmcoreinfo_max_size; > +int __init parse_crashkernel(char *cmdline, unsigned long long system_ram, > + unsigned long long *crash_size, unsigned long long *crash_base); (BTW, why `system_ram' is `unsigned long' in parse_crashkernel_mem() but `unsigned long long' in parse_crashkernel()?) > +static int __init parse_crashkernel_mem(char *cmdline, > + unsigned long system_ram, > + unsigned long long *crash_size, > + unsigned long long *crash_base) > +{ > + char *cur = cmdline; > + > + /* for each entry of the comma-separated list */ > + do { > + unsigned long long start = 0, end = ULLONG_MAX; > + unsigned long long size = -1; [] What is the point of not using `ulong' and `u64'? What about another names? +int __init get_crashkernel_params(u64 *memsize, u64 *addrbase, char *cmdline, u64 ram); _____ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/