Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 2 Apr 2023 17:37:48 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Khadija Kamran <kamrankhadijadj@gmail.com>,
        <outreachy@lists.linux.dev>
CC:     <hvaibhav.linux@gmail.com>, <johan@kernel.org>, <elder@kernel.org>,
        <gregkh@linuxfoundation.org>, <greybus-dev@lists.linaro.org>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        "Alison Schofield" <alison.schofield@intel.com>
Subject: Re: [PATCH 1/2] staging: greybus: add a single exit path to
 arche_platform_wd_irq()
Message-ID: <642a1fdcb2648_394c3829469@iweiny-mobl.notmuch>
References: <cover.1680185025.git.kamrankhadijadj@gmail.com>
 <e670baa9bde47a3bdb02e59ec37a438a62c52dd1.1680185025.git.kamrankhadijadj@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e670baa9bde47a3bdb02e59ec37a438a62c52dd1.1680185025.git.kamrankhadijadj@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g0NvxRInSpm98Zfi3UxYx/g2pHiOqDMbpMpmMDphHojqi/mcRTXLG+fW1l4I?=
 =?us-ascii?Q?ALFQbvIb934TV/H4eYU1QLD1TXQ8273kdylBxbr7ZOGu3FsfLNSS93PNtQml?=
 =?us-ascii?Q?8/2QI0rrN8KfanpNuAna4wKYWQ9qI3d3TYz0wWqUdDFCaQ4KYDJaZvq10pkZ?=
 =?us-ascii?Q?Xn/iPiLw4YyA0WsL12ip8U+hNmuEhOvZrdjyE+eqAFfJVU4cK0Mhof+/gGKg?=
 =?us-ascii?Q?U9vocvTEfcCeJ334ouZI2yY+EubjfxrNoIifKFZtJ23QvxI85uR68woVwbON?=
 =?us-ascii?Q?QqK99rBb3b0dhl6Ga6HubrUmkHT2U/ArFFrwNELyd5+DaUcyo5EetUOlIrF9?=
 =?us-ascii?Q?HuDOKkXUwiko0+qgTpXh3FjBj8fMu2pmzpb7qi4FR/ojjex2gFWMeSvCh/px?=
 =?us-ascii?Q?h1z5dJ3LRi6iqQajtXKqVUy36FhJT4wFV6H1NNax+meo8+KUrjAcAqNtl38V?=
 =?us-ascii?Q?t7xcCX+2M3qAvQoUOvsBf2qfAGA86X4txU7flSL/hwMthanRjRrhiXCo5oHL?=
 =?us-ascii?Q?WdpWBFw9pZe6xUAwOYj2DK9CXoOguxu2skAqaaE1w8DEVMfoBIomzELrJ+el?=
 =?us-ascii?Q?7hDOq8CJ6/L85vTeMuZQo5HbsZ2T0Ds2rquogAR/l1JIDCDa4V+wo4FZevj9?=
 =?us-ascii?Q?y8v8C+xa4wO8iAfC4Kw1DYkshFCGbs7C4kuT7kjjQ3KWNNlJbRijxHINYKBt?=
 =?us-ascii?Q?kJMmZEtburToMTA2ZKyOlZvFAkapewVTttYLQyuJTJL7sl7NYLdcY6/R0ikI?=
 =?us-ascii?Q?pNKRYArC22vg04hxMlJjKAQZKmRQMBsoWNaZOX2ssxOMC4ejrdq4fZ+1WDZP?=
 =?us-ascii?Q?nlsqUG/Ffjogv7rjhFOopJGV5PmNjUf80yijGZ6N2aCbEQ6yH4+pqG5vVGKY?=
 =?us-ascii?Q?vDnHTdYaHhUFZsGMkahAKwJarSmf5FapbFQsZtjalKqkyPTfbiV9KRECvBiD?=
 =?us-ascii?Q?ZQXN4spnwzFFpgIZQ6QeDHKjcDzHtfrKNulYWbDclMsu6htaMehTUjQg8W1O?=
 =?us-ascii?Q?m9ev7//beCt91Lbh9/UdjHFD16i/+8wAfNeuqCoaHoRpkZ1ncYmiutQK/YJ1?=
 =?us-ascii?Q?12R99lfARoZXlEfnMcBe3WyaIqCOiFHVsVr2sBtg1tYTUqnF1ci6s5b9XSLH?=
 =?us-ascii?Q?vT4OIiJTv/jMP4LiAe2LLHG5y45ib5PL7+KXjMuz7f3/MUUOOnqLgjpTUm+Z?=
 =?us-ascii?Q?DJj1l54uUAa/oxykYy6FyvMaA2z8p4VsJtAq6SZkVJN+kz38ViF0n4NAk7um?=
 =?us-ascii?Q?35VdphapH9f45djYEkj0UtFyr+/834wL0w/ZEwBQJ6PMdbZgDXzX6eaH9ai0?=
 =?us-ascii?Q?mRWK+VozelRiQZBoEG4ZKic8TY5qcZqsKGPxJizZ3B4L/H6rP3CwbKiXHNmL?=
 =?us-ascii?Q?39Io9YAiZkB+67UA6NFkndRhTwQ/pLuhDifHAAf83SaFLYq8jxcakXWGiQfb?=
 =?us-ascii?Q?J+rZ1jKr1ADkfOiBJLMDv2XdvNnlv3KqU1pHn0gJN+ehnjtggeMiFifiZP6k?=
 =?us-ascii?Q?HrTUpJ178uqiKp5Zr8lrO1kcFdZWz7ftvPhOmcvlykFqW6mkOwoy4Yd5nqvE?=
 =?us-ascii?Q?uknpWRLnxS34ssbIhg0FQxl0HLks+Axbqv2uPZ8V?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e0a006c4-4b11-4454-9a81-08db33dba828
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 00:37:51.7045
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RiY5U2vZeJGTidp9QcRIY9Mf0VEibyevH7lpRRaDqcMRXzHgbQA/kiY8/cXyca6K32jMuenp9XYgofg61H6teg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5281
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Khadija Kamran wrote:
> arche_platform_wd_irq() function has two exit paths. To make the code
> more readable, use only one exit path.
> 
> Suggested-by: Alison Schofield <alison.schofield@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>  drivers/staging/greybus/arche-platform.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index fcbd5f71eff2..a64c1af091b0 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -153,6 +153,7 @@ static irqreturn_t arche_platform_wd_irq_thread(int irq, void *devid)
>  static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  {
>  	struct arche_platform_drvdata *arche_pdata = devid;
> +	irqreturn_t rc = IRQ_HANDLED;
>  	unsigned long flags;
>  
>  	spin_lock_irqsave(&arche_pdata->wake_lock, flags);
> @@ -180,9 +181,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  						WD_STATE_COLDBOOT_START) {
>  					arche_platform_set_wake_detect_state(arche_pdata,
>  									     WD_STATE_COLDBOOT_TRIG);
> -					spin_unlock_irqrestore(&arche_pdata->wake_lock,
> -							       flags);
> -					return IRQ_WAKE_THREAD;
> +					rc = IRQ_WAKE_THREAD;
>  				}
>  			}
>  		}
> @@ -204,7 +203,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  
>  	spin_unlock_irqrestore(&arche_pdata->wake_lock, flags);
>  
> -	return IRQ_HANDLED;
> +	return rc;
>  }
>  
>  /*
> -- 
> 2.34.1
> 
>