Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 2 Apr 2023 17:36:24 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Khadija Kamran <kamrankhadijadj@gmail.com>,
        <outreachy@lists.linux.dev>
CC:     <hvaibhav.linux@gmail.com>, <johan@kernel.org>, <elder@kernel.org>,
        <gregkh@linuxfoundation.org>, <greybus-dev@lists.linaro.org>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] improve arche_platform_wd_irq() function
Message-ID: <642a1f88bd232_394c38294a5@iweiny-mobl.notmuch>
References: <cover.1680185025.git.kamrankhadijadj@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <cover.1680185025.git.kamrankhadijadj@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eCnuJA4YNbeZLt1ZHgCgZsLVXgiSttx+GO3dqiq+0zLMNaJXJ/vZYTVfTbcQ?=
 =?us-ascii?Q?k23o4SUnfcMX31zf4+EwLi9hDn657ijJV40olQzNfOzu0mPc0Ssd4PqeqmWy?=
 =?us-ascii?Q?lSEmuyICtBsQK8hRIV9Lr6y2zOzhWoerk+OZ4icLrLM3mAFEual82GoHmDqO?=
 =?us-ascii?Q?SEMgz2eVZW04FWCubv9u0ZTrWbUIllacpnSx14E0QXZ/kXZwzzJU82L8WhxE?=
 =?us-ascii?Q?6IX5glvZjmUa/ZPouc5nKfopzqZpCyhu7DXrBWE8TN5eN9lwLRwEX0q4sfmB?=
 =?us-ascii?Q?S3a0DElKecw9886+tNS3lTm6duvG5EnDsvb3tAa2Kbbs16Ek3xB5F/eBADWy?=
 =?us-ascii?Q?dU0XCxTW3LkNbPdKtTOPhwLiUhlhnqleo56Q6h18W0B84yFvUEKdeAl8fIOv?=
 =?us-ascii?Q?hhMAm2VenB3+0YH+efUoV5A+l0aBdxhFdLow3S5LoZl9zMrpTOxnbyIUl9li?=
 =?us-ascii?Q?/xepzbvpy9fpLk4oJ+ZIP0kDK1JLPU9Lt3mVQbvGWecJ3Qu24gJo8hODjRuN?=
 =?us-ascii?Q?uIc6PFG9OXcDW6t7CiW94iNoWxgWs5FpfzWH52dmmNAUk0Qd85daH5TmVjQA?=
 =?us-ascii?Q?osgYhf7Fa1tV/gMpRTfiGZRBalMXKkWzWL4i3BKRI2C2mWTcz8fc1zecH3yN?=
 =?us-ascii?Q?yqH6VRmcthPFRBpHh32s+T+Q/qvZX0YfrARhMhGVhMXdEvrRMzZjDn8bDMkp?=
 =?us-ascii?Q?1PgI82O3GaYShO/yedw6mTBclvXfoMcvpnARls15e6P83UTySg1qUEcPqDx4?=
 =?us-ascii?Q?Ib+opg2T8EoIdV57zl+2yYB2DA32h1+V64fv3zEgCWXwaZQfjO/Cdhdqn40u?=
 =?us-ascii?Q?NjR8lVr30+OXrb0HBAH77lX04iX6+6jODlbgBhTbTQ6Ahf9mphrxgcp76vyu?=
 =?us-ascii?Q?Bx7YnwR8H9JrNsFbCbeQEPu2WW0z2k426yJKAeTv8bQHSfwiNLcG1IxKzR8Z?=
 =?us-ascii?Q?a2/eVZQQbB5hXXDtPwkh8XogwpaxuazCv5kHRhMzuJsR2ofuWEiE1AcuDcsj?=
 =?us-ascii?Q?iOc34ZJkHCYUrWnZKkwZENouEKNsVEB8/9E4bNz36kG78O7/tuH7xIABrgpv?=
 =?us-ascii?Q?a2AyJRQPq3BjoVx33X5kNMdsZWxHNDXKKp+rSwdhoxRu1hn3SakWyC56B1gD?=
 =?us-ascii?Q?M1B+5AvFyUyaMeuz+bp1XOjrXrXVxPUgwEDrpDQHyJAWYTY1vxwZr/NzI7iz?=
 =?us-ascii?Q?ZIE7pdxtc+FWzK1HuAJltzXdVXNCQazuNkjrAnNqUNXymU7Ds4qHJSKIyYx4?=
 =?us-ascii?Q?D6YOKIGyGU2gcm6vfefxCTEpSEkKwwi3g/RLZn1TW9inGSzqOaCN3k1otzew?=
 =?us-ascii?Q?PEhTjhhg1sWMzrVlCviHdEqdtAyllSDOkOw6Xb61Q5yv+kZEZhluW6T8Iz5k?=
 =?us-ascii?Q?5LclualqHUGnyFvf/34OB/aVAMG+9W2xq7eJB0FCjiC5KK89mwv+Q2fLH5fq?=
 =?us-ascii?Q?rzaDP8tqhl8Wnu//Dx4yciLnWedFUHVitolppnxrAQ0IZMYOdIMzFPxgTG2c?=
 =?us-ascii?Q?paDw/4wo9x4H3xZqJawNnxl2qgPY7Ro1rGPzrpDYV3Mw9QblNz43EvSLAidE?=
 =?us-ascii?Q?KVxSOvnDBCtr0dOfpddkEdg7zVsZeSH+bZecDfam?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9082288f-14c4-421b-2bda-08db33db7672
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 00:36:28.4282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kn1WxvguhbLSmM5fbCGXsIAnpDBy2DD/J7hLu/xyMFbSgFDnrwrJMwhudpBng7f7hAJrW0KkBwzFqBMLpik6jQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5281
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Khadija Kamran wrote:
> Improve arche_platform_wd_irq() function to minimize indentation and fix
> checkpatch issues.

Minor point but the cover should have

'staging: greybus: ...'

... for the subject.

The function name is nice but it is a pain to look in the code to know
what part of the kernel this series is for.

Ira

> 
> Khadija Kamran (2):
>   staging: greybus: add a single exit path to arche_platform_wd_irq()
>   staging: greybus: refactor arche_platform_wd_irq()
> 
>  drivers/staging/greybus/arche-platform.c | 84 ++++++++++++------------
>  1 file changed, 43 insertions(+), 41 deletions(-)
> 
> -- 
> 2.34.1
> 
>