Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Tom Rix <trix@redhat.com>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com, nathan@kernel.org,
        ndesaulniers@google.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1y1n9wxs0.fsf@ca-mkp.ca.oracle.com>
References: <20230326003222.1343671-1-trix@redhat.com>
Date:   Sun, 02 Apr 2023 21:38:13 -0400
In-Reply-To: <20230326003222.1343671-1-trix@redhat.com> (Tom Rix's message of
        "Sat, 25 Mar 2023 20:32:22 -0400")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2l07dk8sVH+v/Ie83+U8fKXyGihSklwzekD8xDBzhz41JrWZUa9s1kKKXo4u?=
 =?us-ascii?Q?fZgfPN3KWIt17eK2GatV3suntFTeJ9qIWmOAhP5fk3KeNJgCXy6JpM3UIkzm?=
 =?us-ascii?Q?Pw+su8dlKX0MXl0PsROwANHUDSsBqEgxkND40cyLQzISjeJLsQlgBgNXvsX4?=
 =?us-ascii?Q?HJoNNWfsK31M1BJXX7Dlk3EK7yll1ko6jYG2huEjFeypf6sr0HP9hhoKaq1u?=
 =?us-ascii?Q?dH9SOftBs1RYhC71QZypxoG5xYUHooFDqnG6n1j7Nl0hP3I0/QwQtRk95GIJ?=
 =?us-ascii?Q?skHui0SIWgLOfd648zlJ3YtxOMmfhsle7Q+ag8OnAPy2of9uZvDSHwlDmzFP?=
 =?us-ascii?Q?07cyyqnH0jyT+0LQK892xkiDZZnobqJwAKzX35VBTQNv0GWmNh9BOZCm7JKU?=
 =?us-ascii?Q?JsUqwhY8BuvyAnzWhyDmjjAvcnwTmObCNA+3MiJwz0kKhCw7cwwyBRsttQ5h?=
 =?us-ascii?Q?AE7CeB6I96P6MzWT/WhK1+0Me8AMo2xYY9SlZMd8+nvnAGAonvU2VquDgS6a?=
 =?us-ascii?Q?zk3F03oTyZZjpCMHqBchhd02Jl7kmoHHa5uy9L1fMPF+UXec4P3HnNZ7hiYJ?=
 =?us-ascii?Q?be0yTHmei6WoPiVDE4JF7kJUMRknHn7YAta5t74hNwuwfLL5+2i68f9ZC3/8?=
 =?us-ascii?Q?n+fZ7JbKivaWypm5+l/lQUF6pfpyacnnveSYYyZzbtkpXa3sy7rgHDMW3iUS?=
 =?us-ascii?Q?rP2UAHKsKGqg9FLPrRYmVlvXAizG+J1AmaCme61gChagBjvJgo8Qt9nx7Pjv?=
 =?us-ascii?Q?ORL5DxSnKa0C7nJ3VpmX0DplShn0IGEQqt5JiErXuDim/OdBCAWyneZSArQO?=
 =?us-ascii?Q?/+mSt7yuhIWWEqBvbi7U+rLFFaZVW4IOKFbbG5NdlT0NK1DHJd++LEFBDqt0?=
 =?us-ascii?Q?aAtLPNTvGW5gJZViYdmVNjHx2GfZsHWjVqODJ4qB3+uUlKg42ubq1Os2tQb1?=
 =?us-ascii?Q?sDp/RYoFWf8c8Y/igbDgo3y6f503zqNsoGvsM1t4wDSu7FXoEG1873emWCyG?=
 =?us-ascii?Q?0MTjyqcJyBhfsWUgQUnJj7ILz07KyAzqq+BttoWvOAW39HSuMRUqnPLFqvXQ?=
 =?us-ascii?Q?uv6v2i1HZ4ywA/tVz75Q7sZ4NpMMHppCHMwuqJxpB0bOIAh3vqce/ZEIK3DL?=
 =?us-ascii?Q?QQ83B2sL4oItOJrkXlXaWnO4W5KoKS0S7Of2MwGqUSuoyFMnKdLIWob+o04e?=
 =?us-ascii?Q?V4jFuSyIF4NyTlXeTkVAyIQJ4/pKLAtK8E+Rrpfps1k0qfSBdFIJYtbLqw5f?=
 =?us-ascii?Q?R6L41n7+tj/H3bRycNMbRrWbE1t7IeFJJR4Khx1+h9dtYkolwnYHw/VxHFab?=
 =?us-ascii?Q?93HOrv2tJljxH06nUY5GO3uENA5pqq+6FUwZ5N0yNAnemRE+PHPyF8mXMUpq?=
 =?us-ascii?Q?o5QyEjoH9y0HHEVlZ5cZM3ODrhbBvvEW7ySqP59uQhH8oiNU5CAdaWx9eGol?=
 =?us-ascii?Q?xUT0Jz0BBwsre75StUYm76NnNCYF2LI9sbpj95v1hcfBq4qzlM/dXQ9lppRQ?=
 =?us-ascii?Q?70T9yxKxYze4QHaE1J2Z5+qByvdgk13r5fo3M2tCsUU8T93tEpSX1Ua+aU3t?=
 =?us-ascii?Q?XhVoTfXyk0Ns4Q6anIDct870G6cL+c3AYAomqkBfR4yJQ4DyrjeiorIlnbq5?=
 =?us-ascii?Q?8Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: AkjwWgejF3TFftRSlsvwcDmP7OT40ecrEs/kK1U9l1Tb7hQa0rKty4XpHynGxBdrIF39BnalW/24zUrN+PNPh0S1yvqtHFA5uF2Kr86sI8F1bToCB0LtsmzNMBQlhc0aE9gN3eLZKFGX0pxnEXp0m0bEdOrohoK3wyQ6ATxi2I/8ns2YBkDa77hq4WMFVr7ueEEQEOsGsqZHORcjST6jgfj13Z4fWnI9H5s1yaXafFDJ712MNC2DP3Ov2+fAIj0+cw7MGpUC8hVSvxsxrNwyc5yUU2awbTIKPd00oRQNIdsGBHZHvMge9g3x+eVppY7R7jY0oc2D9LNm74G3qTXh5sGkmD2I3Vz74e3gXNRB4ZXOtYIMeIxE5ZhKAltDRkfhpjd1pbLgrO7AiA7BvR72pgLoTqdu4VpjpRUKMTkKKynHxaBZwYa35/uDmffDz1p2P1BEqWvOnxJMYrReuyWImLEikWS6REVE9gFWBYjp04Uv76nT9UE1NtFHd7pyOd4s3zUTLjZUCp+FixIGxZ/uH9fI3VyJCNwCBzUiU65M4h4WIerdy7B99usNT3xayQMp/y8IhW//zPs03T6DOuJ64OU0I4907ufxyiNwZd9rkWGTZ718eHq4V8c9LHNKPLPOXQwT5ddWwXk22A9MiLuNfyqWgn3+uLz/cFtYHxr1hAPWoKpx8arldTDxZGMcBkxGpaXjuP+tsAjxS6tXg+zqlWVkUZCJ8p5ZRG6GtsCtbccb6bzkDTOGhm4IkHggsdYi7ymaHSgMaaJwE+ejJ9IExOp+evmFxukLnVVx+gfksZ3iFKAMfKE5cwbnvmGLot1pqwQKjY6izedX9IW9HZh7Iiv0BvBIazkLo7QynrFROAtjJHoSSH0IXE5mC61QYwsx+krjMFXmZtJsL8jgekLZoA2fFcMR/Id932E2qfoojGg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97e3e901-ae47-42b6-a455-08db33e41851
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 01:38:15.8457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uIkW/N+moTfvyBujmqCqAG7SMOvDYDyoWX3NBt38ToUnUHkH26L+AAnwqTLJe+0tqRAJulQRLdDApofaN5yhdDO3KFQaaRWCUNiTbqJ8Dh0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5328
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-31_07,2023-03-31_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0
 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0
 mlxlogscore=917 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304030010
X-Proofpoint-ORIG-GUID: 33D9bT8Ol93SRLxa_oNF5oYi7uTN9YNQ
X-Proofpoint-GUID: 33D9bT8Ol93SRLxa_oNF5oYi7uTN9YNQ
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Tom,

> clang with W=1 reports
> drivers/scsi/scsi_transport_fc.c:908:6: error: variable
>   'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]
>         u32 desc_cnt = 0, bytes_remain;
>             ^
> This variable is not used so remove it.

Applied to 6.4/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering