Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Tom Rix <trix@redhat.com>
Cc:     skashyap@marvell.com, jhasan@marvell.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, nathan@kernel.org,
        ndesaulniers@google.com, GR-QLogic-Storage-Upstream@marvell.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH] scsi: qedf: remove unused num_handled variable
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1mt3pwxf3.fsf@ca-mkp.ca.oracle.com>
References: <20230330203444.1842425-1-trix@redhat.com>
Date:   Sun, 02 Apr 2023 21:45:59 -0400
In-Reply-To: <20230330203444.1842425-1-trix@redhat.com> (Tom Rix's message of
        "Thu, 30 Mar 2023 16:34:44 -0400")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OKprQ9fqPls8P5j+LYJAA/kCvigK8kWLeGwAAKRDEsyf46WBd5r5V3qRr3+k?=
 =?us-ascii?Q?QLe4pLyA4Ot9CshDsGPJ0SmIt2M8JmW51pxzC3Fg0xwPlmp3S92cLITkSuYJ?=
 =?us-ascii?Q?UD+QKrAnjT9AA6A7skqNMSfGAXDU4MLa1npulzw3qnWtzFE3qjYXswtHGbia?=
 =?us-ascii?Q?LPzH3OlkJsyZzw3y2SzSQm5ECcAZHBP4WeP357csbO8GRc7jE6G1AX/li/y3?=
 =?us-ascii?Q?0f6ZwFiqZ5cOO83bJ/v7jmSgHzQPrw2KnQwLNxlSEE/dJjuimb1Ye6IRmn3+?=
 =?us-ascii?Q?c2RW4NdY3TDrvSM2htUwBNmG2qU81kcVVyF/liwUsLGHNsWozw+CJ97bVifd?=
 =?us-ascii?Q?cVvGMIz2XglRkZ286cJFXhqjJLC38gFNOvYIKqLlppWg8TS7BaJusPFqdm9y?=
 =?us-ascii?Q?33G9iQ9Utym7bSghAqix47UBT/xZaAUVaQCWBaPOaQc3HV3QfpwtG6I9CeyO?=
 =?us-ascii?Q?ZIzA4IToc9G8snDvhfLeWdRfDKe8JGKPG+go2EaO/QHootIX6q9fR3RVPVEh?=
 =?us-ascii?Q?H6Rw09mQFs2Z/wwLGHfZXUurh0n74VUXKZJW+sKsGVl00yaqnVZgePNA7QTs?=
 =?us-ascii?Q?u4QWPDF8ei187gbpNCCRcx4O3WCu7HLLS5dR2uvfNqT90OPhkQc/rGTr0ANW?=
 =?us-ascii?Q?jgK19F2mkxyQ7k65srM62vNvfme8D7cjhI2sh1DONV/ohNLefMXVp+hrqibj?=
 =?us-ascii?Q?C1XUXNJMQcxshIZfdvAHiCqqezdOjRm+otqoB4YKqtPhpT+mquX6Jg6x0dmo?=
 =?us-ascii?Q?gOuhKlAyBMy0bevdr1QiEbcF6BQsrDdwLRISu99JRXierFf3c15enu4Tgbj/?=
 =?us-ascii?Q?rFm6c8AMyfJ3Sf8sZStsm2UTv4INqhdAT4hTI+VskvxMzmjEYLxPi9QEpL5q?=
 =?us-ascii?Q?PpGQBCrhp6RqSRhbB40OKIhsE7q0hJgnfwgSpgLURBFdR5MapsX82e7XAAW/?=
 =?us-ascii?Q?HRTPtbZiEsR4llY61oMFvOKIJa9Ubwrkka0NQqJ+FqZv187A8RqpLHhyYnUN?=
 =?us-ascii?Q?RiyAHUELrwQabfpezNZcnngDwJTbTmnvwAZQbndDf86YeO3EJefgCUkT8Dvf?=
 =?us-ascii?Q?h4+v0i97Z32rGWD1izKGGTzAJihW8T3Y//3Eqto6k0DCg+ieeGuUBjzRvzFQ?=
 =?us-ascii?Q?C3z7RsCLXUoP53AM6KXruj6m9nxTj6vGZScpdFQfVjhhfGOkpalqI5kLN4n/?=
 =?us-ascii?Q?EgYSN5Ye66tAEn03LvKbccBOp0pM6WVRBa9uccCkQoL4/T6lwL3vYKtXlCWW?=
 =?us-ascii?Q?7ElXnNYZRDwXpCSyRVhdHgwgTjkl1Jy2k5peMIQz/zulLo4VGnjCmprgm4aC?=
 =?us-ascii?Q?grIxufEuFaK+EcuTiuPKYNQn0IwcynrLekuNkmYzve68jWjQVtJzwoGtRlQn?=
 =?us-ascii?Q?6ncZmxU85X3LPd//bUTexm40HlFqYuo81d56xZIvbfTF2f5ERLRJ6o3a1rNR?=
 =?us-ascii?Q?N4W1sZNs8W9stVHvDdbh27/aFw5AC8XtFVJnjPr/wm6mlrpITkBCiSl8dTXN?=
 =?us-ascii?Q?/UYnpAg5D1ThWEybydc51j9Bmhb8qCW9jINd/oAdt+2ZWZyqZsDnK4v7aObe?=
 =?us-ascii?Q?L1+WVRIi1+x5HJTtA+liI1UbnA/56WKXfHMlxV+gJw2ZuYD0Axcaf9+j9x54?=
 =?us-ascii?Q?vQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?aiNbGWgcNujWfRHO9nu2pLDpuusxRDZkcMLAJW0o54lslroBmst5rGqkEuBG?=
 =?us-ascii?Q?t5/Ak57e4xoMbRmujX1S9vNksCKRzdKmMkWpuZ5Rb0UZ/HWqy8m5EE4YP2Wt?=
 =?us-ascii?Q?ZwGyaEXfHDDMOMLf0gfTWzrOnUX2lOj2xQEvAW1UUv8svvWRW9cOzXqTPGQf?=
 =?us-ascii?Q?OpDzeTDkUqDH02RAjKAsbglw897w/VEtfcgkRSdBdUXFjy8wTgGqbOUCdrgU?=
 =?us-ascii?Q?8/JNrfqW/LJxEO7fDS905j77IySAA+ZwxjSsP3PFr2o3vag/DVuvG5DzZ9fW?=
 =?us-ascii?Q?h+pLUxXmBYqAuENxDs8A5ZCBDwztRvjkuOh5zbBdCV2A4yz+sdc8O8EV/BtJ?=
 =?us-ascii?Q?HvMXkOCw7KzTM2VKsZpYOc43BvRaWd16n4/VBbFf5G/1boRr2RYAtVEQ27Ad?=
 =?us-ascii?Q?lWnbZSaK8nNkzAVB2H4tZi9LsjUvpzrLGPxC2ErGgK1+QQHKiaE1G4irStAL?=
 =?us-ascii?Q?TRyYxlRNMIn9ygorPM0vvY2pJZ50Tw6vsEmVlmVy2IsD58CnKfCCjDi6dMk0?=
 =?us-ascii?Q?MoC3zyodFXJyfTdUDvmEDC8DMSj41Npvpwym1+GYVVtREfWFQb2IAXJ1vmyQ?=
 =?us-ascii?Q?SoSfrGRwxofLP9EoTVRn6vfCIHhm++2THxch1SYvK2JnDtZnrjCHffFb9TT0?=
 =?us-ascii?Q?My+Irmemoojwqu9EcD8KhHAjW3iBv9RDOu+sv4rp+5tTN1TUsuXudtEDhbaN?=
 =?us-ascii?Q?B1gfZMQL/6T/mYnHdK2cZg6O4V+Xjub+EkIQv38yOsAfVC/TkpttU7XtCMaF?=
 =?us-ascii?Q?sWNk5Yrd28F06MGmxPifMJKnVK+tOlUPEw5PNZIGP+PibUtYUtg3Q9mErAo9?=
 =?us-ascii?Q?Yfg4dQmOFwu2k8GoiS0gIS4fDauvOWZIvkXtHq1HdmpAyBSNamAnfW0PhRo/?=
 =?us-ascii?Q?9tTDlo3topiWEK0OFC1jMvw4nBZ59ibUuL7QlXydF0ttT+e/XSWlYeX112of?=
 =?us-ascii?Q?uUNcUwdO7KGnEQnOMtL4Xw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6f0924c-36a3-4f67-9a56-08db33e52e20
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 01:46:01.9339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kgmHScZfdS+B6PfK9jC1rFQ7In6uZE+KniiRssxPBmL9UmZCynF4VgIS/ZTGXSAyAOUerpomikGFebTI0Khrt0PDhCx+kPDQmv7KlhMpq6U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB7315
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-31_07,2023-03-31_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0
 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0
 mlxlogscore=709 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304030010
X-Proofpoint-GUID: 5FgrtQJxyBlyCNXa-nSI8JmBItUvfrct
X-Proofpoint-ORIG-GUID: 5FgrtQJxyBlyCNXa-nSI8JmBItUvfrct
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Tom,

> clang with W=1 reports
> drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
>   'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
>         int num_handled = 0;
>             ^
> This variable is not used so remove it.

Applied to 6.4/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering