Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fcf40deb-e731-c257-fb77-7fcfddf623b1@redhat.com>
Date:   Mon, 3 Apr 2023 09:59:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH 16/29] selftests/mm: UFFDIO_API test
Content-Language: en-US
To:     Peter Xu <peterx@redhat.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Cc:     Andrea Arcangeli <aarcange@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Nadav Amit <nadav.amit@gmail.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>
References: <20230330155707.3106228-1-peterx@redhat.com>
 <20230330160752.3107283-1-peterx@redhat.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230330160752.3107283-1-peterx@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 30.03.23 18:07, Peter Xu wrote:
> Add one simple test for UFFDIO_API.  With that, I also added a bunch of
> small but handy helpers along the way.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   tools/testing/selftests/mm/uffd-unit-tests.c | 111 ++++++++++++++++++-
>   tools/testing/selftests/mm/vm_util.c         |  10 ++
>   2 files changed, 120 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c
> index 6857388783be..dfb44ffad5f5 100644
> --- a/tools/testing/selftests/mm/uffd-unit-tests.c
> +++ b/tools/testing/selftests/mm/uffd-unit-tests.c
> @@ -9,9 +9,118 @@
>   
>   #ifdef __NR_userfaultfd
>   
> +struct {
> +	unsigned int pass, skip, fail, total;
> +} uffd_test_acct;
> +
> +static void uffd_test_report(void)
> +{
> +	printf("Userfaults unit tests: pass=%u, skip=%u, fail=%u (total=%u)\n",
> +	       uffd_test_acct.pass,
> +	       uffd_test_acct.skip,
> +	       uffd_test_acct.fail,
> +	       uffd_test_acct.total);
> +}
> +
> +static void uffd_test_pass(void)
> +{
> +	printf("done\n");
> +	uffd_test_acct.pass++;
> +}
> +
> +#define  uffd_test_start(...)  do {		\
> +		printf(__VA_ARGS__);		\
> +		printf("... ");			\
> +		uffd_test_acct.total++;		\
> +	} while (0)
> +
> +#define  uffd_test_fail(...)  do {		\
> +		printf("failed [reason: ");	\
> +		printf(__VA_ARGS__);		\
> +		printf("]\n");			\
> +		uffd_test_acct.fail++;		\
> +	} while (0)
> +
> +#define  uffd_test_skip(...)  do {		\
> +		printf("skipped [reason: ");	\
> +		printf(__VA_ARGS__);		\
> +		printf("]\n");			\
> +		uffd_test_acct.skip++;		\
> +	} while (0)
> +


There is ksft_print_msg, ksft_test_result, ksft_test_result_fail, ... do 
we maybe want to convert properly to ksft while already at it?

-- 
Thanks,

David / dhildenb