Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ebc31b2a-82b2-a197-1a8c-df2a509b19e4@redhat.com>
Date:   Mon, 3 Apr 2023 11:59:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] fpga: bridge: fix kernel-doc
Content-Language: en-US
To:     Xu Yilun <yilun.xu@intel.com>
Cc:     Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Tom Rix <trix@redhat.com>, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230330174505.158920-1-marpagan@redhat.com>
 <ZCkiWfQQsFEaHm4K@yilunxu-OptiPlex-7050>
From:   Marco Pagani <marpagan@redhat.com>
In-Reply-To: <ZCkiWfQQsFEaHm4K@yilunxu-OptiPlex-7050>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023-04-02 08:36, Xu Yilun wrote:
> On 2023-03-30 at 19:45:05 +0200, Marco Pagani wrote:
>> Fix the following warnings issued by the kernel-doc script:
>>
>> drivers/fpga/fpga-bridge.c:99: warning: No description found for return value of 'of_fpga_bridge_get'
>> drivers/fpga/fpga-bridge.c:163: warning: No description found for return value of 'fpga_bridges_enable'
>> drivers/fpga/fpga-bridge.c:187: warning: No description found for return value of 'fpga_bridges_disable'
>> drivers/fpga/fpga-bridge.c:238: warning: No description found for return value of 'of_fpga_bridge_get_to_list'
>> drivers/fpga/fpga-bridge.c:268: warning: No description found for return value of 'fpga_bridge_get_to_list'
> 
> I see you are trying to clean up the warnings, but I found more in
> drivers/fpga. Could you help at least fix all core code,
> (of-)fpga-bridge/region/mgr.c/h in series? Thanks.
>

Sure, I'll do it.
 
>>
>> The patch is based on top of 38dbcd697770 ("fpga: bridge: fix kernel-doc parameter description").
> 
> I didn't found this commit, could you elaborate? And you could put this
> info in changelog, don't show it up in mainline.
> 

Sorry, I accidentally put the wrong hash. I was referring to this patch:

https://lore.kernel.org/linux-fpga/20230301140309.512578-1-marpagan@redhat.com/

That has been applied to char-misc-next:

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/drivers/fpga/fpga-bridge.c?h=char-misc-next&id=7ef1a2c1c9dffa177ecc3ea50b7f5ee63a621137

Thanks,
Marco