Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <055f3504-0d01-aaf1-1c0b-379c6be702b1@hust.edu.cn>
Date:   Mon, 3 Apr 2023 18:30:01 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH] scsi: lpfc: fix ioremap issues in
 'lpfc_sli4_pci_mem_setup'
To:     Dan Carpenter <error27@gmail.com>
Cc:     lishuchang@hust.edu.cn, James Smart <james.smart@broadcom.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        hust-os-kernel-patches@googlegroups.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230403074821.5121-1-lishuchang@hust.edu.cn>
 <6df77fb0-6b3d-4e3b-9c5a-40e217e8dae9@kili.mountain>
From:   Dongliang Mu <dzm91@hust.edu.cn>
In-Reply-To: <6df77fb0-6b3d-4e3b-9c5a-40e217e8dae9@kili.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/3 17:16, Dan Carpenter wrote:
> On Mon, Apr 03, 2023 at 03:48:21PM +0800, lishuchang@hust.edu.cn wrote:
>> @@ -12069,9 +12069,11 @@ lpfc_sli4_pci_mem_setup(struct lpfc_hba *phba)
>>   	return 0;
>>   
>>   out_iounmap_all:
>> -	iounmap(phba->sli4_hba.drbl_regs_memmap_p);
>> +	if (!phba->sli4_hba.drbl_regs_memmap_p)
>> +		iounmap(phba->sli4_hba.drbl_regs_memmap_p);
> The test is reversed still.

Thanks for your review, Dan. Sorry for my internal careless review. 
Shuchang is creating a v2 patch to fix all the mentioned issues.

Really sorry about this stupid mistake.

>
> If you make a mistake, you should write a static checker warning so that
> you never make the same mistake again.  ;)  See attached.
>
>
>>   out_iounmap_ctrl:
>> -	iounmap(phba->sli4_hba.ctrl_regs_memmap_p);
>> +	if (!phba->sli4_hba.ctrl_regs_memmap_p)
> Also reversed.
>
>> +		iounmap(phba->sli4_hba.ctrl_regs_memmap_p);
>>   out_iounmap_conf:
>>   	iounmap(phba->sli4_hba.conf_regs_memmap_p);
> regards,
> dan carpenter
>
>