Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4342873rwl; Mon, 3 Apr 2023 03:42:13 -0700 (PDT) X-Google-Smtp-Source: AKy350ZHt6vJbRT6aDcfr9HJx6YPMnk7DPDtR1fvgACsEJskkbi7KgL3Q7W966mPGUMrLFDl/Z+o X-Received: by 2002:aa7:946f:0:b0:62d:b210:8c9d with SMTP id t15-20020aa7946f000000b0062db2108c9dmr18901719pfq.32.1680518533590; Mon, 03 Apr 2023 03:42:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680518533; cv=none; d=google.com; s=arc-20160816; b=FcAn0emub8MLqwb2a2zLzgm68fNuJhpyY2mZ/0zT0e3GmWTI643+91VLm9kVUWIK5P j70d/sKbg3uB+pDhZ/DjElMvqQ83KxMO6S/nAdubPSnc0JbSbGBi0c1lFI8qoFqhnO+e t3UtlKgY275M62LhzyLQM9g2hFtF9UNRUuIIMEjYxHamEtA43Im7fGltfEXAza6fJvfk BVuRvFr0FzP5gh31LwlaZOZLFua4jO5bwSR7/thgWwD5vkkQQyyPmil/uD3ZmDXPzsuk B+XDeJmiak/T/j8yERVWmpZJpMImiyubgXYqFmUkSWLl7yqxksjIE8tchXn6Ot6y/an9 dohg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7rH4uIzXK6l/huexlMRSE33rdhZjT66DcZAUi1ClaS4=; b=BW9BMhsgTImxeygT9dYZJudtdlZCwZJmT4+8HXMEM76lKJT59dpu+bQ+BfUpZo+WU8 HMtc0ZZ59fhzlCt6HB7kUr3KLMuKOx9XQWnYGSmgKJtLtzBnPgzwdbH2NnwIflX9S0e2 PhrWoisgW96oSVIyTrWYRpyoHMicBGDlFiWlhzQu5Fc9m0JcAocs/8dqrUIv7qiuMj20 VjxaLvHBKik5za2QeU5jiNkQfcRUVGh+i+ibRMG04HbPOVxyJ1sF820BfpXxa00Dsb8G oy+BpHxY13IVEw7DtcOvyXNNxc5y16p/3lIfMApBrnNTXShgdOo/TBtdo50PzUyk6Mh4 Hs2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VjzIrsxc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u36-20020a634564000000b0051353d86539si8151779pgk.687.2023.04.03.03.42.01; Mon, 03 Apr 2023 03:42:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VjzIrsxc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231788AbjDCKlm (ORCPT + 99 others); Mon, 3 Apr 2023 06:41:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231753AbjDCKlU (ORCPT ); Mon, 3 Apr 2023 06:41:20 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59C6B12866; Mon, 3 Apr 2023 03:40:56 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id ew6so115354390edb.7; Mon, 03 Apr 2023 03:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680518455; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7rH4uIzXK6l/huexlMRSE33rdhZjT66DcZAUi1ClaS4=; b=VjzIrsxcDH0WJ3uHgurjG8DLu7Ww0YaToip4InOiw5KExsOZhE+D/y/Ui07bKpTXNL Rp4jc5oYrBvXumCxwwiFEOlGrnQYRN+0P9dsQuNuiTcZ3K038TfNUK74tJpntKiVhnlp +0oZxYiGVujBc4kN/8SSAD7RPmRRhjVqksKKUHUYY50pkXoelsGSOlKtuwSw+DusZptk ba80/tO4D51qtrIEiRkhQou4Hk9pqZaPxYDH+kPzh/D11yQSd+mkpl+L8DuVONzxFToP nstJnVb4Su/u8u0PzC1WUHjDr3RNyLj3BOncQDyF2K2AJKE/OVvcjUfBqPmTuwto21Ic 5BRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680518455; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7rH4uIzXK6l/huexlMRSE33rdhZjT66DcZAUi1ClaS4=; b=sjM1RheZ6h2F83fNEkVhohjkhhw/MYqp+kJdzoNIrwrJL2XWBsVRMYFWVAi/CRklaN k8jhjMeO7G37zjI2kYrdAwD8PmFs64Q05HlxH8QwXrSGgTPPe1wxHFihX8crOjLzVWNl oitx0QDWAe3hH1S6enxSeCaGbEx7uH+Yt8INbxeqb5wJWY0z+2IYFhI5Q+IRWt7KaBsb 8DsFdorg2BPbCgR++ztN1WxuxGIJEQqzwI/h2Vnfqi/UHbfIHs1W6hYLiv5pSofO6K82 PBoVncLBjB73S0WbqhPPchpDAw+R9S/sjdrRgq1kv82Yhtx3Eg+SqpkXb146AoQLs192 l0Gg== X-Gm-Message-State: AAQBX9fXmNckBUEjAJkNavYzWUOiMpGzM3CHzlPLccOrlZbGwvhzu0J+ lZwf//AR9EbYBCxHAg0nRRs= X-Received: by 2002:a17:906:4fc5:b0:939:4d6d:1f26 with SMTP id i5-20020a1709064fc500b009394d6d1f26mr41117892ejw.50.1680518454254; Mon, 03 Apr 2023 03:40:54 -0700 (PDT) Received: from skbuf ([188.27.184.189]) by smtp.gmail.com with ESMTPSA id l22-20020a1709061c5600b00927f6c799e6sm4349395ejg.132.2023.04.03.03.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 03:40:53 -0700 (PDT) Date: Mon, 3 Apr 2023 13:40:51 +0300 From: Vladimir Oltean To: Clark Wang Cc: Ahmad Fatoum , "peppe.cavallaro@st.com" , "alexandre.torgue@foss.st.com" , "joabreu@synopsys.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "mcoquelin.stm32@gmail.com" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [Linux-stm32] [PATCH] net: stmmac: remove the limitation of adding vlan in promisc mode Message-ID: <20230403104051.swr25d3bpenha3wp@skbuf> References: <20230403081717.2047939-1-xiaoning.wang@nxp.com> <33b8501c-f617-3f66-91c4-02f9963e2a2f@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Clark, On Mon, Apr 03, 2023 at 08:43:54AM +0000, Clark Wang wrote: > Thanks. I will add it in V2. Please always check the latest state of net.git/main before submitting patches. In this case, you seem to have missed the existence of commit a7602e7332b9 ("net: stmmac: don't reject VLANs when IFF_PROMISC is set"). Please also check Documentation/process/maintainer-netdev.rst for next time, especially the part where it says to designate the patch as "[PATCH net]" (it also says to add a Fixes tag as Ahmad already pointed out).