Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4539407rwl; Mon, 3 Apr 2023 06:29:58 -0700 (PDT) X-Google-Smtp-Source: AKy350Y7Xc1tmb/e4mK365j1Bz2lol+otpITCaApn5uZ/GlzBFnUfVpiH3Imn4XfgKTFV41UUuLb X-Received: by 2002:aa7:d806:0:b0:4fc:c644:6149 with SMTP id v6-20020aa7d806000000b004fcc6446149mr34462831edq.0.1680528597938; Mon, 03 Apr 2023 06:29:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680528597; cv=none; d=google.com; s=arc-20160816; b=IsrwbatxpDzSk4IP0bqvmnFF0x1H6j0pBKA8DoBux8GLTZ7swuksO3vzzIew2x9uxe ni4wdKlyZOFsWTH7igKt2Z0dMzu1Pd/ZWWfit4PykyEmZj7QJhs8ex555Bu/m8OeYz75 i48i69r3O/fAOqsAIK2sdZhlkiix9kZ+9yWXwcctXdl5P58mGcruK0Y9GdryhbTf/IGA Af6Nzfo4Iy9JIU3adomRzdtI3A7NfoE3zVUZyHq9vNCyE+ayo84G3Rc5J/O/fTDPfRbk iHKuD+vgnFaWo/JUcrPrF9nKEsFfTzcFGEdtApaOyJxjNWDtmDm5dHiayDyJUc4Q+6Kt aRkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=NTBu3T1hJbXzcrjoGIJunNPzVFd+efBZWIx71bT93xk=; b=pVc97N/dAHyXDiQdVXt9D/EB0dCTtq9GaewwEveN8i73zKeJWHHmlBpGnvtw2LfmgS BeARLrauuO8xdVfVPLBzctHhZ8TRhaOrMYlTt8HQQZ26e3kuuLc5rc1H/QWvHyeDJxxX VCH59EwgbJbg5b52cKk7WdbRgDiqh5z/j456N119+nAFda3i8avQAEufcsDun6sAqUMa eJgSb9gnhqDGhsnq2z+0qy+K+AZ+YbzUtqhZjZrwqcwPSQq81BHE/qJtZ3kJ7w/tZdLe RVAYfaYVaq3C+s0RzsJuBpMe7QV+YjzAhVsqWKwzK0kaaht+tP2NolXISrk7+7/ic59P ZvUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="wQ0g8/V8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qh8-20020a170906eca800b009345ceac84asi3606742ejb.362.2023.04.03.06.29.30; Mon, 03 Apr 2023 06:29:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="wQ0g8/V8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232572AbjDCN2j (ORCPT + 99 others); Mon, 3 Apr 2023 09:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232442AbjDCN2h (ORCPT ); Mon, 3 Apr 2023 09:28:37 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 089BD46AB for ; Mon, 3 Apr 2023 06:28:35 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id a44so11692241ljr.10 for ; Mon, 03 Apr 2023 06:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680528513; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NTBu3T1hJbXzcrjoGIJunNPzVFd+efBZWIx71bT93xk=; b=wQ0g8/V8tDhuICVtLAptLwNJswGIpGOW6dhlyRB3fdbSiFnwK8HpSJuArQuskuSsfH LvY7E6Ne5GR+Tjqmbt23wr9RqB5q4kgeXKguw8SwA+MFnlEgbEzOjvtCQVYj5aoaVqNO lwpevotRMsU9eRkylFiVH+0Jn4LkvPT4JggfOHZoJc/bbYcBXQnI6hfEOaXSbLPH+vsn IixYvcaQ/cVHgIdFDtJAy9wCq8pN/U1lNJSPdihtHJSLckoI0LDZzRHFAh2lrBQY1IZp CD4pjmRNTeaEnaUX/NI4xmOtBZbDGaxJV6cFMel0u9oeknXft25TIYWkNmCqYMIoQhyn HCCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680528513; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NTBu3T1hJbXzcrjoGIJunNPzVFd+efBZWIx71bT93xk=; b=ddYdHzzjBVUGHzL9mJnBHb6zybCUNHb0Wb9/jZFUYS1EsLQd+qfLey9hBW2jtMVNgv D9DmHYV7vSEUvIxiLrXeapdcqNLlj0JkfNstoHdzbOvBVV01JnBgX+qjXCLZrcGwutY4 +6oZQ38X93ZqX0miTLsCMvakMDH3FrEKFEZuj1wHE3CWzLzCtb7wEXVggYBYal5nUbTg Ud8giHwL9xDStQ0nitb5o8lpRGN9G9hXIyoc9ENNErWGnI5UxH+PqGaRyoyTnS23uS6r xJVVCXuLIJ5+3Hdce4d8u9jh4ssajx/q6zvqdVfRPt2pyDhU63B6e3DHzEg3ibKezUo6 n3tA== X-Gm-Message-State: AAQBX9egsVGmxoXxVNsw0fk9OOCmAFYp9RpmOoEwem9RS0WUodZXWOOv ZRPggr6wLv1+2mqBsPw/Ax246w== X-Received: by 2002:a2e:b0c4:0:b0:288:7a51:3882 with SMTP id g4-20020a2eb0c4000000b002887a513882mr10477487ljl.10.1680528513306; Mon, 03 Apr 2023 06:28:33 -0700 (PDT) Received: from [192.168.1.101] (abxj135.neoplus.adsl.tpnet.pl. [83.9.3.135]) by smtp.gmail.com with ESMTPSA id t15-20020a2e9c4f000000b0029ab1f2b196sm373133ljj.24.2023.04.03.06.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 06:28:32 -0700 (PDT) Message-ID: <1db568b2-4f1d-736a-1987-6c2b8359a26d@linaro.org> Date: Mon, 3 Apr 2023 15:28:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: correct Soundwire wakeup interrupt name Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230403132328.61414-1-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20230403132328.61414-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3.04.2023 15:23, Krzysztof Kozlowski wrote: > The bindings expect second Soundwire interrupt to be "wakeup" (Linux > driver takes by index): Seems to be a common occurence with drivers that were written a long time ago but have been updated for new hw since.. Perhaps something like of_irq_get_by_name_idx(..., "name", idx_if_not_found) could be useful.. > > sc8280xp-crd.dtb: soundwire-controller@3330000: interrupt-names:1: 'wakeup' was expected > > Fixes: c18773d162a6 ("arm64: dts: qcom: sc8280xp: add SoundWire and LPASS") > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index af7bee14fa06..cd38320dafda 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -2606,7 +2606,7 @@ swr2: soundwire-controller@3330000 { > reg = <0 0x03330000 0 0x2000>; > interrupts-extended = <&intc GIC_SPI 959 IRQ_TYPE_LEVEL_HIGH>, > <&intc GIC_SPI 520 IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "core", "wake"; > + interrupt-names = "core", "wakeup"; > > clocks = <&txmacro>; > clock-names = "iface";