Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 17:02:47 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Sean Anderson <sean.anderson@seco.com>
Cc:     Li Yang <leoyang.li@nxp.com>, linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org,
        Scott Wood <oss@buserror.net>,
        Camelia Groza <camelia.groza@nxp.com>,
        linux-kernel@vger.kernel.org, Roy Pledge <roy.pledge@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when
 taking cgr_lock
Message-ID: <20230403140247.ugb23hqrha2kjup2@skbuf>
References: <20230331151413.1684105-1-sean.anderson@seco.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230331151413.1684105-1-sean.anderson@seco.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BiRhz0exS8Hb6hX9pLvzDrXifDfi61ovIO8JY+nyHrFCtiOVY/nPFvB5w2m5?=
 =?us-ascii?Q?Ql7AblGTArxqKQtxhtpsvRsOIPeXQJpXhrRUunHpeFKJAhNPHIEAAMunW+qz?=
 =?us-ascii?Q?1gbTyOH47kBY/QUNLdNl3I3xqpg/tUcI3Jve+VZA2qPnBUV+xZMeLzmYp6ak?=
 =?us-ascii?Q?zyEBMzf2oMhJs2W+WNtt/HJcSFuP5re5mmTJ9IhZwlALfw87B++uol0BVhyc?=
 =?us-ascii?Q?TS1I5mpSBCuBTEpmPmkvYZi4C7MILe43tOT11sNwDJmEEng9K2q3G8tm2Gug?=
 =?us-ascii?Q?EjzZl+u9Tvzdl5gFS7/SqnX8nZBUHWGcG9swj3/gJJa3YE7LHxRCZnzfSDpv?=
 =?us-ascii?Q?RC4pwwDpX+w7yyI23ta7MAH0COIuHFFaoUnn78k840uGr4gReSTOxPw8r9gn?=
 =?us-ascii?Q?PCJS8H/pbBGhaIQztTUXDMkqlxmZrBNnyNisQbSO2zicJXQOdvukbVUNTF6a?=
 =?us-ascii?Q?JdfK0JBd0DsLaoH5pbAkbMZ2/0eTyhovReUvJ0uKOi0pVVfmr37HqXhikHp4?=
 =?us-ascii?Q?9TFnOpsX4ONonNdKYdtzp7w7HVbqI1yZBrpHaYcV3CjgN8bA4CXkGFMSBxjw?=
 =?us-ascii?Q?Kjm/W8zXWwm9UAzC685U00qbRD4mDapoujeAuMFctW9YwNnfirRWJSzkyB1a?=
 =?us-ascii?Q?FuMHqCz/y9n6NNR8fYoqiLEuCz44sImUcALz+knBnjjw65hLy/Xv47L9hqU9?=
 =?us-ascii?Q?e9szbQj4Rgzsy+rO9ANHqEoeU0xikRpm75sbsFRJxctyqTw7vGpkkLe/xHnF?=
 =?us-ascii?Q?mHwDQ/9sFnDkFUd4jpwDhWLGs/hkWrfLfOzeAO16ZHQRubjlVmDD1Oy0dawh?=
 =?us-ascii?Q?RXxZ6uP3+0fUNScNQHatzcFHKKMu9ngPFiGLscjRUGQajxLphzsjpqEXZJs1?=
 =?us-ascii?Q?Yl4JTSf54p8FQSEdOHte+FZXZUICqOS61Ah+k+7EsYB4Q9Ukp2tpZX6tBeA0?=
 =?us-ascii?Q?TrjAqUWffPzCWBNxCg0OFUSKYCNAL6ot1Ol3Gj6xBrc5P7SiEuAGjtciRmHn?=
 =?us-ascii?Q?IjRWi978++orG5vGWL/rPujElepw6gOD7XTvabELOEXAjdtsxNDzYZokrpfJ?=
 =?us-ascii?Q?o7G42pzla8wkw9yz32YEMM6mlmSFYwVrwYj18dVcB5rhwc+GoMfE9EtxWdkc?=
 =?us-ascii?Q?rkbUiMtjZS5+/HVysOIsXpYhzGrKN+WWzrG2UQO/GGArzAhvXZdJ2uceYRJO?=
 =?us-ascii?Q?MlDV0WkgiMndBAD2X/nqhskbu4aFNjqDjLVbfAZwEtlePkOutfWtqs10GOwk?=
 =?us-ascii?Q?EUcsEpvHethCDaz39YqczjRjhzLuv0ziTlq4CoeDCAX5RgpCFm27RLDCMJfT?=
 =?us-ascii?Q?dEkFTOtNfM84rcfW1A2t0hWXHR1fEDD5mFIreGTEDnXlWmdyCeBP1hyjtETY?=
 =?us-ascii?Q?mA/qviyg8clIbhRB6DrGuqRdnHkICwOmSb3MLkM3GLd8gDUmKMl1+ywv0iYI?=
 =?us-ascii?Q?fW1ySDCbaeEOoYbm9KWWIBROPX7CoyX+hc31vX2BbQtjT70Rj8fyMnUG3uSQ?=
 =?us-ascii?Q?xAXYfzp3q3VvmVvMw+nh3gght+38Gt5Zysb3KDe/fE4dM+ATAPdUACzGoXUl?=
 =?us-ascii?Q?NOmXZTG2+7ZRQxjh7WdI6XzjiDC4vtFus4u+UT4BibZpa5fSrxVhJgRd707p?=
 =?us-ascii?Q?Pw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6f92b4d-0238-47c8-9541-08db344c1cae
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:02:50.8326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dnuql5pQVrnlKVy3h6EK43VEsg8iaaxC5/9hwF0ENRCqw/26cyckfe1Ji0mEI07MYTx1s/SS5rlnAcc6Jt5UxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7390
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 31, 2023 at 11:14:12AM -0400, Sean Anderson wrote:
> smp_call_function_single disables IRQs when executing the callback. To
> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere.
> This is already done by qman_update_cgr and qman_delete_cgr; fix the
> other lockers.
> 
> Fixes: c535e923bb97 ("soc/fsl: Introduce DPAA 1.x QMan device driver")

If you've identified smp_call_function_single() as the problem, then the
true issue seems to lie in commit 96f413f47677 ("soc/fsl/qbman: fix
issue in qman_delete_cgr_safe()") and not in the initial commit, no?

Anyway,

Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>