Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <219812f6-0e36-dfb5-01f3-0733f911f198@gmail.com>
Date:   Mon, 3 Apr 2023 23:04:47 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v1 03/14] extcon: Use DECLARE_BITMAP() to declare bit
 arrays
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Bumwoo Lee <bw365.lee@samsung.com>,
        linux-kernel@vger.kernel.org
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com>
 <20230322144005.40368-4-andriy.shevchenko@linux.intel.com>
From:   Chanwoo Choi <cwchoi00@gmail.com>
In-Reply-To: <20230322144005.40368-4-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23. 3. 22. 23:39, Andy Shevchenko wrote:
> Bit arrays has a specific type helper for the declaration.
> Use it instead of homegronw equivalent.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/extcon/extcon.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 79006ab5334b..70e9755ba2bc 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -230,10 +230,10 @@ struct extcon_cable {
>  	union extcon_property_value jack_propval[EXTCON_PROP_JACK_CNT];
>  	union extcon_property_value disp_propval[EXTCON_PROP_DISP_CNT];
>  
> -	unsigned long usb_bits[BITS_TO_LONGS(EXTCON_PROP_USB_CNT)];
> -	unsigned long chg_bits[BITS_TO_LONGS(EXTCON_PROP_CHG_CNT)];
> -	unsigned long jack_bits[BITS_TO_LONGS(EXTCON_PROP_JACK_CNT)];
> -	unsigned long disp_bits[BITS_TO_LONGS(EXTCON_PROP_DISP_CNT)];
> +	DECLARE_BITMAP(usb_bits, EXTCON_PROP_USB_CNT);
> +	DECLARE_BITMAP(chg_bits, EXTCON_PROP_CHG_CNT);
> +	DECLARE_BITMAP(jack_bits, EXTCON_PROP_JACK_CNT);
> +	DECLARE_BITMAP(disp_bits, EXTCON_PROP_DISP_CNT);
>  };
>  
>  static struct class *extcon_class;

Applied it.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi