Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0f43fa98-4fe6-bc9c-ed8d-be7cec0dda42@collabora.com>
Date:   Mon, 3 Apr 2023 16:04:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: Aw: Re: [RFC] arm64: dts: use size of reserved partition for bl2
Content-Language: en-US
To:     Frank Wunderlich <frank-w@public-files.de>
Cc:     Frank Wunderlich <linux@fw-web.de>,
        linux-mediatek@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20230403105818.29624-1-linux@fw-web.de>
 <601a8435-8e2a-2c25-5fe3-40be62269469@collabora.com>
 <trinity-f48dda5c-6787-4732-978a-a409bbb0a74d-1680530175673@3c-app-gmx-bap35>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <trinity-f48dda5c-6787-4732-978a-a409bbb0a74d-1680530175673@3c-app-gmx-bap35>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 03/04/23 15:56, Frank Wunderlich ha scritto:
>> Gesendet: Montag, 03. April 2023 um 14:43 Uhr
>> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
>> Il 03/04/23 12:58, Frank Wunderlich ha scritto:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> To store uncompressed bl2 more space is required than partition is
>>> actually defined.
>>>
>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>>
>> If this doesn't get changed anymore, I'm fine with it... but a question arises:
>> did you send patches to add your BPI-r3 board(s) to upstream u-boot?
> 
> currently i use the rfb dts for r3 in uboot: arch/arm/dts/mt7986a-sd-rfb.dts
> 
> this file in upstream uboot has no partitions defined
> 
> https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/mt7986a-sd-rfb.dts#L144
> 
> but i added them there too and i wrote content by offsets to main device (not to partitions).
> 
> https://github.com/frank-w/u-boot/blob/2023-04-bpi/arch/arm/dts/mt7986a-sd-rfb.dts#L154
> 
> so yes basicly it needs to be send there too, maybe as additional dts.
> 

I strongly encourage you to send this change to u-boot as well as changing the
kernel devicetree... and when you do, you can add a reference to the list and/or
commit @ u-boot on the commit that you'll send here for the kernel... but there's
another question...

...what happens if you run the kernel on a device with an older partition layout?
Does anything break?
I don't think that anything does, since this is read-only anyway, but just to be
sure... :-)

Besides, you have to fix the commit description, but you knew that already.

P.S.: When you post a RFC, giving it the right commit title helps sometimes! :-P

Regards,
Angelo