Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 07:47:58 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, llvm@lists.linux.dev,
        linux-kernel@vger.kernel.org, Fangrui Song <maskray@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>
Subject: Re: [PATCH] kbuild: clang: do not use CROSS_COMPILE for target triple
Message-ID: <20230403144758.GA3460665@dev-arch.thelio-3990X>
References: <20230401170117.1580840-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230401170117.1580840-1-masahiroy@kernel.org>
Precedence: bulk

On Sun, Apr 02, 2023 at 02:01:17AM +0900, Masahiro Yamada wrote:
> The target triple is overridden by the user-supplied CROSS_COMPILE,
> but I do not see a good reason to support it. Users can use a new
> architecture without adding CLANG_TARGET_FLAGS_*, but that would be
> a rare case.
> 
> Use the hard-coded and deterministic target triple all the time.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

I know of one bug where the value of '--target' matters:

https://github.com/ClangBuiltLinux/linux/issues/1244

This was fixed in LLVM 12.0.0. We are not testing this in our CI though,
so we would not get bit by this (we could bump the minimum supported
version of LLVM to 12.0.0 for this, we have talked recently about doing
it for other reasons).

I guess I cannot really think of a good reason not to do this aside from
that; the target triple should only affect code generation, rather than
tool selection (i.e., this does not take away the ability to use a
custom set of binutils with clang).

However, Nick is currently OOO and I would like his opinion voiced
before we commit to this. Consider this a tentative:

Acked-by: Nathan Chancellor <nathan@kernel.org>

> ---
> 
>  scripts/Makefile.clang | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/Makefile.clang b/scripts/Makefile.clang
> index 70b354fa1cb4..9076cc939e87 100644
> --- a/scripts/Makefile.clang
> +++ b/scripts/Makefile.clang
> @@ -13,15 +13,11 @@ CLANG_TARGET_FLAGS_x86		:= x86_64-linux-gnu
>  CLANG_TARGET_FLAGS_um		:= $(CLANG_TARGET_FLAGS_$(SUBARCH))
>  CLANG_TARGET_FLAGS		:= $(CLANG_TARGET_FLAGS_$(SRCARCH))
>  
> -ifeq ($(CROSS_COMPILE),)
>  ifeq ($(CLANG_TARGET_FLAGS),)
> -$(error Specify CROSS_COMPILE or add '--target=' option to scripts/Makefile.clang)
> +$(error add '--target=' option to scripts/Makefile.clang)
>  else
>  CLANG_FLAGS	+= --target=$(CLANG_TARGET_FLAGS)
> -endif # CLANG_TARGET_FLAGS
> -else
> -CLANG_FLAGS	+= --target=$(notdir $(CROSS_COMPILE:%-=%))
> -endif # CROSS_COMPILE
> +endif
>  
>  ifeq ($(LLVM_IAS),0)
>  CLANG_FLAGS	+= -fno-integrated-as
> -- 
> 2.37.2
>