Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4701533rwl; Mon, 3 Apr 2023 08:28:51 -0700 (PDT) X-Google-Smtp-Source: AK7set8L1GLRI9LVX2KT8YzC4RijSOlgNph0vw0poyq3oJGDeNcKBq7ofc/70jisDO4Y0ZuL1HFZ X-Received: by 2002:a05:6a20:a621:b0:de:13c4:5529 with SMTP id bb33-20020a056a20a62100b000de13c45529mr28892648pzb.62.1680535731524; Mon, 03 Apr 2023 08:28:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680535731; cv=none; d=google.com; s=arc-20160816; b=XKosvDV1fOxvNz3qQOT1vtD9WAIu/9I+edJDFUZD4gbrVl5x+0ypiPpGfmg6+O2ioN dUH0pKZCBJiB/u08qIhuZh9UkLGh9sriBSEsUHlgDVbIEnxf5nFOM1a1/A+y931d+0Tm l0jiHLhDzLjytFR9ag6yWiScMSXvi1GufFCfXSGdlVqxt3uEU2g0EjA6fKDsTOIZYOQo e6kzwcVQAX/46q9nmjN0kRnO7n+uZTbmxATSQfWC8EPcGeK9Kdda/GfwR9Gs6lRRv27h aiPERQ+bGdyNYYE0LANEMAmVPKSDAOl6NlXEnpqzNA1N58dB5fxPQY8x6iTLZ2h3YzVA /Ayw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZoXFx8oNL/N+tUpgQ9R5nRcJHiW5eJ11y0V+QBJtJbE=; b=b4bk76lhAyH2PWdXRd1ot+g9MXlrBrc1LNGyvJR3suqLrXqRT/aOre9hr6D0zgOh3n 0CI7m4fzXnLW359vkty5RYc6GdK8wu/0iPgODbahDty4nAsZGoENRUA8on9RC+ZmLw8A 0a3ly+vVG5UBiTFEGhFRRCen/oAXw/nzx/Vi2MnSwguORIrdeWL5ZQb+A2QNMxsvOfig c76b5rfnM2TO0OnIi/SXgZJBAfjwdXzFXw/QPWX2HvXlRJhJnMAWs7GC4XwTJo06qOxT MyYwid7YHnW8xLd+vB1Z1cv8U+fTY1XRH7//govziWK9vDguxKg9OaHFL385sAQU+xCN +58g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="JtMGl/T1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a63d944000000b00502fdd175f3si8457057pgj.148.2023.04.03.08.28.38; Mon, 03 Apr 2023 08:28:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="JtMGl/T1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231822AbjDCPKn (ORCPT + 99 others); Mon, 3 Apr 2023 11:10:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbjDCPKl (ORCPT ); Mon, 3 Apr 2023 11:10:41 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEAF6197; Mon, 3 Apr 2023 08:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZoXFx8oNL/N+tUpgQ9R5nRcJHiW5eJ11y0V+QBJtJbE=; b=JtMGl/T1h3Tk0EB9kqoDklN/1D vjpkewGSjYKCtkYwxAWFfCJqGdz2D4VE+0UDW8kLyvNHtkKi80O74EHK9KRsfQC0kTPlqp3Of78Wi oaDoWR0W6adOx2tA/Gyov+yKLgKsd+zHQ4uomWio0xAnlGrvOR3VeRugIZDiTveSJ8COwJLn1jV2u 9WM0+/+wnsmTAkUhMC+Vi/2ifOoYmc0d459vRfx5KPv2me5HB9xovqCbHkGwFsJNdh98ZLeWgH11R Qteon8LpKeuBCIAbWEeQt+SkgNcmhwlguFM/qRQ28kclUvSnvjP9lMjBC8RUrcwWbg3JDI1Vj51ys Ol+vdD9g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pjLpO-00FkAA-1h; Mon, 03 Apr 2023 15:10:38 +0000 Date: Mon, 3 Apr 2023 08:10:38 -0700 From: Christoph Hellwig To: Kent Overstreet Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, willy@infradead.org, axboe@kernel.dk Subject: Re: [PATCH 0/2] bio iter improvements Message-ID: References: <20230327174402.1655365-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 28, 2023 at 04:28:08PM -0400, Kent Overstreet wrote: > > Can you post a code size comparism for the before and after cases? > > 6.2: > kent@moria:~/linux$ size ktest-out/kernel_build.x86_64/vmlinux > text data bss dec hex filename > 13234215 5355074 872448 19461737 128f669 ktest-out/kernel_build.x86_64/vmlinux > > With patches: > kent@moria:~/linux$ size ktest-out/kernel_build.x86_64/vmlinux > text data bss dec hex filename > 13234215 5355578 872448 19462241 128f861 ktest-out/kernel_build.x86_64/vmlinux So we have a slightly larger binary size, and a slighly larger source code size. What is the overall benefit of this conversion?