Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.83 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.83; helo=inpost-eu.tmcas.trendmicro.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=seco.com;
Message-ID: <7bd6967a-7f0b-575f-d972-3bf98fab5a6a@seco.com>
Date:   Mon, 3 Apr 2023 11:22:12 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when
 taking cgr_lock
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     Li Yang <leoyang.li@nxp.com>, linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org,
        Scott Wood <oss@buserror.net>,
        Camelia Groza <camelia.groza@nxp.com>,
        linux-kernel@vger.kernel.org, Roy Pledge <roy.pledge@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
References: <20230331151413.1684105-1-sean.anderson@seco.com>
 <20230403140247.ugb23hqrha2kjup2@skbuf>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20230403140247.ugb23hqrha2kjup2@skbuf>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original: XPYT4TfaU/Ef1ueXnkAhcCzxmvy0xDSQmwPGybmbpw+IIhL02350eQ5SXb4KLhzxtPBCMywFjSZQSAMxInlycI2QViufeUZ7ssz7NxIwBghpeRnQxaqu6Ic5cuxgYTmgIFGoYNc1kreT0m0vwQivKNJIU88aSDZOXukA+z0HoSivf8gOulR6zguzy+TpH5KaI9dyUgcomDLB0bhMnETAK+y4F1Cj3cCldKScV89D2ZKao64M+EJ/CsQvBAJIyCZeo/jxen9Yrsb4z9eVq5LvWPzx1p9eFJ5qilCLewlSbtpVpB1voFheGsNRQIAdbW3Nwmw64+VTvglvInMqd8YOiaBGghoVRsUdgjnx26Miwvxmo3pFDzlgSICFWOnKZcC+ZSzt+HOd9kgCdmCkXTXswoIjKo1IhPgmiRfmlASnxw5PMm/RbbnHo+SJ73g/uZ0jXtZGjyv6O2ae7iKm2syjW0YwCx7IvXJJnJw61zAL4E0aFF6RlZLqD8C3MOvlv5wAxFhTKqFxjAlzF5UAEn1ZDMSrgVH98DTaIlmQTGHdqU5lxHPDNjChGI6Gq36ogzYiRQEyHSKhsoPWofFKv4u3jqXeE0mmnB74ugrRR//l1FR2NPVqBBYWfEs//Tqn68IgYf91Ek7zrqGJs4Vn+Zt38rgyuv4CcOCOXOkIbnAW+08IWRgGUt8QfFpNeMfuxJaL
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39850400004)(366004)(346002)(376002)(396003)(451199021)(7416002)(186003)(53546011)(6512007)(6506007)(26005)(44832011)(4744005)(6666004)(31686004)(54906003)(478600001)(38100700002)(52116002)(38350700002)(36756003)(66556008)(86362001)(66946007)(66476007)(83380400001)(6916009)(8676002)(4326008)(316002)(31696002)(2906002)(41300700001)(5660300002)(6486002)(8936002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR03MB9641
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM6EUR05FT040.eop-eur05.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 58f333cc-2101-4ed2-6f37-08db345735d6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: s6mkr6et1WZeuGy8PfBFyGPbRrzxSvgEF1Nh8tj1BQsuwv/YplKecCMR7AL/yeCRnU4aN75LZHli90V1RTTtT4Dnn2gnyZWVMBPJmjtBbNseHJSNwxQDabox9hdzADSWd+0R9lNyAjJCe5IZUMSh2gHkUwREMRIL/YPD8+pjOOSv2MYkRrWzhDOEzAZ+Mq1z60IyFWi1OkPmyPNZzcvsuq/k9ha2/78LLGXj3Agj0UsLUY6Dx43EbM94njXR9UyPLDft99oYysstkpDZXojWXVaM1u77cE5VFcLbmBkZOimLAOFaNivYf2YRMNV4FVkX/9Xzf0uetSDacpRyRx/LzycQFWLt7Se4oZfWc1Ov5B0gEgAzlMMoFc/AqYiqQFaVYiomLHIrLfa0vF5QdSLJORm4DoT5RjpQdp2RI5umudA+bmf8PFq8SZ4Sl6PQ4SdYXC7ZYOa+h4qpgTqXDZntHaKEsXSOE9fwkOA670WoabdesvQ7THJ1PsJLdwEAKLYMvozDSly94KWBahc+TkcArqzTDvK+0E8Eya062EI0VrAgXgYz5wCk+0Wn+P54dzPPiM+Nt2fqEE1SZaHnTjXk7Lghr/9oHxeOkBvhSiRN7SHsigGMuMbzYq17nyXj8vFcdG0UwCrr6G3Xr9upcTvTOWRAPGe0tClFnWrkBLLj2tbYBcYk/9tJBspPwGifzsOGNncva3TO8mAcL9+BqcLNerul8Vm4gyl62+kTpzAWp3xv8I4q3VKh4NnKrN3ArDpnc+P+BaMMt+nDfIbx72tx8Q==
X-Forefront-Antispam-Report: CIP:20.160.56.83;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:inpost-eu.tmcas.trendmicro.com;PTR:inpost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230028)(346002)(136003)(396003)(376002)(39850400004)(451199021)(36840700001)(46966006)(40470700004)(6916009)(4326008)(41300700001)(40460700003)(356005)(82740400003)(7596003)(7636003)(36860700001)(82310400005)(86362001)(83380400001)(53546011)(47076005)(336012)(2616005)(186003)(6512007)(6506007)(26005)(34020700004)(5660300002)(54906003)(316002)(478600001)(44832011)(8676002)(7416002)(8936002)(70586007)(70206006)(2906002)(6666004)(6486002)(4744005)(40480700001)(31686004)(36756003)(31696002)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:22:23.9036
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b8031a8c-b35b-4ac8-abce-08db345739cb
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.83];Helo=[inpost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource: AM6EUR05FT040.eop-eur05.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB8368
X-Spam-Status: No, score=-1.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/3/23 10:02, Vladimir Oltean wrote:
> On Fri, Mar 31, 2023 at 11:14:12AM -0400, Sean Anderson wrote:
>> smp_call_function_single disables IRQs when executing the callback. To
>> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere.
>> This is already done by qman_update_cgr and qman_delete_cgr; fix the
>> other lockers.
>> 
>> Fixes: c535e923bb97 ("soc/fsl: Introduce DPAA 1.x QMan device driver")
> 
> If you've identified smp_call_function_single() as the problem, then the
> true issue seems to lie in commit 96f413f47677 ("soc/fsl/qbman: fix
> issue in qman_delete_cgr_safe()") and not in the initial commit, no?

Yes, that seems better. I did a blame and saw that qman_delete_cgr_safe
had been around since the initial driver, but I didn't realize it worked
in a different way back then.

--Sean

> Anyway,
> 
> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>