Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 16:27:32 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Asahi Lina <lina@asahilina.net>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Sven Van Asbroeck <thesven73@gmail.com>,
        Fox Chen <foxhlchen@gmail.com>,
        Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        asahi@lists.linux.dev
Subject: Re: [PATCH v3 2/6] rust: error: Add Error::to_ptr()
Message-ID: <20230403162732.4509df69.gary@garyguo.net>
In-Reply-To: <20230224-rust-error-v3-2-03779bddc02b@asahilina.net>
References: <20230224-rust-error-v3-0-03779bddc02b@asahilina.net>
        <20230224-rust-error-v3-2-03779bddc02b@asahilina.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IrJLASMOXe8qCHkHqSaGpB4qjAGq76tWZA/s/2Sd/inoFs5AAvj85/GnR8JC?=
 =?us-ascii?Q?W5MfPUfRaPaHzD3jbxwA4+egX+dUIr/tXtNtKKTNdsqzIajA/9g5SgkrcOYX?=
 =?us-ascii?Q?D7Gu4u0iuXcR3ipe39vx62QTeD60vwHfMO344gIu6l8pDyuXLqD155ZVjluP?=
 =?us-ascii?Q?cDx9YzqQ14fmqvr9wK2K7m64odSaMqdYSvMu0VtDrOQa/erHARx7dlsWFfn8?=
 =?us-ascii?Q?002uxeJATq23sRykkK5A4uFBTyyVn69OgUIdstAI8oAz69xo7D93979kMvVe?=
 =?us-ascii?Q?G6i+4uFwvqd1ZntFaKQu7XiQjz3AyHk/NZHvToI194nstt9kLSLtT/2i7Qgl?=
 =?us-ascii?Q?P8FjCSElQ7RkCu+JQkgooBRvAjRlmXB/9vnmfnXaACcEtdMIwy3UBMlZNoMj?=
 =?us-ascii?Q?cK/v7NptI0GCD7Ftz82vUEv7J016kGBjJGXlL4oBMTGFkDA7nu17nP5Cz04v?=
 =?us-ascii?Q?qdAvxdSPH7Q/dAigcV/Af+djVSrL9xM/9LYUrIhpa6x9QZ1L6wo4zINBaFha?=
 =?us-ascii?Q?jJ8AI7RabLxpw9BRo0aif3ZsgGkAURJF7e0+4YVzc5mkQh1UuKMf3rLbY1np?=
 =?us-ascii?Q?kdJ8LJRkP9kvEsqoub12BgEibqZ7HHXoS5RMS3NLFLFLxYG493ZLxYr7D42h?=
 =?us-ascii?Q?UP9X68RePMktGnlcFStVm2wlhUC1bWO5BVhfhfEkwtcRX3vjcGTSN+JQUlvB?=
 =?us-ascii?Q?ouWyDvQyLoK6p7mEPYXIfR9BahTVvm03iFTvVHvf2+8roqpA0bHvGDQowa6Q?=
 =?us-ascii?Q?tuqZvZhz9tGIxOHa7YZx01NArYRWyZT1XnujNTJxejIfFcPJgTJI4SD1csbC?=
 =?us-ascii?Q?mlM51w3UdF8FDz9vpdIcsNoHMoqBkSK7zXHNVvc4EIw1beK2w7WY4HAgplh+?=
 =?us-ascii?Q?jsmid03/Rn0weIfVxEwTEPmhjcvBLUarM1a6QVqYXoFwrXRGj1FMAyMAZE3e?=
 =?us-ascii?Q?ZJ0rp+oIutTmlooARUDE0CnVMD6CndzgXsv24tDi7ofCiY/PmfAo1Cgvwbyt?=
 =?us-ascii?Q?Q3lB/Nu0ptaaJY8tbBKmxlO3eVvUS9mZ4N6W9EXo9ZXwbUQ2nKoxiYh2ruaR?=
 =?us-ascii?Q?alieNFA4ndQo2lNhTDnKbRb/1uMPsVrFwL9+0rPZthMhIZQ1Kjc7sXwrIZPQ?=
 =?us-ascii?Q?P9CpIU3calbPL9tiwvyNECbq1IMkvnrU5VS/V7xq6ropHhr+iK9f8fzt3N5N?=
 =?us-ascii?Q?x3mYUD9iG7WqYgvq8Gt+M9C69pQ1//ugfAQTW676XuY82SGuMlIbs8zgXyhg?=
 =?us-ascii?Q?D7M2tZDxR+Cc/p1tN9qsnGUPQ8zWTKeqAgukiC5jUZLYJq+GQzkGE8bNPAiv?=
 =?us-ascii?Q?+aujGnqltlAiber8OqAmbbuX4kMLaRTadLOeb6bhEqTs9B/Wd9NMss/pgWKt?=
 =?us-ascii?Q?o0GL1Hd0GH/kfFNJ+DxAz6H5DZ0Gb1+HEX0HoDh30EArRjx9kbpRy2afov2f?=
 =?us-ascii?Q?neaFXsPWHOx0toM1N8XgPL8Kodd+ryfJYunTecZCBQV4KiGBQaMf/+iZQCcV?=
 =?us-ascii?Q?4CNS/1TAP8J3q3m0wngKYaYNkGTz9z0AyaBTmEM7DOAD9eHm3m1Xp1U/uDkL?=
 =?us-ascii?Q?PokWrM23GL0PhcBQmNNPkfPvv5PicgVyAi2BUMlD?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: c9e0f6ba-9927-49e9-81a0-08db3457f297
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:27:34.0997
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0jsTi5laJW4ljUnFUgpbMrDqH2FlQ99uhdnq+sMWOydWhT/5n+QdGJXF321N7gKTQA2oEeTSUCx9UmikRiJa+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB1988
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 03 Apr 2023 18:48:11 +0900
Asahi Lina <lina@asahilina.net> wrote:

> This is the Rust equivalent to ERR_PTR(), for use in C callbacks.
> Marked as #[allow(dead_code)] for now, since it does not have any
> consumers yet.
> 
> Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
> Signed-off-by: Asahi Lina <lina@asahilina.net>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/helpers.c       | 7 +++++++
>  rust/kernel/error.rs | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/rust/helpers.c b/rust/helpers.c
> index 09a4d93f9d62..89f4cd1e0df3 100644
> --- a/rust/helpers.c
> +++ b/rust/helpers.c
> @@ -20,6 +20,7 @@
>  
>  #include <linux/bug.h>
>  #include <linux/build_bug.h>
> +#include <linux/err.h>
>  #include <linux/refcount.h>
>  
>  __noreturn void rust_helper_BUG(void)
> @@ -46,6 +47,12 @@ bool rust_helper_refcount_dec_and_test(refcount_t *r)
>  }
>  EXPORT_SYMBOL_GPL(rust_helper_refcount_dec_and_test);
>  
> +__force void *rust_helper_ERR_PTR(long err)
> +{
> +	return ERR_PTR(err);
> +}
> +EXPORT_SYMBOL_GPL(rust_helper_ERR_PTR);
> +
>  /*
>   * We use `bindgen`'s `--size_t-is-usize` option to bind the C `size_t` type
>   * as the Rust `usize` type, so we can use it in contexts where Rust
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 35894fa35efe..154d0ca6e2dc 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -76,6 +76,13 @@ impl Error {
>      pub fn to_errno(self) -> core::ffi::c_int {
>          self.0
>      }
> +
> +    /// Returns the error encoded as a pointer.
> +    #[allow(dead_code)]
> +    pub(crate) fn to_ptr<T>(self) -> *mut T {
> +        // SAFETY: self.0 is a valid error due to its invariant.
> +        unsafe { bindings::ERR_PTR(self.0.into()) as *mut _ }
> +    }
>  }
>  
>  impl From<AllocError> for Error {
>