Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 18:17:37 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Nipun Gupta <nipun.gupta@amd.com>
Cc:     linux-kernel@vger.kernel.org, nikhil.agarwal@amd.com, git@amd.com,
        michal.simek@amd.com, pieter.jansen-van-vuuren@amd.com
Subject: Re: [PATCH] cdx: change struct bus_type for sysfs rescan callback as
 constant
Message-ID: <2023040325-dehydrate-pectin-92fe@gregkh>
References: <20230403140416.28183-1-nipun.gupta@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230403140416.28183-1-nipun.gupta@amd.com>
Precedence: bulk

On Mon, Apr 03, 2023 at 07:34:16PM +0530, Nipun Gupta wrote:
> As store prototype in struct bus_attribute has been updated
> to have bus_type as constant, change the CDX sysfs entries to
> follow the same.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> ---
> 
> The bus attributes are marked as constant in patch:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=75cff725d9566699a670a02b3cfd1c6e9e9ed53e
> 
>  drivers/cdx/cdx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c
> index 67c32cb2c006..38511fd36325 100644
> --- a/drivers/cdx/cdx.c
> +++ b/drivers/cdx/cdx.c
> @@ -363,7 +363,7 @@ static struct attribute *cdx_dev_attrs[] = {
>  };
>  ATTRIBUTE_GROUPS(cdx_dev);
>  
> -static ssize_t rescan_store(struct bus_type *bus,
> +static ssize_t rescan_store(const struct bus_type *bus,
>  			    const char *buf, size_t count)
>  {
>  	struct cdx_controller *cdx;
> -- 
> 2.17.1
> 

Thanks, I'll hold onto this for the -rc1 merge.

greg k-h