Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Hawkins, Nick" <nick.hawkins@hpe.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "Verdun, Jean-Marie" <verdun@hpe.com>,
        Wolfram Sang <wsa@kernel.org>, Joel Stanley <joel@jms.id.au>
CC:     Arnd Bergmann <arnd@arndb.de>,
        =?iso-8859-1?Q?Uwe_Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] i2c: gxp: fix build failure without CONFIG_I2C_SLAVE
Thread-Topic: [PATCH] i2c: gxp: fix build failure without CONFIG_I2C_SLAVE
Thread-Index: AQHZZgDs0hNfVR2yy0ujAn/FRZ2ciK8Z0wDA
Date:   Mon, 3 Apr 2023 17:17:58 +0000
Message-ID: <DM4PR84MB1927213E096523B6ADCB030C88929@DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM>
References: <20230403074939.3785593-1-arnd@kernel.org>
In-Reply-To: <20230403074939.3785593-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?x5GI+0pUE8Nx4ShSHsNNPngPR/O54Znpmg7HaUdWlMP1vhZbtukijWY+HA?=
 =?iso-8859-1?Q?RjhOeMRD3wpqZ9QDtwqAUcBw0sfO9f9aewFFh71UrR474L3hzGvt7gz3iI?=
 =?iso-8859-1?Q?d/AI6VoPXDpFZuxBu+xwa2pU1sB4zzqSNGMFEcAKJuVq+f/NFusWbCTA79?=
 =?iso-8859-1?Q?jvQzMaNEtLIMoYkSwpviD6w6Id0fHopZTw93x/kvfSdzWgNSLtcm2wneVt?=
 =?iso-8859-1?Q?ZhLWdkjmr7PZ8BUml75nXXC1wOX4kuyeOsZY7A7DtBu1MAwpCi+kGnXUii?=
 =?iso-8859-1?Q?XZpwfzNze8VO5EIqUmAwTWrwQqXf2KxDiufrsr765/SDrkXWwwbohtVyCz?=
 =?iso-8859-1?Q?lEKv3ilkj8aZ2V2MzVNOfYy8uC1zqY4HSFl6CU6CRq4XOveWI89eoOeOBW?=
 =?iso-8859-1?Q?BzsS/Nr61zeZS/IqdWPw9vbuwYst5x43ltASGbiNMePb71lJiDrRBdcwxq?=
 =?iso-8859-1?Q?so1iSq22yT1c6l9/Ggy0vLFs6IwODlRRf0GscL4J2C+nsFnlmGNTyR3mk4?=
 =?iso-8859-1?Q?4HdhftdiYmqQWJsw7LTaXC96SmQckhO9F0opiwC8E1bXpA/TU8dhcjoxfK?=
 =?iso-8859-1?Q?ZRfddBZG454oI/cEjSCcCp+bRWm3s6FhWqv8aJveIXNIqrpNrq3/zglxut?=
 =?iso-8859-1?Q?yx1jSZYpgvWZZ35RhNvSrjMtEHz2pnAkWh8L/ZQK7xCJmMZURAaEAD4CGJ?=
 =?iso-8859-1?Q?AcGlP+KmwGgIA6bxp5n09+qDpXFEZL9YLLJmXkXGNsvSR05MS2RYTMrCGg?=
 =?iso-8859-1?Q?EPiN7SC4TqzLUKqWoIvm/bZ1WtYFQWADudfoDlXVSkC4OsQLUoyL8p1Yeh?=
 =?iso-8859-1?Q?9a3xQY9tqZh9gvhpWP9tWwaUBdqyPA4CIrZ5b6vHtYA/R17jhqSS6+AYPq?=
 =?iso-8859-1?Q?e38PvUE09U2ikQr3TEQWXPmexwckleS61eYii2dUTgbaI7rPo3lQ4l11hM?=
 =?iso-8859-1?Q?IwGEKfn9vICdj8UkXnYhi3cfUda1VhaGMA1anIgoL+DhQ7d/CGJWHHVmTw?=
 =?iso-8859-1?Q?ZNJCYfRTgGWyuU3szGh4qYjQjz1bOVqA2zaZ686oVxk8y3ZIdDA2pMlMbL?=
 =?iso-8859-1?Q?MuucuLm7+XZSe6m9XPTQnBzocVUtHDqI3DiUnqnWXRsIrMULgVXlVG38o7?=
 =?iso-8859-1?Q?yAnoKHxUVS1xaKKK8x3S9Y4mAh6ddyJhLFU6WmUWVPBXO+NY1uBP7SHJXQ?=
 =?iso-8859-1?Q?vWk4mlKAKxNhC0eqxy0Wp3zrmnWeHN3gBQNFJ6bdjKEPhyD+KFMECfqVsn?=
 =?iso-8859-1?Q?Q4LxqOtDlw5S3iIRCB9Xm+E/rFZCSJEOqXlK2xUdqshPgzAVqREBVbvoC8?=
 =?iso-8859-1?Q?GwrBeS8svCdiLz/jOEVZsufNx6wAogbgMMmYXpLczHU2SS9ZKhVOIpnqzh?=
 =?iso-8859-1?Q?3I5usb46/+BuLd3HG59lvDWSJ8KoH42319x0fVWkctVdufLT3zAJQzqleI?=
 =?iso-8859-1?Q?5mj2yF1eMj8CudO89QrNHu8wYYvAGYO0KeGE1zo2LP22YzwgY650x4CtHM?=
 =?iso-8859-1?Q?5iA/K7lDKuXLklNv+siuF12JgrueADj1XmTseLTlF0wAxQ1frw2yvyM/oN?=
 =?iso-8859-1?Q?5MFqggdsyw1XMxsZ0sgZVp45N3VDXsf7CG8e6KdJBiI/UoI3mHNr8kdV2t?=
 =?iso-8859-1?Q?1dg9J6W5hXa+pNDLuKH7BwhhmXL/KoZ6m+?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 65dfff09-8bd3-4b02-1650-08db34675f68
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2023 17:17:58.9653
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: y6XOUFiez2mKMB4rCa1vM6Mlist7ixi90jXmAz4icklrUh2/JyUB3N8C+rurqSSNhbAb6F4hfTmVBJR1Wf6OfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB3293
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: qO25zI8WTJdziDDFMR9HXBLhOze3X6Kl
X-Proofpoint-GUID: qO25zI8WTJdziDDFMR9HXBLhOze3X6Kl
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-03_14,2023-04-03_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=301 bulkscore=0
 clxscore=1011 lowpriorityscore=0 suspectscore=0 impostorscore=0
 phishscore=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304030130
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> From: Arnd Bergmann <arnd@arndb.de>

> The gxp_i2c_slave_irq_handler() is hidden in an #ifdef, but the
> caller uses an IS_ENABLED() check:

> drivers/i2c/busses/i2c-gxp.c: In function 'gxp_i2c_irq_handler':
> drivers/i2c/busses/i2c-gxp.c:467:29: error: implicit declaration of funct=
ion 'gxp_i2c_slave_irq_handler'; did you mean 'gxp_i2c_irq_handler'? [-Werr=
or=3Dimplicit-function-declaration]

> It has to consistently use one method or the other to avoid warnings,
> so move to IS_ENABLED() here for readability and build coverage, and
> move the #ifdef in linux/i2c.h to allow building it as dead code.

> Fixes: 4a55ed6f89f5 ("i2c: Add GXP SoC I2C Controller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks for finding and correcting this!

Reviewed-by: Nick Hawkins <nick.hawkins@hpe.com>