Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8fe661ef-fa03-5ee9-de57-eec6a5bb7a28@amd.com>
Date:   Mon, 3 Apr 2023 13:24:01 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/mce_amd: Update SMCA bank error descriptions
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>, Avadhut Naik <avadnaik@amd.com>
References: <20230329192200.110813-1-avadnaik@amd.com>
 <20230331154412.GBZCb/zO/BGR3a/bVT@fat_crate.local>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20230331154412.GBZCb/zO/BGR3a/bVT@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWlUTnhSMWllcHVxTmhBTUZjYmZGSC9aaDgxdFFJaFN0VlJvdnc0MmhRM25U?=
 =?utf-8?B?U0cxMjZ5Z3hnUlZza25Jb3JsTFNGUHZpNFpGUmJ1SWxXSCs3R3lmL0ZtMWZ0?=
 =?utf-8?B?UjhYdXJEK1RkUDRBZGhkTEpUUDBubElqTVlBSHlEZEcwYytPL0YzcVJidDFn?=
 =?utf-8?B?Q043c3Fud2xyOUFUdTNadGxLQUZLZVZEY09YYS83U0psYlREUU1TOFRKdlZ3?=
 =?utf-8?B?V0thYVhGNGRxamp4eTgxMnZHMGRxcUg3M1JLWXYxV2FJSTVYNkxaL0k2UHg5?=
 =?utf-8?B?ZncvMG1aT2RvMnJhWXNRZkl5QUFSdTJzaGJwVVpHNzVkYzlqM0JJcWRzdHBY?=
 =?utf-8?B?SGRFcjRjOFh1UE1Pekhhc2dFenNQRVQ3NllHSzU1cFFHS2ZVMWdFd3ZXRDNQ?=
 =?utf-8?B?WnVNWEZiejJBN1E2dG95WXNCTWdtQmxJdHAyQTgwWWNFOFJhUG1ITTQxVjlQ?=
 =?utf-8?B?L3hKMkNESG83Z2Y1Y1Z1REFPcUdNc2pOMU5TSGZPUFdDZDJRYlRzdnRHMG9Z?=
 =?utf-8?B?ekVPSGZTWEUvVFNQMS81WXFHemtNWXBLWUxQblM0SUNweEpxa1AwbVBpWFdB?=
 =?utf-8?B?RzdVWkdjMXoydk1ncEtLejVjcFZnYnNrWW95QUxDUzVqRzFvVkwyNzRjR211?=
 =?utf-8?B?TGczNGszMjdiUWJvVVd4b1Z0YlJQQWxWbzNwQm11OHR5eG9jYndNR1Y3R1B6?=
 =?utf-8?B?eFBFaG1Ua0xleC9hczlVQldoaWdOMEh0QmxVeTgzd1JnUVZYSlIzS2gzNTVH?=
 =?utf-8?B?MkJlbXMzVW05aW53NGdYeEFWaFBhWHNNRldlRVkwYWFWMzhvZ1VTVkFVaVBU?=
 =?utf-8?B?a0RWMXZmT3owS1dTSXVnUVdONUR4cTE0K1lrY1pCUWhnVklxUHRRYWJHUDQy?=
 =?utf-8?B?d0FPU09zZUQzMC83MFpTaGFxaHVtdmZXT1ZrSzcwZ0trbmxsV2tDRWhaK2sr?=
 =?utf-8?B?Ny92V0pneDJKRjhZQk5vNG10Z1I2dm8xNHEvczdzbjF4b1dzTUlLZ25vNFk2?=
 =?utf-8?B?UWZpRWc1TzF0ZDB0UlFvMFI1MWd0MzBRRDR0Ukx4UEFFUHJDckhCNC9yL1V5?=
 =?utf-8?B?b2oxemV5OVFiZFk4TUtFbzdCU1VUUjdKODhSaVAyd0VPQXR3c0kxVUM3SzFG?=
 =?utf-8?B?TUFycVpHdjRnektTTjNrQjNCeWYwREdhbm56UE5MQmxxaHRKUkFGQmZTOXIv?=
 =?utf-8?B?UStvRUFwanVsOGlyZ1hPck1IdkhBRm91WlNuUm51T2lTVzFNMkFJMGh4S1pO?=
 =?utf-8?B?TUJuc2YxYzlNdTBNekgyb0NoKzRhTkh6bmVJSXNTNTNlU2QvTVdEc0hFZm9F?=
 =?utf-8?B?NkkzaXRuR0NhenZONHovZ05ON0tKWTgvb3dTUlZQRkhBSFRHbTJLeTMyc25J?=
 =?utf-8?B?ajFzVUg1SFVPL1ZvaklLaDVua1ZFV1BZRFNaU3lPMzc0RzcweWhjZlFGa0VG?=
 =?utf-8?B?SjJGODBYVTJnTE9RVzllbmpWNFBmU3U5VWwyTUNTTFgyZHZpa0N5MDFzVHc2?=
 =?utf-8?B?N2NUMllqcml4NTgveitweGRwSjVJa3AyeDdBcmxtR2pTVWV0VGladDhnOGR3?=
 =?utf-8?B?Z0lmdit4TFdxaTZjYTBvWGhRcU04MGtldnFRU0h2ZEZUZDFTOURyL1FxSHJi?=
 =?utf-8?B?aHh1eG9qMUtiUmJLOUMxRml6UzdJdHBNd1NWU2VYdmxCcXMyNXUvM3p2M01k?=
 =?utf-8?B?bnJESzNkMXNzdHg4aDJMK1FJKzlQVzFqVkhqcm9Yc2dORDJReTBWWFZtRXR3?=
 =?utf-8?B?MnJLdDhOVGN4dW91alo4UC9mTEJIbk02bDlmbW9BaVArMFZoS05MREVxSUdC?=
 =?utf-8?B?M2FJcERoa1NXSE1FdHF0SVFhTi9ySktwZzJLUEV5Wnpkd0szMGloVDFBaWJ0?=
 =?utf-8?B?S2tETG9vTGVtNmlMeSs5MlZZbW5GVEZPRjlXRVk1VEZwRHF0NDdaM1JqRGc3?=
 =?utf-8?B?Qkp3QS9lbzNGNzArV3FwWjVYMndHelA4bVNqTGdVUVZCYVZYYy85bXgvU0JF?=
 =?utf-8?B?dWdQeVdSL3dkYlN6NG1YaXUyYXFlbGh2QlY1RkxhbkJzREFDeEJwMmFKWndr?=
 =?utf-8?B?a2VOZkFHdXFYS3l1aEpkNEc5ODJpc0hseDZ1NlNaZGJrMi9jY0x0OTA5Qi9K?=
 =?utf-8?Q?FfmYxlLZFGtZ+T/k+Rh83i/aI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26327171-0a94-435c-867f-08db3468388a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 17:24:03.4426
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uTxMcZBJE74oTbE+5yCPslqSvZrcZeaGpS+TGI00HIAybv5E/agEIESsbNuYlnZDMRWT6sKwe8g8h2+UECwKLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6100
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/31/23 11:44, Borislav Petkov wrote:
> On Wed, Mar 29, 2023 at 07:22:00PM +0000, Avadhut Naik wrote:
>> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
>> index cc5c63feb26a..869dcca5e2f4 100644
>> --- a/drivers/edac/mce_amd.c
>> +++ b/drivers/edac/mce_amd.c
>> @@ -192,24 +192,24 @@ static const char * const smca_ls2_mce_desc[] = {
>>  	"A SystemReadDataError error was reported on read data returned from L2 for an SCB store",
>>  	"A SystemReadDataError error was reported on read data returned from L2 for a WCB store",
>>  	"A hardware assertion error was reported",
>> -	"A parity error was detected in an STLF, SCB EMEM entry or SRB store data by any access",
>> +	"A parity error was detected in an STLF, SCB EMEM entry, store data mask or SRB store data by any access",
> 
> I'm assuming that "by any access" is not needed because
> amd_decode_err_code() would say "GEN"-eric for the transaction type
> which is the same thing, basically.
> 

That's fair.

Two (likely weak) arguments for this:
1) Match the wording as closely as possible to the documentation.
2) Folks are likely only looking at the Extended Error Code.

If we deviate to far from the docs, then people will ask us why
Linux says "X" when the docs say "Y". :/

>>  static const char * const smca_if_mce_desc[] = {
>> -	"Op Cache Microtag Probe Port Parity Error",
>> +	"Op Cache Microtag Parity Error",
>>  	"IC Microtag or Full Tag Multi-hit Error",
>>  	"IC Full Tag Parity Error",
>>  	"IC Data Array Parity Error",
>> -	"Decoupling Queue PhysAddr Parity Error",
>> +	"PRQ Parity Error",
>>  	"L0 ITLB Parity Error",
>> -	"L1 ITLB Parity Error",
>> -	"L2 ITLB Parity Error",
>> +	"L1-TLB Parity Error",
>> +	"L2-TLB Parity Error",
>>  	"BPQ Thread 0 Snoop Parity Error",
>>  	"BPQ Thread 1 Snoop Parity Error",
>> -	"L1 BTB Multi-Match Error",
>> -	"L2 BTB Multi-Match Error",
>> +	"BP L1-BTB Multi-Hit Error",
>> +	"BP L2-BTB Multi-Hit Error",
>>  	"L2 Cache Response Poison Error",
>> -	"System Read Data Error",
>> +	"L2 Cache Error Response",
> 
> Hmm, so I don't think we can do that - I'll bet on older Zens, this was
> "System Read Data Error" and on newer it is "L2 Cache Error Response"
> which are not the same thing.
> 
> Right?
> 
> If so, we can't really "update" descriptions like that. If we had to be
> precise, we will have to differentiate by family here. Not sure if we
> care enough but still...
> 

You're right. And that's why we need a new HWID/McaType if the errors codes
change. That's the reason for the other "decoding quirks" set.

In this case, the error is likely the same event. But the description is made
more explicit. Otherwise, we'll need another quirk.

Thanks,
Yazen