Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <56d92baa-d05a-9b02-0195-7627187fdde1@amd.com>
Date:   Mon, 3 Apr 2023 12:55:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] crypto: ccp: Don't initialize CCP for PSP 0x1649
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>,
        John Allen <john.allen@amd.com>
Cc:     stable@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230403173801.2593-1-mario.limonciello@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230403173801.2593-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0Y3dHAyRkJJckc5Ni9UdERhQWlSWDZNazRUZHZXNktMYnVQcjczRXVZQnFx?=
 =?utf-8?B?S0NrWHJGc1ZNTFpqaXFiUGtkTE53NFlVZG5mNFptZ0toWExlTXg3V0JHTTNG?=
 =?utf-8?B?cy8zT0gwT2hONnAxY3hNaFNBQTRyVDVqRGxTbnh5Mnd0VkJsQnBRT3FwZUx0?=
 =?utf-8?B?Ym1Ecnd4Ri9WaGtmTjIzZXlUcGNHa1c2dDhZYUlJbmFYS1pSdDU5N0VDQVpT?=
 =?utf-8?B?cHdoUG1wazljUE4zOHAwMW84YkdKM2k1aGxVcGNYSTFWZkY5RGEza3RlS0RL?=
 =?utf-8?B?eGh1dzZqTlU4MUx6SzI2Tjc4b0VhZUNUTUd1SWxwQkxvbzFEQ0NSc2thb1lJ?=
 =?utf-8?B?Q1cvRnRxclo3K1l2b29vdC9HTHU4eXhqeE5CZnB5Z2dWTDkzT0VaQmYzdHEv?=
 =?utf-8?B?amFFY2phVzdHQ1dZS0dzbmVKSzBjTzRMS3YveXVqWDZUZUl5S1lCUWkrSk1J?=
 =?utf-8?B?OEFpMjM3Y1NKWTlVeXVwbFdaMm40ZEFqcFZ1aW5vUmhsTC9tL2FtcjZHY1VZ?=
 =?utf-8?B?eUxOamZKTDNMSEdFZnViZ2M2VGQ4bFk1NHM2N1c0YjVlTmJINDJaUmhIUmV6?=
 =?utf-8?B?WWFCS0psbDN1Nkp3OWtEL0VWTkJ6VnNTWFRWSjdodENGQlh1dU10SklzTHBW?=
 =?utf-8?B?QkNtcDhLMFJaNXBpczlrOHRLbjNGb0lPejhvdVQyTmRRUFRFZW9kY2w3b1FW?=
 =?utf-8?B?NXcvQkhuck0xU0ZmeXp6SlRrbkRqUXVNZytyU0VEUU9NS2lBYnhNN2dyYzU2?=
 =?utf-8?B?QUpVMzFrQWNUWlBEV2xCSm1UR1lVaWFQUmIxMUJyTmFGMDZVMnN2OW5OZGdr?=
 =?utf-8?B?V2hSVFREc2lVSTV3M2JESkU3amFPOHRMbFNkTkRTV25MazMvQm9DT2JhRXF1?=
 =?utf-8?B?bW9DMTdNMFJmUC90K2Vtd2FwTjZtbDFxMzBXT2NtUWVrc2RIQ2tPcDNvTE1S?=
 =?utf-8?B?a1AxN1pNOUMvZHFuYlo4N213Q1gvbE1LMURYVHl5VmlwakswSE9qUmU5V1VP?=
 =?utf-8?B?WmxNb3A3b2VTTjJZUklZTlpBczIxMjNVMDFpZ2dyUE1OaTh6ZFg3b2oyS1dB?=
 =?utf-8?B?bUVjNkZMSCtKZEs3V05nZzZSNEJpTjNhRVVYYVluSnRJWVg0NmszT21GN214?=
 =?utf-8?B?VUYzZUozK1VRY2poZitodDNqaGMvZ01wc3ZCcmZzNCswWE1CSzc4OGxzTVVr?=
 =?utf-8?B?ZFRWYURHdGlxbzYvSElvbkIzQitwNTEra01HRFI5dHNaQml2Nkliam4yTzI4?=
 =?utf-8?B?QzZ0Y25aZSttOGFIbCtIOHhCQVZTSE1OZ3ZWdW9iVzFYcmVPdkFlQlJTUEl4?=
 =?utf-8?B?QUQyUUNuaElybHdBcm1OMGhYS3lBRENXS0NqL3F3cFd3WFV4bDRBQXNab042?=
 =?utf-8?B?SUE1T0pIT3dydGJiZ3haZG1MVGppQnRQQ3Z5UzRBajRDRlJrellWWXZNMjdC?=
 =?utf-8?B?bjEwcVBHQ0luNXFrOFRVRERjeVQ5TzN2UlhBTXNlK0pLMHRIM2c3bnFNZ0V3?=
 =?utf-8?B?YlN5NVY0Zm1RUXlvUEsrRHNNQzVYNVdCSkZFbmNiMWQxdzhxSjc3K29sQXhL?=
 =?utf-8?B?MHcvMlM2NjZ3bGxyNC9ZWTYxMDVyR20ycEQ0Q05ZQzdGMkJPRFdINWc2aHFm?=
 =?utf-8?B?dW5abkhxOXhUeFA2bmp6SzBiL0Y0T1kvMVB4aEdSbm5PVlZMcW5nZUgyRHBz?=
 =?utf-8?B?QmgxZ1kyRXMrSDNFZWdzSFA2SE1NMEp3cXNXL2VMZmtZcDJGQzMybU1nY2Jl?=
 =?utf-8?B?bjZUektSaFRqWVNTTDVXeVZOTlBoWUl5eVV2TllDK2p3TkduQlE0NlpOcmww?=
 =?utf-8?B?Mi9LSTlGNEwzUHlrSFNLMTNMWC9XVHJSMEdDRU15SVdUUkNhMGRsRnhnYXhT?=
 =?utf-8?B?V25rOUtDdWRnRDcxR1BoL1huNUNyYk9uTlZ3VTB5QkJnN0VOU0hUS0hxUVBG?=
 =?utf-8?B?L2tsYzZ3ejRJQXdwTGZZOE9Bd1JQaTF5V0VnYkt3RVdDZEdJN3h1WHpmNEtX?=
 =?utf-8?B?V3BEY3FWUWlFTENPQllxVzFPSjg5L2lUZU9YUzE3T1dOY2FKRUt4KzIvUGJ1?=
 =?utf-8?B?c0NiM3JGeFJIc1ZTeU94bW9lcWxUU0NvTC80K2diY1pWRHJNWldRTFdWZGpl?=
 =?utf-8?Q?fzonyMZrSYmWR2rxqYPIo7B7t?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc717119-cb24-47fd-6d2c-08db346c956e
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 17:55:17.2366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: suwppOAe5X8ELZk5RFpWTed2fzDG84XFaqMYMmtk+fPN8pC9tdkNYeFjv/V5YImHggTmeF/lenHAol3+3xQKlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8209
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/3/23 12:38, Mario Limonciello wrote:
> A number of platforms are emitting the error:
> ```ccp: unable to access the device: you might be running a broken BIOS.```
> 
> This is expected behavior as CCP is no longer accessible from the PSP's
> PCIe BAR so stop trying to probe CCP for 0x1649.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/crypto/ccp/sp-pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 084d052fddcc..55411b494d69 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -451,9 +451,9 @@ static const struct pci_device_id sp_pci_table[] = {
>   	{ PCI_VDEVICE(AMD, 0x1468), (kernel_ulong_t)&dev_vdata[2] },
>   	{ PCI_VDEVICE(AMD, 0x1486), (kernel_ulong_t)&dev_vdata[3] },
>   	{ PCI_VDEVICE(AMD, 0x15DF), (kernel_ulong_t)&dev_vdata[4] },
> -	{ PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[4] },
>   	{ PCI_VDEVICE(AMD, 0x14CA), (kernel_ulong_t)&dev_vdata[5] },
>   	{ PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
> +	{ PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[6] },
>   	/* Last entry must be zero */
>   	{ 0, }
>   };