Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56684263:Fastmail
Message-ID: <62df1021-ad53-9fd9-d8b8-cc7a21ca36a7@ryhl.io>
Date:   Mon, 3 Apr 2023 19:56:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
From:   Alice Ryhl <alice@ryhl.io>
Subject: Re: [PATCH v5 07/15] rust: init: add initialization macros
To:     Benno Lossin <y86-dev@protonmail.com>
Cc:     rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev, Alice Ryhl <aliceryhl@google.com>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?UTF-8?Q?Bj=c3=b6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>
References: <20230403154422.168633-1-y86-dev@protonmail.com>
 <20230403154422.168633-8-y86-dev@protonmail.com>
Content-Language: en-US
In-Reply-To: <20230403154422.168633-8-y86-dev@protonmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/3/23 17:45, Benno Lossin wrote:
> Add the following initializer macros:
> - `#[pin_data]` to annotate structurally pinned fields of structs,
>    needed for `pin_init!` and `try_pin_init!` to select the correct
>    initializer of fields.
> - `pin_init!` create a pin-initializer for a struct with the
>    `Infallible` error type.
> - `try_pin_init!` create a pin-initializer for a struct with a custom
>    error type (`kernel::error::Error` is the default).
> - `init!` create an in-place-initializer for a struct with the
>    `Infallible` error type.
> - `try_init!` create an in-place-initializer for a struct with a custom
>    error type (`kernel::error::Error` is the default).
> 
> Also add their needed internal helper traits and structs.
> 
> Co-developed-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Benno Lossin <y86-dev@protonmail.com>
> Cc: Alice Ryhl <aliceryhl@google.com>
> Cc: Andreas Hindborg <a.hindborg@samsung.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>