Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 19:28:17 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Devi Priya <quic_devipriy@quicinc.com>, agross@kernel.org,
        andersson@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        quic_srichara@quicinc.com, quic_gokulsri@quicinc.com,
        quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com,
        quic_arajkuma@quicinc.com, quic_anusha@quicinc.com,
        quic_ipkumar@quicinc.com
Subject: Re: [PATCH V2 4/6] regulator: qcom_smd: Add support to define the
 bootup voltage
Message-ID: <a657284f-a408-48a8-b294-0add65b3e2a2@sirena.org.uk>
References: <a54d4e1b-d62d-559d-1882-e460e696c056@quicinc.com>
 <ca12735e-d6c8-997e-036f-693cd8a9870f@linaro.org>
 <e19393e3-5898-bff2-cc00-d88c9194c7c2@quicinc.com>
 <6e1f6466-7f2e-7bd5-f6a2-5691a30c4e1f@linaro.org>
 <9989c92c-9949-5531-c7d2-e54882795a68@quicinc.com>
 <69df153d-bdc6-9008-39d6-72f66bab2e38@linaro.org>
 <5914a8db-3644-1c94-00ba-460ba2c26a5d@quicinc.com>
 <3c5a9608-ecd2-a3c0-e866-7d0070e49b89@linaro.org>
 <8c513ddc-435e-40ce-b1f8-84eaf8241ed4@sirena.org.uk>
 <fe4dd395-cd1d-55e8-1be9-f588f69a8b13@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="eJO3awvhoD6CB9ap"
Content-Disposition: inline
In-Reply-To: <fe4dd395-cd1d-55e8-1be9-f588f69a8b13@linaro.org>
Precedence: bulk


--eJO3awvhoD6CB9ap
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 03, 2023 at 08:21:25PM +0200, Konrad Dybcio wrote:
> On 3.04.2023 20:14, Mark Brown wrote:

> > than up to the minimum.  The driver could also look at the constraints
> > when guessing at the hardware configuration rather than claiming an out
> > of spec voltage, this would mean we wouldn't need to correct anything.

> Hm, all of what you said sounds like a valid concern.. And then we
> probably shouldn't shoot up to max by default, as going too low is
> not going to cause as much potential irreversible damage as going
> too high.. Especially with programmer error..

It sounds like the driver should just be reporting a value which is at
least within the constraints.

> Too bad Qualcomm's firmware architecture doesn't allow for reading
> back the voltage..

Right, their interfaces here have some serious drawbacks.

--eJO3awvhoD6CB9ap
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQrGsAACgkQJNaLcl1U
h9Brzgf/fHXT5Kvi+p/X1tFyM8ue/cFz1bfRsZhhHC3QWHYVy42iBGd89Om++a18
sXyeCOE007CEnQ/sf4VmRsHd3kqJngCeBFep6aEhN6A63epUDXCZVjN/WQtJwNzH
8oM3mmYdndld/BdpG4A61FOlUInvxD3Dq7/I+RyUm6CFF8VFowhzw19UU6zfKwNF
7a65sQqgdXurpz9hDBZ0r5sB6gLb810Y9E2D/RcyvmrmwvFbv/ZlbbTUjqDf8Trc
N8znzhC+ZfBRiDt/9YBx2wxLrV7UhCt2NP7RS9KP5hKfedc1e3dBomXE8rArDM0F
HpJ4JUhGggNDNkTFs2gjAGJcJdtrhA==
=RhOj
-----END PGP SIGNATURE-----

--eJO3awvhoD6CB9ap--