Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4922127rwl; Mon, 3 Apr 2023 11:31:19 -0700 (PDT) X-Google-Smtp-Source: AKy350aoPd/7OoCC1s1uhuAnQPXfha8somkQA++c2dKLFhA330bmrMtfl70lWtgA+3wmMk8cou19 X-Received: by 2002:a50:fa8f:0:b0:4fa:b302:84d4 with SMTP id w15-20020a50fa8f000000b004fab30284d4mr157060edr.13.1680546679114; Mon, 03 Apr 2023 11:31:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680546679; cv=none; d=google.com; s=arc-20160816; b=tbLPAFNja58xUG5yoUye2oWsNtKbrv2ZZxuJX4T6VBRELNlSsPjX5DHASMbp3/T0gm lvkhkb9u+4XZhVqGUAUxx8jFP4Cjaxx8oxhzpPb7q3JfldF1l3AzXOdz1Gjg63KlVlZr d5UFHhv/ZK6AuZQnCEp9FztXpm5z9rSsWTbF1MFztoTnk39KQZrbumJtH46q4BtSuBfW kUCaLmVftw68ZUYmldtLz1xZK6DvAqAD1oAxCAlPd4Wmpd+1W42xFeuZf//4ntaFwJEe pFkyWpOL8Y6ceJ21DWdbtO9VqXk9q/R/mXGauB/mM9lJ2+CPpQElOeVnLqv4BFycATkm 2p9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=2CvpTlv56nZ107p19LANHzNyhk/HQ225r0oM+91kQ8c=; b=ay7Mvyw3xgAYR3yZdieic6sCOMQtGWN72EV3huCAkNMF4mXI0xHRsM2DZDzx1KTBkY NSejA9fqt+z0S1lNB5vVLhC74TYmzPu7e2GoJbvm9CnYe3uuHTafYTSoo57oUFxlXXxQ 0ATqxnmJS7Wq6KoqKYTASM8pdWyBsK885H1YveodUz0U6PmECQrHP3xGzd9yc15u/+1K Yf6b7zM5Dv6QkU2e0IlreEmnKylgPStf7GDr6Jc2SJqOsjEpCBG9XMGMeKM1t6OJTBQv A8C/CuliWGefvPmjcmTcpUAn/9JvQxtrF7Z7HyajOmaHj9iS6inRPGlUMA0R9mkLWvOl 7e1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TUw3GIgd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id be6-20020a0564021a2600b004ad0caf3dc0si4252944edb.480.2023.04.03.11.30.54; Mon, 03 Apr 2023 11:31:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TUw3GIgd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233034AbjDCSaB (ORCPT + 99 others); Mon, 3 Apr 2023 14:30:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232141AbjDCS36 (ORCPT ); Mon, 3 Apr 2023 14:29:58 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C94E430C1 for ; Mon, 3 Apr 2023 11:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680546597; x=1712082597; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=JHYBbxcGddX0wTVZ59Y7TiSvMqk9yfeulh/16f0QVm8=; b=TUw3GIgdkzkavJgwpYUjjXFdHGFXBQwiteVX1ekZ5uPFV5kniEXm/fs3 1u6gc03OMHltzADuWo5/DRPGHLKNq5+ynXOYYQ13+frljY1tbq64M7Kqu bfQtNBEjiXYsoCEHqCl7zOhH8Lvf0iud0BVFdMQia+cWOQx/EFCrDuOln bFC2dNDb5BQGhfQpCIRE6fFw6VEcGInTC8qrZPWzgFlOwr5dz8gW+wiXx 0w593i3W/AUK3EVUiXOGqjOO8uoF0fVW0rWSUDIw26/EYrpGvy8MYv5FT c3Lk06elqSPeC+NQajOjsNtA7Xo/84JX4n4eJ7Nj+mRC2PBLcpfWZc0c7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="325994860" X-IronPort-AV: E=Sophos;i="5.98,315,1673942400"; d="scan'208";a="325994860" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 11:29:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="750580306" X-IronPort-AV: E=Sophos;i="5.98,315,1673942400"; d="scan'208";a="750580306" Received: from akleen-mobl3.amr.corp.intel.com (HELO [10.209.21.167]) ([10.209.21.167]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 11:29:56 -0700 Message-ID: <96d44033-3bfd-840b-15d7-80dd3a1a5313@linux.intel.com> Date: Mon, 3 Apr 2023 11:29:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] x86: profiling: Using generic unwinding in profile_pc To: Chen Zhongjin , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "hpa@zytor.com" References: <20230224021858.120078-1-chenzhongjin@huawei.com> Content-Language: en-US From: Andi Kleen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/2/2023 6:24 PM, Chen Zhongjin wrote: > Just ping... Or has profile code already been obsoleted? I think it would be reasonable to remove the locked functions hack since lock profiling can be handled with much better other tools these days. I wouldn't make it depend on the generic unwinder since such a low level facility is likely better off without complex dependencies that could break. -Andi