Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 11:50:11 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Felix =?UTF-8?B?SMO8dHRuZXI=?= <felix.huettner@mail.schwarz>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "dev@openvswitch.org" <dev@openvswitch.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Luca Czesla <Luca.Czesla@mail.schwarz>
Subject: Re: [PATCH] net: openvswitch: fix race on port output
Message-ID: <20230403115011.0d93298c@kernel.org>
In-Reply-To: <DU0PR10MB52446CAE57724A0B878BAA66EA929@DU0PR10MB5244.EURPRD10.PROD.OUTLOOK.COM>
References: <DU0PR10MB5244A38E7712028763169A93EA8F9@DU0PR10MB5244.EURPRD10.PROD.OUTLOOK.COM>
        <20230331212514.7a9ee3d9@kernel.org>
        <DU0PR10MB52446CAE57724A0B878BAA66EA929@DU0PR10MB5244.EURPRD10.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 3 Apr 2023 11:18:46 +0000 Felix H=C3=BCttner wrote:
> On Sat, 1 Apr 2023 6:25:00 +0000 Jakub Kicinski wrote:
> > On Fri, 31 Mar 2023 06:25:13 +0000 Felix H=C3=BCttner wrote: =20
> > > diff --git a/net/core/dev.c b/net/core/dev.c
> > > index 253584777101..6628323b7bea 100644
> > > --- a/net/core/dev.c
> > > +++ b/net/core/dev.c
> > > @@ -3199,6 +3199,7 @@ static u16 skb_tx_hash(const struct net_device =
*dev,
> > >         }
> > >
> > >         if (skb_rx_queue_recorded(skb)) {
> > > +               BUG_ON(unlikely(qcount =3D=3D 0)); =20
> >
> > DEBUG_NET_WARN_ON()
> > =20
>=20
> However if this condition triggers we will be permanently stuck in the lo=
op below.
> From my understading this also means that future calls to `synchronize_ne=
t` will never finish (as the packet never finishes processing).
> So the user will quite probably need to restart his system.
> I find DEBUG_NET_WARN_ON_ONCE to offer too little visiblity as CONFIG_DEB=
UG_NET is not necessarily enabled per default.
> I as the user would see it as helpful to have this information available =
without additional config flags.
> I would propose to use WARN_ON_ONCE

skb_tx_hash() may get called a lot, we shouldn't slow it down on
production systems just to catch buggy drivers, IMO.