Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <261135b7-6d81-d330-2beb-2473d9d4a36e@intel.com>
Date:   Mon, 3 Apr 2023 21:17:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH RFC] PM: runtime: Drop device usage only after remove is
 done
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC:     <linux-kernel@vger.kernel.org>, <kernel@pengutronix.de>,
        <linux-pm@vger.kernel.org>
References: <20230402103951.2510773-1-u.kleine-koenig@pengutronix.de>
Content-Language: en-US
From:   "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
In-Reply-To: <20230402103951.2510773-1-u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlJOUktlRjlFYWZHU3ppUmkzMllnYzN0TEpTSkxoTytMQ21DeEs1SnRFLzI0?=
 =?utf-8?B?VzN0dTZUUW8zbzNpMnpMOTIrdGdMMWNvN0xUeE03SEQ5WUt1bWUvRlZQbzNK?=
 =?utf-8?B?TE9zZ1p5T0w0U0ZidStZalJIeDBOa2NzckRUMFVOL0pweDZBVnNnUy9qd0hT?=
 =?utf-8?B?cy8rTHVveXZBdTVmZE96c1I4NVRIamZWNm84eFhpWnF5VkFWUWhkUEx4Wk1H?=
 =?utf-8?B?MmRFUnMvL1dwY0lKa0RzYW1pRVdTa0ZXSUwyZTlCY3NEMDgvc1podmVyVlVh?=
 =?utf-8?B?RHVJR3cxVkxMbGVSTFRaWFdLVnNPd3RHSEc4NGNzeVdPVi9BQk94OGlTTlB6?=
 =?utf-8?B?azRDMjcwVXlyNkxKTVBpV0N2elRUdlpLYys0NldvNXFiMHBjN2FSd0htL09Z?=
 =?utf-8?B?QUtKRWM0dFJZc0RqSVdCbVZBZ3dNQmYyaGRsWUJEWWI0ODR1U1M5VDIybnhY?=
 =?utf-8?B?RWhPai85cmIrcU1XekpGeStZOERxcFhFRW1DVGRHNC9ZQmhzSDhvZW5maHF2?=
 =?utf-8?B?V1Jnc2U1b1Q1UnQ5WHZsMG5iNWxwTmJkMFI2cEJzWmczT2lzSDJjRHR1WWRE?=
 =?utf-8?B?SjM2RUJrc3hldVN1c3NGTEZVVFJBYVJndS9pYUd2QlBOMU9HK2RwSUFNY2I2?=
 =?utf-8?B?cnZ1RjJldUFQWkFSdXV0UHdoQlVpR0EycGhkcnB3SnJyQTh5Z0Qza1gwUndT?=
 =?utf-8?B?Snhtb3dQaGpKY0dKUndQWWdHU3huQm1ESUQ2MUloaGZCUDFJN1I4UEZjYXFa?=
 =?utf-8?B?SzVtUUFWbUhSYzk3T1NYajhrVlJ1ZDBXNU9XZEtLbFRrL0dWWXNrb2lPOG5s?=
 =?utf-8?B?Lzg2MzRmdThoRkJEdVlVSEo0NXo1aFRVQnYrMG1SbGlucHo1ZzhuR0ZHSXNE?=
 =?utf-8?B?VTdyOWgwY200OERTd2RnUHpadVRoTm12dGk4U0UyZkQ0ZmpyK3J3eEo2V2Ir?=
 =?utf-8?B?WVRkalJBaVYyUFpKWkV5c2N6aTUwQjN4VXc3TWNuS1R6ZXpEcmJxeFNqcllU?=
 =?utf-8?B?M2lySWc4aHpCNDdTQUYxU0hGcTZNSlRpb283am1aZGFsSmlqL0o3b0JHNVpI?=
 =?utf-8?B?NFNIR1BtVXNBOFZ0SE9FR1BpRlNFSnA5djRGWWZ2QXB5ZS92NkREZGNIZ0RU?=
 =?utf-8?B?VVU1emJMekllYm5OeFZCaXZQdmVaT2laSWJoV0w4a1BOaDFSQm1VVUtwUFRP?=
 =?utf-8?B?U1F2ZGQ1dFFqZDMycFEzZFR6UXVYUG9QQ0hwNHk0ODRiV29wait2a2Y0SEMy?=
 =?utf-8?B?MjNBNFJZSG9jdEdmRGVXcGI5Umw2M24xT09rcFBwbmljai9hQWluVTBvdW5z?=
 =?utf-8?B?eEJQd0lZTHFjbjJ4QVUzOGVEclJ0dStBejBVdVo1OFoxMkVxWWJIQWdnZDBK?=
 =?utf-8?B?REZjbDNFajVQVTRFUVJqamdtWnZOMWY3YmxzZjkvSlJGTWJXMWZrTWpKdHV1?=
 =?utf-8?B?RkpWU1NFN1hYUkQwdGFqWHdxMWpOVWpvN2IxUkkrSERlMjhTRENCZGkwLzVL?=
 =?utf-8?B?WFRQR2tTK3NENWZ4SDVOam1NeXhqMnpSTG00SEYxcXpFdVN4MVNDS2ZtUUI3?=
 =?utf-8?B?NmZiT0xZRndDa2hkOUwzQVgwM3B4N1I1bkh6a2VYWEVJWUhGd0w2Ymgzb0E3?=
 =?utf-8?B?ZUljdE4xdWppdnBucnJCTTBGVlFBUUhkZkF4am00THJ3c1QvWU9aaXM1Wm40?=
 =?utf-8?B?SUVNUElWMGpsWXZpVDNZejNzZ3Q3TlBpRXp2VmFZQmordjNXU0FqczA0UGZ5?=
 =?utf-8?B?Z1VWNmVhS2lhVGllN0ZCNnI0TnNZMGVYZUljUTViZlpUQXNLVkVEamd4V2Fi?=
 =?utf-8?B?UUlpOVVkQkd4MEgvQmVwTzFNUndWTi9MQ25tUlNTWUc5azZpS002TUxJYUM4?=
 =?utf-8?B?dnVkY2d6RFlmZDRsVVRTRFJXd2svdXBYcTF1ZjBxMEZvZWtudnJmMlNWVU05?=
 =?utf-8?B?SEdDNmExc3R3aFg4NDQ3ZkhDYUI0QW1GK3pJayttd0Q3TWFQRFBCQjhhVUha?=
 =?utf-8?B?WmJ5L0p1bUNGMjZhNlJPK2NiTXpmc3E5ZDNHK3QwcndlSWI3R3NVcldTWmpP?=
 =?utf-8?B?Skl1a09lYTFwWmpnUTlneTdMOHNWNTkydUlza0VOdW5iQ1l4d1diU2lpMFdn?=
 =?utf-8?B?OWRrRmhRYWRRMFpSM1hKR1JWYlRHS0hLWXVtbXVVSFpMMjNrZDZCUmxxWE8v?=
 =?utf-8?B?M0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: feab9d44-0188-4706-271a-08db34782432
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 19:18:01.9559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n6atnuEguhihJKZv0vWel7mDsYJ6Z9sIE/tO76J3CcyWcrhKo0d92HEZphOIMnmiFeD2DRGPpus4j8Cg7s8fPtF2444ReICdIF7oX9z/iAM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5238
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

CC-ing linux-pm would have been nice (done now).

On 4/2/2023 12:39 PM, Uwe Kleine-König wrote:
> Many device drivers call one of the variants of pm_runtime_resume() in
> their remove callback. So calling pm_runtime_put_sync() just before that
> is ineffective as the suspend callback might just be called just to
> resume the device directly afterwards again.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this is a theoretical issue that I noticed while doing some research how
> pm-runtime works. Not sure it makes sense, so I marked it as RFC.
>
> Best regards
> Uwe
>
>   drivers/base/dd.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 8def2ba08a82..6beac141d3d2 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -1235,10 +1235,10 @@ static void __device_release_driver(struct device *dev, struct device *parent)
>   
>   		bus_notify(dev, BUS_NOTIFY_UNBIND_DRIVER);
>   
> -		pm_runtime_put_sync(dev);
> -
>   		device_remove(dev);
>   
> +		pm_runtime_put_sync(dev);
> +
>   		if (dev->bus && dev->bus->dma_cleanup)
>   			dev->bus->dma_cleanup(dev);
>   
>
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6