Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230403105052.426135-1-cristian.ciocaltea@collabora.com>
 <20230403105052.426135-3-cristian.ciocaltea@collabora.com> <642b134c.4a0a0220.1d01a.5990@mx.google.com>
In-Reply-To: <642b134c.4a0a0220.1d01a.5990@mx.google.com>
From:   Peter Geis <pgwipeout@gmail.com>
Date:   Mon, 3 Apr 2023 15:27:22 -0400
Message-ID: <CAMdYzYrLjV97_Q2jhmNa9SJkraKXjttrZwovc=dmPTNLYnz5qg@mail.gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
To:     Chris Morgan <macroalpha82@gmail.com>
Cc:     Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, kernel@collabora.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 3, 2023 at 1:56=E2=80=AFPM Chris Morgan <macroalpha82@gmail.com=
> wrote:
>
> On Mon, Apr 03, 2023 at 01:50:52PM +0300, Cristian Ciocaltea wrote:
> > Add the necessary DT changes for the Rock 5B board to enable support fo=
r
> > the PWM controlled heat sink fan.
>
> Honest question, but should we be adding this to the board file if not
> every device has a PWM fan (they all have the socket for the fan, but
> not the fan)? For example I have a passively cooled case that doesn't
> include a fan.

Active cooling should be set up to take effect before throttling. If
it is there great, (especially if it has feedback), if it doesn't
exist it really doesn't affect anything because the throttling will
kick in as necessary.

>
> Thank you,
> Chris Morgan.
>
> >
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm=
64/boot/dts/rockchip/rk3588-rock-5b.dts
> > index 95805cb0adfa..bd74d9da2c17 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > @@ -17,6 +17,14 @@ chosen {
> >               stdout-path =3D "serial2:1500000n8";
> >       };
> >
> > +     fan: pwm-fan {
> > +             compatible =3D "pwm-fan";
> > +             cooling-levels =3D <0 95 145 195 255>;
> > +             fan-supply =3D <&vcc5v0_sys>;
> > +             pwms =3D <&pwm1 0 50000 0>;
> > +             #cooling-cells =3D <2>;
> > +     };
> > +
> >       vcc5v0_sys: vcc5v0-sys-regulator {
> >               compatible =3D "regulator-fixed";
> >               regulator-name =3D "vcc5v0_sys";
> > @@ -27,6 +35,10 @@ vcc5v0_sys: vcc5v0-sys-regulator {
> >       };
> >  };
> >
> > +&pwm1 {
> > +     status =3D "okay";
> > +};
> > +
> >  &sdhci {
> >       bus-width =3D <8>;
> >       no-sdio;
> > --
> > 2.40.0
> >
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip