Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 15:44:43 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Vlastimil Babka <vbabka@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
        Suren Baghdasaryan <surenb@google.com>
Subject: Re: [PATCH 0/8] Fix VMA tree modification under mmap read lock
Message-ID: <20230403194443.af3kbawab3d4r5pr@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
        Suren Baghdasaryan <surenb@google.com>
References: <20230327185532.2354250-1-Liam.Howlett@oracle.com>
 <20230327123515.bce6c1ea3660e9b17db50c33@linux-foundation.org>
 <20230327194800.fzqfrxfh3nfmqwgk@revolver>
 <a017acde-7520-743c-963b-94a23c0f30c8@suse.cz>
 <20230328130230.gdmychfid3aggikd@revolver>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230328130230.gdmychfid3aggikd@revolver>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nB/qVLCtXGaZ3IUivBrGstxKFqbySEZ7vtQPSaY8oD5wrAdkTmsJNIUAlNe3?=
 =?us-ascii?Q?qkkOIi4AY6zmIwi6IM8TUTCdYOMEGwAmP/hI2oEsMpYQUEl0c7ZeSmQI5dgE?=
 =?us-ascii?Q?faGf/bqcsY0FDmuKYKD/SK4k5DXoXZYXTd0yvqDOHrCKzLv3s6jT9qrE6oAY?=
 =?us-ascii?Q?k/JdMHa8uKjOYkgG9TBzkjTE7STqtlJ6ly7kQa8wUeK6z3TSA9BtOnDGW9gG?=
 =?us-ascii?Q?9G9UsN/FVRSjrvwkMQ9GOHBi/lwE1dXbpwg6kRs04Mxl9qLyDc4RdDvjv0vB?=
 =?us-ascii?Q?vLChYpzM5Gzh7CRV6XNpbtZq1pAqAA9Gbv6qXo+bmXbLXdAsDrdLDE4sMW5N?=
 =?us-ascii?Q?Vwrfc9tzKzJwZ4JD6+4xVN4hToBQ6ZEa7U3us0T43JCTo7/0h7EsGaC6X1Iy?=
 =?us-ascii?Q?x11Rc2fp33xClfKTPjzVnMMm5GsP2WCK5WXJSOMeg99lXgWoE0CmrHfRMADN?=
 =?us-ascii?Q?U2VNRwEt92VfzYBqVXr0l8LFVnhDQGlfo3Op6Dz9wanX1D1y8LMMcIVqznlm?=
 =?us-ascii?Q?/1aLRwFShFjS+7gUZOmg4bm2lnMo4K7QiEINcSvIMjCKnCxwy34VJrrFEVNA?=
 =?us-ascii?Q?LAXKo7YVMrc8VUDhGeEFnv3+H10fBdltk8ob1U8cUajzcFyratHK8b8zTZOV?=
 =?us-ascii?Q?8/TK2BGB8B4g+f5RBvPdWBBTWeD824c0kXzPOS03YjvSFRQ3oNVNqUywk7eG?=
 =?us-ascii?Q?2/Z3t54FAAZE9/zyI3i8jFWe0kTKbPJTZrC4qYIyYDHrAcblXPVVVb7sXd2N?=
 =?us-ascii?Q?KpY8roEm5REUsee6OajHovAQK4l+BefS7OLeBsXuiIpyEfSjzSNn3+3wMqMa?=
 =?us-ascii?Q?VbM1tvMah4oLfMBAQCW1ycyDV/o4JfxqwA+LOzYvNiiFWQiQgONVOEllL6PQ?=
 =?us-ascii?Q?wnwzuZcjoCGxgGoePMGZxLpt+qpNVx0p0Jbj3Tg5xEr9hzJmdI83IlKoxUmr?=
 =?us-ascii?Q?Cql/e3U3WOLS3q0jqe0xEmNdjDEZLR9iqujidQ95+O0JiyUyhR8/I62RRv/N?=
 =?us-ascii?Q?FyXqs/O60Sq+Bd/iaKMFhnE94bpfW/O0JGj0/V6FNQHlbHolR4tgbxSGNPCJ?=
 =?us-ascii?Q?/6PGMx+dLrTtGYoJO4zx+QTTBjWi19cAUInsZuTUjTSuDG0sNBo1qPq+vKIl?=
 =?us-ascii?Q?6xtBp7fkpGIc8FKCdz6i+SPMdml2/kCv+Fg/XuqEDeeDj+YVRxYNxSDW9gvG?=
 =?us-ascii?Q?7IPMVBFP3vovljnjCpMQDMoDF5IJZoUHJPfdxJFENHtcXNRzaBUHK98e5TAN?=
 =?us-ascii?Q?7Jfm5jSmFUEKp2qbAXdJCl0Oar6lkSZce/FjmiG6EjxBLNbAJh6H0cLcleJL?=
 =?us-ascii?Q?t6Q+OuL4ONIorfOoQBB+A93mXjfb0ZIDVB6gNB+5veItlP+DNDPZiSI70Zag?=
 =?us-ascii?Q?rjBTyd904KmrVBeXQ1Y2sGZU4L+awDKIbfYKazOBK+zMbMEkkoo8EWni68oN?=
 =?us-ascii?Q?gU6rZarYV7NRSb6Dqqr/d6O73YyVkR8OBImzNcg4az7qBbvluqRJGobV7O8+?=
 =?us-ascii?Q?gBJLa21nytuWxUwc7lbH5EisyJejXCkQjpazXrrHS8P8y4CGb2Vsq5+0WOse?=
 =?us-ascii?Q?LXTEwBIEI0SVn10g5bDZDg/sz6b7e9sUyTFz4KlpzfoHEWfMfrXL6JL06kec?=
 =?us-ascii?Q?Mg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?URV83Z1ZBXk39epO6VyspwAiGwj88c5AyAtQhUKZ64FpyrtmF04bx9JaeDeK?=
 =?us-ascii?Q?90mPBu/lfP6hSkb+seKSkWYt5blecajYgdenQ7ekcJJ7/Q6su2AtJha1cKTG?=
 =?us-ascii?Q?mtRurbKQTu3tDht8n4JzWa8Guqcib47TO9HkRYL/MdyyS3DOEFHNRi4AQRR8?=
 =?us-ascii?Q?Wo2Kijt9k86/mNifzNKcRj9zrRAzpk0tUO1BipI97HdFNY/5o+evu4VMWuBD?=
 =?us-ascii?Q?xaByoZgxZ9bCS2gCx+dfRqtaUyxOe2UxqbtC+X4iCLk/cpuEYLW05wtH9Tu7?=
 =?us-ascii?Q?pE5B8q19PS3jPedX3HxbVrT/Dq7/Gb/4ox0aVwCBt3E4oYr/JDwzxzkmV2sH?=
 =?us-ascii?Q?SbFdIbeFBS0WBUREZOKu10YOmsbaHGjspAgcmE/AMDyO1xfR4UKDm/W7wiqY?=
 =?us-ascii?Q?euEH6FmaZ6wo/Cb8J14SWrehqZsRaz+ZgzYhpo2TCO1/j7XAIT//AAoZJlxA?=
 =?us-ascii?Q?NnSghlvrCVIi4r2l26P1C1+N9f6ASU+/TSa6ZVAjQZWizm14G3ZEa90p/9kb?=
 =?us-ascii?Q?WwOq0dEd4i1NyJsShLko+LV5VvC2XOEt7VvhgixEBfaFj5qDsXzksDSk4XSh?=
 =?us-ascii?Q?nyGmPxNqczv+y4qfOxRBrwoeFHd+1YuIMGRl5LnsoZ0r2/YBZQX9511Kcu4o?=
 =?us-ascii?Q?EVemCaR0ulvpNOeRpjEUQtpbvAqwVORLPm7IwOpgFlVgPcWHV2C1+Ab87ump?=
 =?us-ascii?Q?CnREBstxVH81siZthKCgVP4ACE/vgvCK4jDVffw5Yg1JW86KLEcuvzFiDoM+?=
 =?us-ascii?Q?zJ490K0q77d60av7+pFxWnzskPGTpa03VEtXBGUN1S5G9sZbaIgzz0TNeBNx?=
 =?us-ascii?Q?kaUw2yZOVWScxxgFBJg0dVSLMaHVbcuixtydOVgteNYEXUxXEtMBmTKfMdsP?=
 =?us-ascii?Q?GXHyxFMNL918Xw5pCssORRRkzcvDVjKOJC9BRcLtELQhuoDojN7mYo39jlfZ?=
 =?us-ascii?Q?m+slyeJIGpj9+gxDWTjd+bwUiguhFxPqb344qkxVgyg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c146907-7a79-4922-cf03-08db347be121
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 19:44:46.8184
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d/yXQddPpIOWoO+1OQWfxJCtyb9v9oD3ka3VOdkHa27lejG/8hJ6pfAi28V8Yr6BR07F2Dmf0B10gHqqCgHJig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5060
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-03_15,2023-04-03_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304030152
X-Proofpoint-ORIG-GUID: BIY57OlIA5FOEn9oeV4LD_APZs9LeE2-
X-Proofpoint-GUID: BIY57OlIA5FOEn9oeV4LD_APZs9LeE2-
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Liam R. Howlett <Liam.Howlett@Oracle.com> [230328 09:02]:
> * Vlastimil Babka <vbabka@suse.cz> [230328 05:11]:
> > On 3/27/23 21:48, Liam R. Howlett wrote:
> > > * Andrew Morton <akpm@linux-foundation.org> [230327 15:35]:
> > >> On Mon, 27 Mar 2023 14:55:24 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> > >> 
> > >> > These patches have been in -next since next-20230301, and have received
> > >> > intensive testing in Android as part of the RCU page fault patchset.
> > >> > They were also sent as part of the "Per-VMA locks" v4 patch series.
> > >> > Patches 1 to 7 are bug fixes for RCU mode of the tree and patch 8 enables
> > >> > RCU mode for the tree.
> > >> 
> > >> What's happening here?  I assume you've decided that the first 8
> > >> patches of the "Per-VMA locks v4" series should be fast-tracked into
> > >> 6.3-rcX and backported?  And we retain the rest of that series for
> > >> 6.4-rc1?
> > > 
> > > Yes, they need to be backported and fast tracked to fix the issue syzbot
> > > found.
> > 
> > Stable usually wants the "mainline first" which means fast tracking first,
> > then once it's in mainline, they pick it and annotate with mainline commit id.
> 
> Right.  I meant these patches won't cleanly apply to 6.1/6.2 and will
> need more than just a cherry-pick due to the vma iterator changes.  I
> have those modified patches ready to go as well.
> 
> > 
> > One question is how Linus would feel about this now for rc5.
> > 
> > Another question is if we should really deviate in the patch 8/8 backport
> > just because it's not necessary for stable. Generally they would also prefer
> > not to deviate, unless there's a strong reason.
> 
> Just to clarify, the change is to remove something that isn't necessary
> at all.
> 

Andrew,

I just wanted to know where we stand with these patches?

I understand that it's late in the cycle, but this is a bug that affects
6.1, 6.2, 6.3-rc5 and can be triggered from userspace.

I'm asking because the LTS 6.1 is starting to be picked up by
distributions, although I don't know the scale of the install, and
getting these upstream will allow for the backported fixes to be picked
up by stable quicker.

Thanks,
Liam