Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 16:10:03 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: Use mas_walk() instead of mas_find()
Message-ID: <20230403201003.5eqmsq7k7igkhzhx@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Mark Brown <broonie@kernel.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230403-regmap-maple-walk-fine-v1-1-09512dd51e50@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230403-regmap-maple-walk-fine-v1-1-09512dd51e50@kernel.org>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C4TebyjXCknQJnDTBqyhkdgyck3EUqs1n3SjYCckCluWkHNNh0olre6y/ijJ?=
 =?us-ascii?Q?lBbN/q/9LlpTLbogkcnV2r549zfT1ABgLoW2sI5CM9A9MSMZqqvrt/PDwEWy?=
 =?us-ascii?Q?3lHSPKjwnvcz7ot6DXj6iKAcn8ap0VldwxeOBqpvDyV/j8U4IvyvIvctPTbu?=
 =?us-ascii?Q?CNSIL+R+EvPxZ+3e5XepvD+ymDxtNCEFggEs3r4BIBWImc+TGSeqQkVxtbV/?=
 =?us-ascii?Q?YJdfGzXx1lIen8jNpw85L2DFAGEcUuxpeii53+7bdqI0Nn32XvihiIF1duvh?=
 =?us-ascii?Q?GbDz0zkL0ofwy1h4bJunSj0/IX9LpYp8ACQlTVsHdCr2jHi0DRmZRWnlhbtH?=
 =?us-ascii?Q?D67rP2FIx1JZNAQGlbq43KylTuKJJz5Gi3i9F/cmtbhIqcBMUQfwDXt3kc5K?=
 =?us-ascii?Q?W26tI3NCWI8nerN/f7ereBq/9xR+jLE7k+HZ2WkIu6/rcnbz+5COUEnkiSd8?=
 =?us-ascii?Q?9m1/z7skYiuI73K86ZXtox8R5/wTChNVuY749SeulYlzR24hFl6O8LIezxDn?=
 =?us-ascii?Q?8iGIvaiEOn9ye6uTe65oghl/9bvW+1BQylKwerzNlyJUy/2m6gaJq9QCJ17v?=
 =?us-ascii?Q?jaqUldjHHlKZru3iXx4AcJ3lMg8id2KLVhiAGa+edgU7NhQYMO7vYTnJR3zI?=
 =?us-ascii?Q?l8tatauAbIf+saWFEK/WmqPzOyuxvkblrttgms2JS0OCr7Y7VBw6lpkUmRAm?=
 =?us-ascii?Q?19G4D1tT1fciEwHOfbVJEmzpWiNC2F0GOLyfJloGIoL6zGr5eidaaVfUqyTL?=
 =?us-ascii?Q?Fig8r6NVqJzkIDQLWMGFIt8nSGCSR5unw3TiNZwfzbJfKqO7IfhnsgKfwEFD?=
 =?us-ascii?Q?uMKoCJ+T0ofDQBJERsfbZaPdRoMCrZ/kNQdhL7yXp1roGjPtvi7RK0kTJr0Q?=
 =?us-ascii?Q?Z+VSQxe43vXaSdAeo88+tbuhPb7HIStERey/kt09B2kZLnRtpec2t4L7MGN4?=
 =?us-ascii?Q?aWa2cyYvHe4TpIyvUenk8wq5RiXWj78QOKr5n7H6gAM7No/ONV7CHns/DeX+?=
 =?us-ascii?Q?zcaW9n87T31NZHVLszJ7k2zAsmgd637Z0Daup0fgkU8nsoXOa55GpPs9viSJ?=
 =?us-ascii?Q?c3GSztED2lGJRG4O1Ua/+LU0Pzm2Qe0H2YlfhXUEFKdYnSDftSTwYm6bIIdo?=
 =?us-ascii?Q?jN/gDcGLjoz9AnhcqXVy+OtR/T4pR6epigMNZzqLP/XPv7xMrUXeuMKjRVRa?=
 =?us-ascii?Q?2iKJCKbQDlgm5SZ1sFrVll7ufzKjGnwwSYdgcrwAHoDhfrrA99WoVtode/rO?=
 =?us-ascii?Q?KgFDM3lnkEdB/pKbaBOtTQWT6hMNaANisyJWbo7+K+fDQwXB78yLUDBWSsfM?=
 =?us-ascii?Q?bmaDHu4hfni56dvmzxREn4mrtaR+lp4EIwJKCDRelFwNfblfnwOKDKTgkEBi?=
 =?us-ascii?Q?QVqsE3ODuNarHIm3ldNMjgiHCywvSdWGeIAv1Mk8HiUDOdW8OrNJM3+3P6yj?=
 =?us-ascii?Q?syfb3lv+X3bbGqOmIgF98FV7njIjwMrTFC3VCoMrRAKYVsjo+Gi6ryZwuGc9?=
 =?us-ascii?Q?0IfOlkn9hsrCesRGYYBN31GrQgLfc/cYgmqOEBzP90VAqnlg7SD996Hz0JtQ?=
 =?us-ascii?Q?/XCLV2LZJdK8uAfuR/9t+D64rgX1E12l/ykegJhHvn2sF8p5QjC3fJlcPGYI?=
 =?us-ascii?Q?lA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: t+51nGZ/LguEwuAdbir172Gxngsorcg/oGAdxuey1qBCzPNJbXhl7qwBwciJeaFvC7BGU/48WllHIYWe0je/4ptDiaz0OHlf+AoQJmgQrOzE4B4/AvTu+C1MOvfH0Du2cB8jhmYwLceJQuCOj0o0KQRFM3/gFoxJxtN2IZxiNgCITosrI/WIr548fadgc0lqPDc5kZZlI1fK8aYao3wFcs4rWHCLns+PNeTjlTlIbPYdKm7sLYoRu+awba3kc2+evxEKgbdkmkxssAG0DYa7rZUK9wRkfbQ+8cJOSJTYT3cTWdWeusRzOu97JjYZFp8y9I4vR4TJo/HWEWs2RkRI+S8Sec2cvEnOpqy+i97VFyglD5mpMmGeWl3QnzfjQGuuENA5OxaF1Z5ddP/DX/XVEWg2Ur2mhoM11tbUrsNzveSotXtb9/v7kpJHXYt9OLrjMK9KwwdLtCjqaqn5ai/53EdZZW4LNmgoCEpL7ndvagfF12vd4aBNLKjRrwclJ5eDsIgpd++nKVt/IC2Z4qNddIIBWgnVrDgwGCF0lNN6W2KN3Zq/fBAFLcl6Jnn1YxxVkH9/HOUHxsegivhxg/l1QxSL7lgKRUoFJhFG95I0tAYSL+ZO5t8pYTJQ474xqt15VU3+uyW/FBbDuCzQPFUXFsUwE2SIYn+yARDNGr9SK3r2p48CgSrum8OpFP4uvrFI9PlHK+r95Hqa3D2WysEOhKr+70XbaHvR6EmHFaVZTYipxPRWNBvkW2+4UAMkN8wz3H43O28kzBkMU5v8T4F0iSmHRIv1H6aWmdh+BxliF9Tzja5mMK4PBmUEn3lmK6ee
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 233bd372-30a4-43a6-af62-08db347f6a6d
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 20:10:05.5444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q+xrvpKC8BOKS0mj9bpQ/ZyHYPTwTr6mvKVd20pH99IWbAInZflgr5x3yGGUGFVwqpPUEhl5OnL09NDhTHV+kQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6535
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-03_15,2023-04-03_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304030156
X-Proofpoint-ORIG-GUID: glS9-QGbv0c8xePI5URt3M9Zyc_gNGti
X-Proofpoint-GUID: glS9-QGbv0c8xePI5URt3M9Zyc_gNGti
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Mark Brown <broonie@kernel.org> [230403 16:00]:
> Liam recommends using mas_walk() instead of mas_find() for our use case so
> let's do that, it avoids some minor overhead associated with being able to
> restart the operation which we don't need since we do a simple search.
> 
> Suggested-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/base/regmap/regcache-maple.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/base/regmap/regcache-maple.c b/drivers/base/regmap/regcache-maple.c
> index 497cc708d277..5d1bc3691830 100644
> --- a/drivers/base/regmap/regcache-maple.c
> +++ b/drivers/base/regmap/regcache-maple.c
> @@ -22,7 +22,9 @@ static int regcache_maple_read(struct regmap *map,
>  
>  	rcu_read_lock();
>  
> -	entry = mas_find(&mas, reg);
> +	mas.index = reg;
> +	mas.last = reg;

You don't need to set mas.index/mas.last here.  You have done so with
MA_STATE(mas, mt, reg, reg); above with the last two arguments.

> +	entry = mas_walk(&mas);
>  	if (!entry) {
>  		rcu_read_unlock();
>  		return -ENOENT;
> @@ -47,7 +49,9 @@ static int regcache_maple_write(struct regmap *map, unsigned int reg,
>  
>  	rcu_read_lock();
>  
> -	entry = mas_find(&mas, reg);
> +	mas.index = reg;
> +	mas.last = reg;

Same here.

> +	entry = mas_walk(&mas);
>  	if (entry) {
>  		entry[reg - mas.index] = val;
>  		rcu_read_unlock();
> 
> ---
> base-commit: f033c26de5a5734625d2dd1dc196745fae186f1b
> change-id: 20230403-regmap-maple-walk-fine-982bbd2dcfe5
> 
> Best regards,
> -- 
> Mark Brown <broonie@kernel.org>
>