Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756028AbXIWUTz (ORCPT ); Sun, 23 Sep 2007 16:19:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751659AbXIWUTr (ORCPT ); Sun, 23 Sep 2007 16:19:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52312 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004AbXIWUTq (ORCPT ); Sun, 23 Sep 2007 16:19:46 -0400 Date: Sun, 23 Sep 2007 22:19:43 +0200 From: Bernhard Walle To: Oleg Verych , Andrew Morton Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [patch 1/7] Extended crashkernel command line Message-ID: <20070923201943.GA5272@suse.de> Mail-Followup-To: Oleg Verych , Andrew Morton , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org References: <20070920171845.774383000@stravinsky.suse.de> <20070920171846.062209000@stravinsky.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: SUSE LINUX Products GmbH User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 34 * Oleg Verych [2007-09-23 01:14]: > * Thu, 20 Sep 2007 19:18:46 +0200 > > [] > > extern u32 vmcoreinfo_note[VMCOREINFO_NOTE_SIZE/4]; > > extern unsigned int vmcoreinfo_size; > > extern unsigned int vmcoreinfo_max_size; > > +int __init parse_crashkernel(char *cmdline, unsigned long long system_ram, > > + unsigned long long *crash_size, unsigned long long *crash_base); > > (BTW, why `system_ram' is `unsigned long' in parse_crashkernel_mem() but > `unsigned long long' in parse_crashkernel()?) Because that's a bug, thanks for spotting that out. I will sent an updated version of this patch until the issue below has been clarified: > What is the point of not using `ulong' and `u64'? > > What about another names? > > +int __init get_crashkernel_params(u64 *memsize, u64 *addrbase, char *cmdline, u64 ram); Andrew, what's your opinion on this? Whould I resend the patch with shorter type names? Thanks, Bernhard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/