Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5073449rwl; Mon, 3 Apr 2023 14:02:40 -0700 (PDT) X-Google-Smtp-Source: AKy350YUklu7VTsqrWs0wWSlueKko8DojeLD4DyRZVY763oXoBA5LOjwawnDPjL2Vh83DSin3Tux X-Received: by 2002:a62:8406:0:b0:626:7e73:2f44 with SMTP id k6-20020a628406000000b006267e732f44mr11063pfd.9.1680555760016; Mon, 03 Apr 2023 14:02:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680555759; cv=none; d=google.com; s=arc-20160816; b=W6PjfcZXb4sJYa/OnX+TnQaF8YQNmQfqPu5ZqphiQhcZ+cvUcV3Qe6n3Ylc/801xC3 mFrIl6r2CioO9/RtlHdteVI51kRiTGW1UwagzTxt1IzKofkZSTh5l3AJkz2ITXCbeM02 msAFcx9SxoSmSV0C+9b+XJOjQWyH1pVdSbZ8EpDkockDIlyPKDFA1gG30gqwpvZZzkxt YjHL9IeQ2r5BX24ErwlB0FSsUD4HPWhaNhpa9Lo3pD/4cmDOUc4BQpA2MoJ6iW7cW+4j ZxFC9NClNEf2E/4orYYkOH7Tj/Y5P+oqCZ15Dncb7N0T7ltCrGjCMxOU16ui+OkT3BLx pgCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=bV7RRxn7TUvx76XiRomTvsM40vDK7Itg8IFk1BhPq8M=; b=ARMXMHfisle86QUmGYwLDgFWpG3xAD/a5zD3eqrxZqb/5BhtqQx+Ml7Z/bMkc+SiiU aFdoSujpniQVnpT98nk0Mo4ZxCwr4vzhXMy1RMqVmW04QiQSAWCZuprn/W5AeVCHlaol lWGE4du0YpnFWIm6S/9ot9LoGp+0cmNAWntRsUvcm2HsgHKy/bHQDl55R1lPgV8kODzS 154w0twR97x6qc+UjduR2x7N3Um21xra/oIhF6AkYA4ZpA62fKsrxqjApiO+eqp6LaRc ix55NVF0HHizY3L55wHKgfVpGKqarppO2MaelAdrkLztiiQaGUutUGBM+48OIgsBFYq3 /vZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CFnRupl4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a14-20020aa794ae000000b006262531b3e2si8804745pfl.361.2023.04.03.14.02.01; Mon, 03 Apr 2023 14:02:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CFnRupl4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233516AbjDCUr1 (ORCPT + 99 others); Mon, 3 Apr 2023 16:47:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232249AbjDCUr0 (ORCPT ); Mon, 3 Apr 2023 16:47:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 593C3139; Mon, 3 Apr 2023 13:47:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D947062AEC; Mon, 3 Apr 2023 20:47:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB0B8C433EF; Mon, 3 Apr 2023 20:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680554844; bh=QJCUCdp5PtM5gxyh82sgIsegU5ra4CtVc899W6CxcMs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CFnRupl4uvyl59il2ygB85xmBFNGZZ6dLBneuQ35YAeP/yq7NQbHEqLf/B+Cr1XOW Y7w03CTOnwdUrezsARAYyBIFI0WLTsi/m/gYMzgxfipdZmHziyFQPjPZ7zvemuRRdG whp8PGDM0lywebulIPA8d0oNxIVNrWPClBiFbZBNJMhnD2wJfrz9k6rH/66ytN3rzn AFi4zPyBeFMadsQWuWzszYc3kMvSgXjSPxRZRucWZKL1dDYpp+SGqJe2MOGqse5kWn 89npsqZw7caxdRQLHfRK2smzbWiG+/hQxjGbAUEp+ccCBbN6MZrB9Ta2nXRqDNHANw EPGrX6RzdheNw== Date: Mon, 3 Apr 2023 13:47:22 -0700 From: Jakub Kicinski To: Anjali Kulkarni Cc: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "zbr@ioremap.net" , "brauner@kernel.org" , "johannes@sipsolutions.net" , "ecree.xilinx@gmail.com" , "leon@kernel.org" , "keescook@chromium.org" , "socketcan@hartkopp.net" , "petrm@nvidia.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v4 1/6] netlink: Reverse the patch which removed filtering Message-ID: <20230403134722.4860160c@kernel.org> In-Reply-To: <82F9EDF5-9D7E-4FFC-9150-A978A36F26B9@oracle.com> References: <20230331235528.1106675-1-anjali.k.kulkarni@oracle.com> <20230331235528.1106675-2-anjali.k.kulkarni@oracle.com> <20230331210920.399e3483@kernel.org> <88FD5EFE-6946-42C4-881B-329C3FE01D26@oracle.com> <20230401121212.454abf11@kernel.org> <82F9EDF5-9D7E-4FFC-9150-A978A36F26B9@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 1 Apr 2023 19:58:31 +0000 Anjali Kulkarni wrote: > > patch 5 looks a bit connector specific, no idea :S > > patch 6 does seem to lift the NET_ADMIN for group 0 > > and from &init_user_ns, CAP_NET_ADMIN to net->user_ns, CAP_NET_ADMIN > > whether that's right or not I have no idea :( > I can move this back to &init_user_ns, and will look at group 0 too. Just to be clear - I wasn't saying that it's incorrect, I simply don't know :)