Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5076462rwl; Mon, 3 Apr 2023 14:05:03 -0700 (PDT) X-Google-Smtp-Source: AKy350ZCgDGP0DxuvuUAzvGvQuOomiiewEVkxD3ZJN1hnehzxWGGzRK6lFChZZEIQ56FFDEXH68U X-Received: by 2002:aa7:d584:0:b0:502:2f3:abd3 with SMTP id r4-20020aa7d584000000b0050202f3abd3mr464466edq.35.1680555902871; Mon, 03 Apr 2023 14:05:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680555902; cv=none; d=google.com; s=arc-20160816; b=Ro35hB6C9hd8JNKNw9thGh16Yj/kGqINj4UftTbb1/HVmJtsTqYsYHaPyA/v0mMSMl OkkCpeUju+DATTcHJPVwiq5QlBNnS8G9iu0zzHiDGKcdvIzyOnRzqXz8VRXoWkC1xzew o7H0gt3wWxDN/4Hajzfua4lnV7qCXGIK2ZSEpmU0HJ4ys9r9DLUhu3wdvug2bEwkSWdH 5uD1BOmELrUiwGKAPfvFgreDANa+g14c8bnQL6F5cT1l7fMI1VMu5t6JryI+qoDdHvA3 UtPOOPPWQf84XRkemEbi9vmnMJ0SjGV5NpvYO8xNjcX48jb3LhYUap2Ryv7U3h33aD+5 tknA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=oGjqm/ijj9dPozzTSQZ6XHTMx8mV2Xso7aJFchCfcGc=; b=XM12egwVls0Roy1tbFlhnzgyIgWKnEOYd/F3auWtqYZqX38/ABbYQU2yvJL36xKeWP vox9XqaXlJ8w2zuTGhNI1BoCCyNm6eRdxL8JsBiq3+7N9LhU/MIabkSPyFP7qE9jcsWk T8CJ0+lCfQ6uQsdmsSoB+IpsF0oZ8HoGkTSWQSP3oP7IV2orfaDcHVOUbswbz2fLsrAd 7SpzvAoU8gc8QzsYqBDjU0OIeeoYniswpAX3AgrcEi0vNsKJNOqZn6DvRB7x1UjDxw3+ 15bFwaKYph9JAh3mXhcTE1jZCsIujtDz7Tj7SuD74qV3mVyeW/Wt9L5+B6z6EPeiYBau jCCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f26-20020a056402069a00b0050295f60fd9si520802edy.125.2023.04.03.14.04.38; Mon, 03 Apr 2023 14:05:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233448AbjDCU5o (ORCPT + 99 others); Mon, 3 Apr 2023 16:57:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231961AbjDCU5n (ORCPT ); Mon, 3 Apr 2023 16:57:43 -0400 Received: from sym2.noone.org (sym.noone.org [IPv6:2a01:4f8:120:4161::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6505626B9; Mon, 3 Apr 2023 13:57:40 -0700 (PDT) Received: by sym2.noone.org (Postfix, from userid 1002) id 4Pr3BB13BBzvjfm; Mon, 3 Apr 2023 22:57:38 +0200 (CEST) Date: Mon, 3 Apr 2023 22:57:37 +0200 From: Tobias Klauser To: Christian Brauner , Shuah Khan Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests/clone3: fix number of tests in ksft_set_plan Message-ID: <20230403205735.ltb3pmh5yl2pjzhu@distanz.ch> References: <20230314115352.20623-1-tklauser@distanz.ch> <20230314123414.26907-1-tklauser@distanz.ch> <20230314130959.7gfuagxta6k423kf@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314130959.7gfuagxta6k423kf@wittgenstein> User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=0.3 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-03-14 at 14:09:59 +0100, Christian Brauner wrote: > On Tue, Mar 14, 2023 at 01:34:14PM +0100, Tobias Klauser wrote: > > Commit 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME") > > added an additional test, so the number passed to ksft_set_plan needs to > > be bumped accordingly. > > > > Also use ksft_finished() to print results and exit. This will catch future > > mismatches between ksft_set_plan() and the number of tests being run. > > > > Fixes: 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME") > > Cc: Christian Brauner > > Signed-off-by: Tobias Klauser > > --- > > Looks good. Thanks for fixing this, > Reviewed-by: Christian Brauner > > Feel free to take this through the selftests tree, Shuah. It looks like this hasn't made it into Linus' tree yet and I also don't see it in Shuah's tree. Would it be possible to still submit this for 6.3-rc6 given the commit it fixes has made it to Linus' tree already? Thanks