Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 22:07:59 +0100
From:   Mark Brown <broonie@kernel.org>
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        techsupport@winsystems.com, pdemetrotion@winsystems.com,
        quarium@gmail.com, jhentges@accesio.com, jay.dolan@accesio.com
Subject: Re: [PATCH v5 1/3] regmap: Pass irq_drv_data as a parameter for
 set_type_config()
Message-ID: <e6445419-b932-49f7-a401-b11155ad5bb9@sirena.org.uk>
References: <cover.1679845842.git.william.gray@linaro.org>
 <5ba9d4c58a4cef138201334ea48e8bc8297a9a1c.1679845842.git.william.gray@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="LgISFP/7WOX9dQTd"
Content-Disposition: inline
In-Reply-To: <5ba9d4c58a4cef138201334ea48e8bc8297a9a1c.1679845842.git.william.gray@linaro.org>
Precedence: bulk


--LgISFP/7WOX9dQTd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Mar 26, 2023 at 12:25:57PM -0400, William Breathitt Gray wrote:

> Changes in v5:
>  - Wrap lines to 100 characters rather than 80

It's good to keep things under 80 where we can.

>  	int (*set_type_config)(unsigned int **buf, unsigned int type,
> -			       const struct regmap_irq *irq_data, int idx);
> +			       const struct regmap_irq *irq_data, int idx, void *irq_drv_data);
>  	unsigned int (*get_irq_reg)(struct regmap_irq_chip_data *data,
>  				    unsigned int base, int index);
>  	void *irq_drv_data;

There's no benefit from overflowing here and...

> @@ -1660,7 +1660,8 @@ struct regmap_irq_chip {
>  unsigned int regmap_irq_get_irq_reg_linear(struct regmap_irq_chip_data *data,
>  					   unsigned int base, int index);
>  int regmap_irq_set_type_config_simple(unsigned int **buf, unsigned int type,
> -				      const struct regmap_irq *irq_data, int idx);
> +				      const struct regmap_irq *irq_data, int idx,
> +				      void *irq_drv_data);

...it's not even consistent.

--LgISFP/7WOX9dQTd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQrQC4ACgkQJNaLcl1U
h9DV/Qf+PRCsw/4s4r8lTZpU3nIiqV1fietBklJFobjST5n8EYp9hxeTLmF/r4x1
ZbZvAzsJYQu8LuChYTC2lel4jhFFhvlmOcDZcQryNrjvG9y8GKtbaSwWQgo906Px
GpzazDmchrlrtIfCKgnt3jdcaHkcD3LlxFRAIKXA/XloHjMySTl59F1Zi2ABTGzK
i+eI0XLLyshbrcYD85c+FhBAq1nj0W1O28TA7z7aVvxQL+Z//Vf4Xk4Oe9jkVVGY
jHyv5vQ7RhH/IIcu9BBMlmOHHFGFT6serZnJ8bgvnpCesEI4zYHIo+Y5n8OMmfzv
zJ+X1mDLdB9JulOuDdh4OxEnWy14MA==
=dRZY
-----END PGP SIGNATURE-----

--LgISFP/7WOX9dQTd--