Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 14:16:41 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] string: implement streq()
Message-Id: <20230403141641.6ace0d85fd48fbed5c02d7ef@linux-foundation.org>
In-Reply-To: <4b595ab9-238c-43a5-aba0-be5d6afc0f87@p183>
References: <4b595ab9-238c-43a5-aba0-be5d6afc0f87@p183>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 1 Apr 2023 20:48:05 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:

> Most of the time strcmp() is being used, strings are checked for equality.
> Add wrapper to relay such intent (it is shorter to type, too).
> 
> Use
> 	if (streq(s, "s")) {
> 	}
> or
> 	if (!streq(s, "s")) {
> 	}

Gee, do we really want this?  I mean, we all know how strcmp() works,
don't we?

I'm thinking it would be better to remove the various cute little
streq() macros and open-code strcmp(...)==0.