Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i58a146ae:Fastmail
Date:   Tue, 4 Apr 2023 08:50:59 +1000 (AEST)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Brad Boyer <flar@allandria.com>
cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3] nubus: Don't list slot resources by default
In-Reply-To: <20230403061827.GA3406@allandria.com>
Message-ID: <e887a8c9-4310-a6cb-62d2-39db7d75d452@linux-m68k.org>
References: <62e815b947d6d602def8294040529db80278c561.1679801822.git.fthain@linux-m68k.org> <20230403061827.GA3406@allandria.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 2 Apr 2023, Brad Boyer wrote:

> On Sun, Mar 26, 2023 at 02:37:02PM +1100, Finn Thain wrote:
> > diff --git a/drivers/nubus/nubus.c b/drivers/nubus/nubus.c
> > index f70ba58dbc55..d2d2b580f646 100644
> > --- a/drivers/nubus/nubus.c
> > +++ b/drivers/nubus/nubus.c
> > @@ -32,6 +32,12 @@
> >  
> >  /* Globals */
> >  
> > +/* This parameter makes slot resources available in procfs. It's deprecated and
> > + * disabled by default as procfs is no longer thought to be suitable for that.
> > + */
> > +bool populate_procfs;
> > +module_param(populate_procfs, bool, 0);
> > +
> >  LIST_HEAD(nubus_func_rsrcs);
> >  
> >  /* Meaning of "bytelanes":
> 
> Would it be better to give this option a name that indicates that it is 
> for nubus only? These are effectively a global namespace. Other than 
> this, I don't see any issues.
> 

The name of the module here is "nubus", so this parameter is specified as 
"nubus.populate_procfs" in the kernel parameters. Without the "nubus" it 
doesn't work. I should probably add a comment about that.