Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230306224127.1689967-1-vipinsh@google.com> <20230306224127.1689967-9-vipinsh@google.com>
 <ecd28c71-6f3d-d5bb-cd39-ab80edc549ab@intel.com>
In-Reply-To: <ecd28c71-6f3d-d5bb-cd39-ab80edc549ab@intel.com>
From:   Vipin Sharma <vipinsh@google.com>
Date:   Mon, 3 Apr 2023 16:02:47 -0700
Message-ID: <CAHVum0cOG62gstGK_W9r1vgjJ5P7_Eswek9SCmEA=E_hexaysw@mail.gmail.com>
Subject: Re: [Patch v4 08/18] KVM: x86/mmu: Track unused mmu_shadowed_info_cache
 pages count via global counter
To:     "Yang, Weijiang" <weijiang.yang@intel.com>
Cc:     jmattson@google.com, mizhang@google.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, seanjc@google.com,
        pbonzini@redhat.com, bgardon@google.com, dmatlack@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 29, 2023 at 9:53=E2=80=AFPM Yang, Weijiang <weijiang.yang@intel=
.com> wrote:
>
>
> On 3/7/2023 6:41 AM, Vipin Sharma wrote:
> > Add unused pages in mmu_shadowed_info_cache to global MMU unused page
> > cache counter i.e. kvm_total_unused_cached_pages. These pages will be
> > freed by MMU shrinker in future commit.
>
> This patch mainly renames some functions,  but the commit log doesn't
> reflect what
>
> this patch does. Please change the commit log or squash the patch.
>
>

This is not just function renaming, it is using a function which does
page accounting. I will expand the commit log to capture more details
instead of squashing.

Thanks