Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07d1c848-fd1e-7e5e-6b56-90ac2a1a86ef@kernel.org>
Date:   Tue, 4 Apr 2023 09:18:17 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix null pointer panic in tracepoint
 in __replace_atomic_write_block
Content-Language: en-US
To:     Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
References: <20230403165038.3018949-1-jaegeuk@kernel.org>
 <ZCsEytDjqEjQDPiO@google.com>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <ZCsEytDjqEjQDPiO@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/4/4 0:54, Jaegeuk Kim wrote:
> We got a kernel panic if old_addr is NULL.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=217266
> 
> BUG: kernel NULL pointer dereference, address: 0000000000000000
>   Call Trace:
>    <TASK>
>    f2fs_commit_atomic_write+0x619/0x990 [f2fs a1b985b80f5babd6f3ea778384908880812bfa43]
>    __f2fs_ioctl+0xd8e/0x4080 [f2fs a1b985b80f5babd6f3ea778384908880812bfa43]
>    ? vfs_write+0x2ae/0x3f0
>    ? vfs_write+0x2ae/0x3f0
>    __x64_sys_ioctl+0x91/0xd0
>    do_syscall_64+0x5c/0x90
>    entry_SYSCALL_64_after_hwframe+0x72/0xdc
>   RIP: 0033:0x7f69095fe53f
> 
> Fixes: 2f3a9ae990a7 ("f2fs: introduce trace_f2fs_replace_atomic_write_block")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Thanks for fixing this. :)

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,