Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Tue, 04 Apr 2023 03:08:30 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   "Yajun Deng" <yajun.deng@linux.dev>
Message-ID: <fa40602f182b028ec44c976a30a66ae6@linux.dev>
Subject: Re: [PATCH] cpufreq: Fix policy->freq_table is NULL in
 __cpufreq_driver_target()
To:     "Viresh Kumar" <viresh.kumar@linaro.org>
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
In-Reply-To: <20230403041128.jrsvbm4ddxdyhddg@vireshk-i7>
References: <20230403041128.jrsvbm4ddxdyhddg@vireshk-i7>
 <20230329133600.908723-1-yajun.deng@linux.dev>
Precedence: bulk

April 3, 2023 12:11 PM, "Viresh Kumar" <viresh.kumar@linaro.org> wrote:=
=0A=0A> On 29-03-23, 21:36, Yajun Deng wrote:=0A> =0A>> __resolve_freq() =
may be return target_freq if policy->freq_table is=0A>> NULL. In this cas=
e, it should return -EINVAL before __target_index().=0A>> =0A>> Signed-of=
f-by: Yajun Deng <yajun.deng@linux.dev>=0A>> ---=0A>> drivers/cpufreq/cpu=
freq.c | 2 +-=0A>> 1 file changed, 1 insertion(+), 1 deletion(-)=0A>> =0A=
>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c=0A>=
> index c0e5be0fe2d6..308a3df1a940 100644=0A>> --- a/drivers/cpufreq/cpuf=
req.c=0A>> +++ b/drivers/cpufreq/cpufreq.c=0A>> @@ -2299,7 +2299,7 @@ int=
 __cpufreq_driver_target(struct cpufreq_policy *policy,=0A>> return cpufr=
eq_driver->target(policy, target_freq, relation);=0A>> }=0A>> =0A>> - if =
(!cpufreq_driver->target_index)=0A>> + if (!cpufreq_driver->target_index =
|| !policy->freq_table)=0A>> return -EINVAL;=0A> =0A> Hi,=0A> =0A> I have=
 sent an alternate patch [1] for this, please try it.=0A>=0A =0AThanks, v=
2 is fine.=0A=0A> --=0A> viresh=0A> =0A> [1]=0A> https://lore.kernel.org/=
all/53d4ed4e5b18a59a48790434f8146fb207e11c49.1680494945.git.viresh.kumar@=
lin=0A> ro.org