Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Alex Williamson <alex.williamson@redhat.com>,
        "Chatre, Reinette" <reinette.chatre@intel.com>
CC:     "jgg@nvidia.com" <jgg@nvidia.com>,
        "yishaih@nvidia.com" <yishaih@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "darwi@linutronix.de" <darwi@linutronix.de>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Liu, Jing2" <jing2.liu@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "tom.zanussi@linux.intel.com" <tom.zanussi@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2 7/8] vfio/pci: Support dynamic MSI-x
Thread-Topic: [PATCH V2 7/8] vfio/pci: Support dynamic MSI-x
Thread-Index: AQHZYb/RZ45AlQ4MQUqOwT6J+5pTU68T7doAgAAAZQCAAUB6AIAATQUAgARk+oCAAC/MgIAAKXoAgABK0YCAAAgOEA==
Date:   Tue, 4 Apr 2023 03:51:25 +0000
Message-ID: <BN9PR11MB527626CAE4BA7ECB64F0E9728C939@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1680038771.git.reinette.chatre@intel.com>
        <419f3ba2f732154d8ae079b3deb02d0fdbe3e258.1680038771.git.reinette.chatre@intel.com>
        <20230330164050.0069e2a5.alex.williamson@redhat.com>
        <20230330164214.67ccbdfa.alex.williamson@redhat.com>
        <688393bf-445c-15c5-e84d-1c16261a4197@intel.com>
        <20230331162456.3f52b9e3.alex.williamson@redhat.com>
        <e15d588e-b63f-ab70-f6ae-91ceea8be79a@intel.com>
        <20230403142227.1328b373.alex.williamson@redhat.com>
        <57a8c701-bf97-fddd-9ac0-fc4d09e3cb16@intel.com>
 <20230403211841.0e206b67.alex.williamson@redhat.com>
In-Reply-To: <20230403211841.0e206b67.alex.williamson@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/95rqHqjpomsRGG02+o37jClweBDC3tnte8iO5Qwe7pJsmL5Yty6QsjHGHR6?=
 =?us-ascii?Q?dReZceIG8GZglIkLiYqGzR5HSbfT4YMdbVV6AHblXWBUIzSJSulNgoZWOYAr?=
 =?us-ascii?Q?Az9GBWg1i/zq2Jp+BGNCO0GVBlSkAOBstwB1STazUv5RbRdzTg5YluiWrgwR?=
 =?us-ascii?Q?Dko1GAjyeWhgUl9WKPdC68zmrFqMxHX7yhe3VG3q1+pVnPm3pWpW7ZMbGeWy?=
 =?us-ascii?Q?XHJkYBuMATYdyNftZ9KrLtY9Ioa/5TVTf3RNJMXmLnJAP7HsEMbSA78r3vkc?=
 =?us-ascii?Q?m8AHfx7kfySmPRbfVBVeRPk7lPeasI8JdNz0uaJGAnWZdheZLVf+PDTiiQs1?=
 =?us-ascii?Q?WoYhBEgqSmrEFkQXsVTfFQycxXn6C2oBLkNudzmGP3fnd1gjZQyhS9sBQD6u?=
 =?us-ascii?Q?GtuKYoeAVsTxSE8sPxZsIiO0tPhCSn0ayA4vn1Rd8e5gt9hs8iYFTMWD3cyb?=
 =?us-ascii?Q?6CNWgNXJMNgEuWA/BYzMtVmZjHQZcTauKdhbkN/L252zNDoWPAqwIIIJ477P?=
 =?us-ascii?Q?hK+r3MvRGQ7kTLD3GSpB3+3DM6cE7bPFjZozeZxbulize4ncUZz8qmkeGH7a?=
 =?us-ascii?Q?YcbN3MCZRp0Hu/jo8U1FQS3XmRHZaQ85Ey637CsbyRC1v8tNXSKcGvwguPtL?=
 =?us-ascii?Q?qNYW2nrY4C6CQfPexwerobf5K+okUNZjaQZyxRiOISkRs436nj5o/tjcioJq?=
 =?us-ascii?Q?VZ6dnisLqv9ovhmLN4R2rBOWcdjZv302TgrqP3Ew+OdYtEaY897kAbQ1fesN?=
 =?us-ascii?Q?g1/5h3wxwXyI9UAkrGxiMi938JasZ+u0NUbT/0ClphAMpnt8GXxmntBd051u?=
 =?us-ascii?Q?cY2u3BQ7S8bGmbZD01BTTyEXAaGU7UtgiVpQ1z37SRU+UxvW7s3Que2HVtnv?=
 =?us-ascii?Q?3bxbw4jGXOtnnwP8c17lP0ZijU5dAhD/Id+Q03lv0S9M3VFtWGyiWOHeC9UY?=
 =?us-ascii?Q?i1kpDGRmLtfwRIDErwNZzHi1XosIDKYNcrzRzuAeWsL4uSjUZPPOFxIfltwD?=
 =?us-ascii?Q?vDe8KsVlaeqhaaZrIDpVTSfJncYWvxnPJBmHFr+TXGZ+e35QE+BLNR7ysBOu?=
 =?us-ascii?Q?toM8t/LV+ipeigDG+qMoqKNCKyyAYY/KUT+UbZXugRbQlhtnrSnedai4sFbO?=
 =?us-ascii?Q?6KzSf/a1peHyVRBbRbWm/VED/iH9azCXNYcL/wOIjZfV6hyqU06MXIfRcwd0?=
 =?us-ascii?Q?oyBdlqeFdIZCG4535hW264Y0/zkJIb3NaK0lWVM7vWmSwAjqqdZ60c4wluB/?=
 =?us-ascii?Q?iHAjGVP3TL/S7Dfs7M24DoY0CM2WIYPmL4KoqMw3YE1Fz0hEt7raiRb3TU3X?=
 =?us-ascii?Q?XaVpcctehGR17sFv5p1XLxlYmRgpQXrlOhktWIeMlVSlVadqMdjadn44p89X?=
 =?us-ascii?Q?ZZGdq4Lt9Y/y2ScAZlXAiWrFOQ2IiCHPSi2HKirWdIEj0toml9KexHYAvwQT?=
 =?us-ascii?Q?WmSgb/wvpE7FJXMJ7Tbclg11X2IAtRkxcPCVL01jvxoTYi3wfsk/uVV9j0Td?=
 =?us-ascii?Q?o0HSLKO+vsYnwu3vOzt6XuvzieTbl7QpZJyPFR/n4Yj5NZeotaMvkH4rnbAl?=
 =?us-ascii?Q?MooHdystjIYxmKWWktf9HbLvnw6Hx1q18yyz5I0z?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b908e9c-d26d-4a5b-2ebb-08db34bfdced
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2023 03:51:25.2559
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o+f8f/6ekNT8Af7hLMtqg/g+iBf3YdgY1FCtnVEJLh08MYv+t3ODA1eJT4iIdbQJJ4DKQhd5RatL+22RldJHIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8095
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Alex Williamson <alex.williamson@redhat.com>
> Sent: Tuesday, April 4, 2023 11:19 AM
> >
> > Thank you very much for your guidance. I will digest this some more and
> > see how wrappers could be used. In the mean time while trying to think
> how
> > to unify this code I do think there is an issue in this patch in that
> > the get_cached_msi_msg()/pci_write_msi_msg()
> > should not be in an else branch.
> >
> > Specifically, I think it needs to be:
> > 	if (msix) {
> > 		if (irq =3D=3D -EINVAL) {
> > 			/* dynamically allocate interrupt */
> > 		}
> > 		get_cached_msi_msg(irq, &msg);
> > 		pci_write_msi_msg(irq, &msg);
> > 	}
>=20
> Yes, that's looked wrong to me all along, I think that resolves it.
> Thanks,
>=20

Do you mind elaborating why this change is required? I thought
pci_msix_alloc_irq_at() will compose a new msi message to write
hence no need to get cached value again in that case...