Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Apr 2023 21:03:28 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Liang Kan <kan.liang@linux.intel.com>,
        <linux-cxl@vger.kernel.org>, <peterz@infradead.org>
CC:     <mingo@redhat.com>, <acme@kernel.org>, <mark.rutland@arm.com>,
        <will@kernel.org>, <dan.j.williams@intel.com>,
        <linuxarm@huawei.com>, <linux-perf-users@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>
Subject: RE: [PATCH v4 2/5] perf: Allow a PMU to have a parent
Message-ID: <642ba19065e_29cc294f8@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230330164556.31533-1-Jonathan.Cameron@huawei.com>
 <20230330164556.31533-3-Jonathan.Cameron@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230330164556.31533-3-Jonathan.Cameron@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/lJNul4NT+wiNYB9jGVV/fPR3DDudmkNTmHe6liUymBm7K7ShRJuWsuPb28X?=
 =?us-ascii?Q?uDbGiVSOdUIuwtBFZ0wTLVZkK5DQNAZ90PwXqV7IXCfv2jC/TpCtQbmkdGZF?=
 =?us-ascii?Q?9lKdvkapB4JbKpDuCfepdWw3qlurspj9JTZa+ovb5oWPxNm4HHTGXPeMBTva?=
 =?us-ascii?Q?DDAT0Pj2h/yjImQG2+RxEeRQTXAcE4fbjDMp8Vi6ZLLd69xEeb8ZLJ8N2T9W?=
 =?us-ascii?Q?ZCtHy2Iq380EYHZasyAiDF+ronQkxpS5qD5bUNUKt15/IKiGcV5NrCxPsyBt?=
 =?us-ascii?Q?17aM7Gy2ZRoaKCh1brTBBymD+uLzMCYsY07YBEQJLPqFKs1MBbzbOlLxmMxN?=
 =?us-ascii?Q?B07ko3PRd1eDdzv3yzLVbsze5nEK5jBFBnhD5S5FjX+hlhxp4U6ES47v4Fzd?=
 =?us-ascii?Q?9D7YLkzrcxYS9tbYUrxyUwG30+YkSTjCW7dpkDMOuF8j91ujs5UeqKaQbwd2?=
 =?us-ascii?Q?v5wIcbN1rghvQ//ZYxXRHO9pHnA9rmwwurr/uyzjc2Zdk3zM7Ko0SAZbl3U2?=
 =?us-ascii?Q?aqGQa8V9ctrxuYeaihB/LlNmyPz0liW+NOzBX5Xvp7SA5pYUYGN6Xe4aM+A5?=
 =?us-ascii?Q?xF/qXyMun/AlXnan5v8iak/EGKG1grEF9eiqIJB94YPyJbgVxokMR1WGVwH7?=
 =?us-ascii?Q?/Mhe3soXlQaJ7DX+kPmGxqe3yhgqrqv+su5/xa11kTwz172ynYfL5NqnpPuR?=
 =?us-ascii?Q?OPhFIa1To4KFc39QqcUe1cXzCAWsw5D3Bgl4Jh8JDBZx83k3uM2iOcMXLVIp?=
 =?us-ascii?Q?j+HjzMJu1VGXoRUDkMFEu/hekzI4M30EE9o5b7pRv9XRCSbTB3TbHUiA7cxh?=
 =?us-ascii?Q?EOsPnf7H58D0/a+AF/2Gzn5yGXhWZZ5x9L2tLh3Noh83JabbVw2D9ukDc5/H?=
 =?us-ascii?Q?rDkNhUOfWwqbgQvnUwmEdW6nYH1l3SXpKIV1Zf6ZZNjKHpDOOAKkuqI1jDmm?=
 =?us-ascii?Q?Po3spF3xxPOKUSZfTnwNUISAM7k3TLc/yCexBSOOCKP0V2tT2bG/CKi/jH2E?=
 =?us-ascii?Q?V0KSHjGbTgvjLvvkpyMei/UliezrGpBlDh1bmwpPef2VdW/0KCLyX/dY1a+d?=
 =?us-ascii?Q?u3pQvUnnu2XKLOFPZQs/NkGhdv4T9R+LXOWv9Sl5MiHK3+XdOfWOYDk+jxYd?=
 =?us-ascii?Q?h2FUP1fPq5Pq8edPMnb4WQP4f36cjGgITZWZPIoiGbOArxHXef4svOoZ37OJ?=
 =?us-ascii?Q?wEcswwvVmT9V3ZuZuLB5E+v9GdVUH5Rl7JY30UHkzU2Zu0+srARlnzZ0+R40?=
 =?us-ascii?Q?mZifqM8WY7L9duLC8fiw76u3j+vAm6K26Vw85J4zy+QcsAUpPhzvnVxgB3Xr?=
 =?us-ascii?Q?uAvfytNquSq+wsMhE/jlT4ocPPenrZjTYlD0m9oK9OIgJiuPbj4xiksS9pR/?=
 =?us-ascii?Q?P7gOGsMTf7tTyzgF/+y/lgQiEj5kY+FUdamyG7R16+jMagg3asvJDOhPv6ae?=
 =?us-ascii?Q?E2l6iz4tJKa6zpwhQ8bYDM6oiRLq2uf/p5jlkhd4+Is7E3Ia+L5i720beEAc?=
 =?us-ascii?Q?BcRczivy+IzE0zC2iHzEOeMIUnFP4WBcjjTkEUauKmlY5ZAT5pO4nILLC+3M?=
 =?us-ascii?Q?FCIp0666Ot+7ThmMfhfOQROsWTa0j8e7SILeJaVYB+PoBdZNOcqgZwvtm8Ex?=
 =?us-ascii?Q?tQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: edecb71e-0730-4adc-7421-08db34c18d13
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 04:03:30.5052
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2T094kk6s5ggJh7YDjjGXz2atJ+wVeIXwzDlupqwFJVXP4gwLmH/yuJfYZFw8h4Ofo8th4PCYUXdQk/xH6tVM5P0Y2+YNmrLQ6wVJzJTbkI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5439
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jonathan Cameron wrote:
> Some PMUs have well defined parents such as PCI devices.
> As the device_initialize() and device_add() are all within
> pmu_dev_alloc() which is called from perf_pmu_register()
> there is no opportunity to set the parent from within a driver.
> 
> Add a struct device *parent field to struct pmu and use that
> to set the parent.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> v4: No change
> Note that this may first merge as part of a larger series I
> plan to post next week that adds parents for many of the of the
> other struct pmu instances.  If so please drop this patch whilst
> applying.

Feel free to add my:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

...whereever this gets applied, and yes it makes sense especially as
more device attached PMUs are showing up.