Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <748f1939-a5b5-25e5-8b45-e0ec89a39d6f@amd.com>
Date:   Tue, 4 Apr 2023 11:21:10 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:96.0) Gecko/20100101
 Thunderbird/96.0
Subject: Re: [PATCH] iommu/amd: Fix "Guest Virtual APIC Table Root Pointer"
 configuration in IRTE
Content-Language: en-US
To:     "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>,
        Kishon Vijay Abraham I <kvijayab@amd.com>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>
Cc:     Vasant Hegde <vasant.hegde@amd.com>,
        Santosh Shukla <santosh.shukla@amd.com>,
        "Nikunj A . Dadhania" <nikunj@amd.com>, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, joao.m.martins@oracle.com,
        boris.ostrovsky@oracle.com, alejandro.j.jimenez@oracle.com
References: <20230331061723.10337-1-kvijayab@amd.com>
 <575ef405-9d43-b99c-cae7-f88cfd6063e2@amd.com>
From:   Kishon VijayAbraham I <kvijayab@amd.com>
In-Reply-To: <575ef405-9d43-b99c-cae7-f88cfd6063e2@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmpJdXNmeVFjZGRDSkJBVVZjSldLSFhBbW9lTWhJS2M0cGZ5eDFVVDhJdWFI?=
 =?utf-8?B?QWl1djI0WXMrSDFiaUQyUkczNlRCaEdYTzhIM1lsMlBmTWUzcUtvUU94ZXRs?=
 =?utf-8?B?Uk1sU3ZvOWdUT3VzQ1FOVVhFS1NoTXB4aUl3ZUxoWG91OTZJcTFYSGFxUWFW?=
 =?utf-8?B?dEw1NWR3MjJ3Vjg5V0NBV0JyaXk4dlZsT0Vkc1BMQTRSWVdiTTBRWG5tSUtN?=
 =?utf-8?B?YnFtWkFJSVN6cUYrQ3FtVThLWWhHOUx6VlJoMnBUczN1ZWJKWU1tdXpERGND?=
 =?utf-8?B?M0sxQUEreHAyeStRVXpib2hzRlZGZDRTc09NelN5amdyc1ZFaGlXNUQ3eWFY?=
 =?utf-8?B?ZXo2ZVZaT3NlSnl2SzJqdS9LYTd2ZlRHbzJGTnZTUjdRRFNHMUtxbittWDB2?=
 =?utf-8?B?TkZVQ3lXRkJaN0NXbExTS2VCZlI3bGg3NTFkSUtCTlFqQk9VRFc0RWhQVXdu?=
 =?utf-8?B?TU0yejdGMjE0eisrbktlOXI5d3FpdlhhSHNTWEd1bXFGcGhZT1pvUHR4Z2gw?=
 =?utf-8?B?dWtpTzl3STZjYU5vRXltYUdRbTJxMXBDWEhtdmxNVm5NcUxlNDVQU2Jjbkh2?=
 =?utf-8?B?VFRaWkFsWllPbW1GbW9NMXhlV1VuK3lQdmRXS3E5SG1oeTJDQ012OXpjT2Z5?=
 =?utf-8?B?blpuTzBLSC9NTEhxeHZwbWNWOTBNcWdLcWdEWFBnS2JVZG5rVXhaQ29SZUZB?=
 =?utf-8?B?WFBJMUdDdlJuSnpLN1B5VmtrUjA1T2hXMzdkeDhlZnQrdjJLNklDMll6ZHlN?=
 =?utf-8?B?REVoOE5BcWgrUmRSdjdpMEhaUVZjSi8zcjRJZGJlTGdRVm5Zeks0enZva0Na?=
 =?utf-8?B?T3U4VUpraVM5TVBJNjRhMGRFOURWeFl2MVdSQ2xSQ2VaUkh2VUVWcUZoT2p2?=
 =?utf-8?B?TVYvN0daYlBDd0l5b0hDQW4vWjZpY0hMZUtHTDkzZHZMRUY3bGJuOVA2QVN6?=
 =?utf-8?B?dmlpN2VkS3pWS0VGcnRIU0gvME9aK05wMXdsYVVjOThGTjBQaEpiMS8xNDBF?=
 =?utf-8?B?d1d0SUgyK1ZZZEdvb29XU0kyb2MwSmtVNHdmN1NFcVl3akVMdDhydWFBS2R1?=
 =?utf-8?B?WDFyOHQ0TnlWejMycFZQOEduRVp5TUJ2ZlVCVk9qbnBQbTFsZXhQZnI0Y1g5?=
 =?utf-8?B?ODR6NmhPZUszZXgyTGE1ZTFoOS9ISHdtbWUrMXRIWUMxQ3Y5bEdxK3FmS3Vs?=
 =?utf-8?B?WGt6UGQ2UnVVNS9Hd3piV3FGOExqYjY0UERSY05TajNhUjZVWHI5d1VEMXVx?=
 =?utf-8?B?WmQ1WEhoYnQrWlpLcjZpSmlyekZtWWhQTDNpUFZjVkZya214UmpsNzIyaVc0?=
 =?utf-8?B?cGY2YkxzVzdIbE1BMEVWNU15cTZvK2NlZUFSNms3ME45WnFwcTdmZXFhWWh0?=
 =?utf-8?B?NlZNbS94dEJ5eTEyQm9mWm1MRzgwRkE3WmU1b2tIcGFlTGU5VENTNERqOTh2?=
 =?utf-8?B?TUwxc2NVK0xQcjNObWVnOXFEcW80cUNjZmU5TjZsbEhVUEhkRkd3d1U1VEtV?=
 =?utf-8?B?M2x5Y3UwU1VuSzhRU2FRWVRDQVUrUEtIeFRCT3pnWmVvMEFnMTlQWFFTaVM4?=
 =?utf-8?B?S2s3WkhLT2NrZ0tzODhsY2Vod0lDL0hLV1VleDhtTGZPeDVUSWJ0dW1UTTZP?=
 =?utf-8?B?bnRQMnI3MCtwMHlWaEJHWDcxNUFQMWZ5NjhnMTRMcTNnT2dtVEs1R2JDNFpy?=
 =?utf-8?B?QUEvTHJuRjhNR1JDQXlHbk9wWmJWeEhzLzNIeTdKeTR1T1hLUXcyQWVCYXJK?=
 =?utf-8?B?RDFGSXpWN2NQRFhmMGRseGRNYUVqTDNPdkZNVENybFkyZ2dobHJ4d3hBMGxQ?=
 =?utf-8?B?dUpjOHY5WCttZjFxNkM5MXdNUW9DSWowZ3VnT3pFaW9DVUtHN1VJbDMwazJh?=
 =?utf-8?B?aUxjYnBEaURtRTAwU0lhTE5adVMrSDVsanFIMlZWRFNlKzdabGNxNlg5MWhF?=
 =?utf-8?B?aDJtZG1wVXdvRzBrYWQ4eXN6eDk1OWxkUy8zbkUwVkNuR0IxS09ubC9IUGRz?=
 =?utf-8?B?d1JxZXllYXJYM0NFWndwL2xicTBUTjQzTTVLSW5naEo0TnBFVTd3SEFOekQw?=
 =?utf-8?B?eXUreER5YjNneWYzeVc2TDJCRVB6c1lLVkNJZitUdEF1SlJBeDk0WmtiTVlL?=
 =?utf-8?Q?Ikq2J5caxhDQRrwNmUTFbY1HR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8ea7e0a-86d7-43cc-4477-08db34d09f2b
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5827.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 05:51:23.4513
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rjqq4z9VVZZm5yOXAiEi91FqJKXjcqqn7gQJ5YimaKtzerbsoG1387IvR7nCkP+9vYOE6E578c0/DVIqDQB3bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB6014
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Suravee,

On 4/3/2023 9:59 AM, Suthikulpanit, Suravee wrote:
> Kishon,
> 
> On 3/31/2023 1:17 PM, Kishon Vijay Abraham I wrote:
>> commit b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC
>> (de-)activation code") while refactoring guest virtual APIC
>> activation/de-activation code, stored information for 
>> activate/de-activate
>> in "struct amd_ir_data". It used 32-bit integer data type for storing the
>> "Guest Virtual APIC Table Root Pointer" (ga_root_ptr), though the
>> "ga_root_ptr" is actually a 40-bit field in IRTE (Interrupt Remapping
>> Table Entry).
>>
>> This causes interrupts from PCIe devices to not reach the guest in the 
>> case
>> of PCIe passthrough with SME (Secure Memory Encryption) enabled as _SME_
>> bit in the "ga_root_ptr" is lost before writing it to the IRTE.
>>
>> Fix it by using 64-bit data type for storing the "ga_root_ptr".
>>
>> Fixes: b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC 
>> (de-)activation code")
>> Cc: stable@vger.kernel.org # v5.4+
>> Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>> Signed-off-by: Kishon Vijay Abraham I <kvijayab@amd.com>
> 
> Please also add
> Reported-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>

sure, will add it in v2 of this patch.

Regards,
Kishon