To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Uninline kcalloc()
In-Reply-To: Your message of "Sun, 23 Sep 2007 00:03:49 +0400."
             <20070922200349.GA2119@martell.zuzino.mipt.ru>
From: Valdis.Kletnieks@vt.edu
References: <20070922200349.GA2119@martell.zuzino.mipt.ru>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1190612108_7192P";
	 micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date: Mon, 24 Sep 2007 01:35:08 -0400
Message-ID: <25045.1190612108@turing-police.cc.vt.edu>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1443
Lines: 42

--==_Exmh_1190612108_7192P
Content-Type: text/plain; charset=us-ascii

On Sun, 23 Sep 2007 00:03:49 +0400, Alexey Dobriyan said:

> -static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
> -{
> -	if (n != 0 && size > ULONG_MAX / n)
> -		return NULL;
> -	return __kmalloc(n * size, flags | __GFP_ZERO);
> -}
> +void *kcalloc(size_t n, size_t size, gfp_t flags);

NAK.

This busticates some pretty subtle code in mm/slab.c that uses
uses __builtin_return_address() for debugging - if you do this, then
the "calling function" gets listed as "kcalloc()" rather than the much more
useful "function that called kcalloc()" (which is what you care about).

(I remember going around and around multiple times getting those stupid
inlines set up right, so that feature actually did something useful, otherwise
kcalloc and kzalloc didn't report where they were called from).

--==_Exmh_1190612108_7192P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQFG90yMcC3lWbTT17ARAhUmAKD1NezXzjJTOHtKZJ7YHvuXMi1KiACgled/
WGuYYIWqS11pqVlj/FPn4SU=
=lKUa
-----END PGP SIGNATURE-----

--==_Exmh_1190612108_7192P--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/