Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Apr 2023 08:14:49 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Frank Jungclaus <frank.jungclaus@esd.eu>
Cc:     linux-can@vger.kernel.org, Wolfgang Grandegger <wg@grandegger.com>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Stefan =?utf-8?B?TcOkdGpl?= <stefan.maetje@esd.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: esd_usb: Add support for CAN_CTRLMODE_BERR_REPORTING
Message-ID: <20230404-worrisome-cable-9486f6795772@pengutronix.de>
References: <20230330184446.2802135-1-frank.jungclaus@esd.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="blqp6dvgfsr376jr"
Content-Disposition: inline
In-Reply-To: <20230330184446.2802135-1-frank.jungclaus@esd.eu>
Precedence: bulk


--blqp6dvgfsr376jr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 30.03.2023 20:44:46, Frank Jungclaus wrote:
> Announce that the driver supports CAN_CTRLMODE_BERR_REPORTING by means
> of priv->can.ctrlmode_supported. Until now berr reporting always has
> been active without taking care of the berr-reporting parameter given
> to an "ip link set ..." command.
>=20
> Additionally apply some changes to function esd_usb_rx_event():
> - If berr reporting is off and it is also no state change, then
> immediately return.
> - Unconditionally (even in case of the above "immediate return") store
> tx- and rx-error counters, so directly use priv->bec.txerr and
> priv->bec.rxerr instead of intermediate variables.
> - Not directly related, but to better point out the linkage between a
> failed alloc_can_err_skb() and stats->rx_dropped++:
> Move the increment of the rx_dropped statistic counter (back) to
> directly behind the err_skb allocation.
>=20
> Signed-off-by: Frank Jungclaus <frank.jungclaus@esd.eu>

Applied to linux-can-next

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--blqp6dvgfsr376jr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmQrwFYACgkQvlAcSiqK
BOh28Af+MlH6MoPRA+EDMuSmn+NSuTSQpn2RxD9/UQrTuyig29aUjIMIVuREksym
Dn5bVb0C9V43K6TQ767Y9lBuoVRXgXB0fdurVKHxGP0cuABf4DwhAw1UaZFvUH21
G+WUVIHGtamM3WgQ8PR69m3Yay4RRNlxO2W90Elwnf4zZNUJdTXYlQtWZzl2ues1
IlFaEHUE/pEj8ALmTY0kegsYD30tq6hq8u7hpUKk/NmClU2DOyH57yr6g6ziLlng
5scVvajveEkg8F9T01z2tqBjdDJHeJ2lkj81bkXqz+/zT5LQxXXy1w9xQdToaeBA
PX4KakMomvaFQhGK5WgP99MKcQkVgQ==
=W/Id
-----END PGP SIGNATURE-----

--blqp6dvgfsr376jr--