Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5601226rwl; Tue, 4 Apr 2023 00:26:33 -0700 (PDT) X-Google-Smtp-Source: AKy350b0nic9imhrnVPDn+/IJX3SLF7luBOGsig/93dSTUhT9QDfofCkhCKfaE9BYvmhsrZxviCg X-Received: by 2002:a17:902:e843:b0:1a1:8860:70e5 with SMTP id t3-20020a170902e84300b001a1886070e5mr2149889plg.57.1680593193507; Tue, 04 Apr 2023 00:26:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680593193; cv=none; d=google.com; s=arc-20160816; b=tgOEg1g6yFUpCyMByqukzfE7USsKF5UlaIDBdMEsG5s2IDXmRO2PUX19pUNdwkGS4o XRdOIYs2KOZYWRjvVG8z8Nx4dVP7UqDdquLynezUEdY/35+Yq2R6ZfulnsS4JkQqN82k gNynvOE3tbmxkbEL/JKBdleC8tjCYRO5JeOiCAk2iVzZU93giNLn9xXTVPDQ7G5V43N/ sHzHaYKPXY1Gxm/S0RRL6GRE/9frz8uNH3LtguCLDLuCgVn6IvewjKMmva+BpFA/5odu T+ZjBnToZK2aC+LZuUJwUMBO0MYS3gCyQAqIjxwM8KDsibbWXtdJ06V/Cj+HnN+MPg6o gNFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=30NmBVsJ0prnQMZ8LwEeeFr8Ma25+/oMTWmqoNkyMm8=; b=Owh/A0vaQVqVLc5DdnjQc8qLtpvTUIPhcbkoWgVD7RXWej4Eirlzg1GakVdG9jL8B+ UHg+6whIbeMQhaRmtN24ddap/N5erzKIb9RwrUuuQGps5yAeq31X2ARwhxnDUGP8LqGH GmeFMjCwmx68XRkppPguEqbJqVzogDA6DnnTXzXmRL8DHfgNAwv5xZPvlt6pUPKHNhgU /Oo4gnNYSJmrubiHImyFuECmYaeYHtrlPnybvbAGvbs7uydoILUlSEfU3ZRc+J8JSm36 D/zQnCoDNpD61YUdFf9etvBdhzSijmVFsnpflPBlruDlyTXTYGUWHxT0KY9C8ySTXyBs kUbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sepDq3Z8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k19-20020a170902761300b001a229e52c19si9649506pll.91.2023.04.04.00.26.21; Tue, 04 Apr 2023 00:26:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sepDq3Z8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233921AbjDDHZ6 (ORCPT + 99 others); Tue, 4 Apr 2023 03:25:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233832AbjDDHZs (ORCPT ); Tue, 4 Apr 2023 03:25:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BC9C10D3; Tue, 4 Apr 2023 00:25:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6919461D8E; Tue, 4 Apr 2023 07:25:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE31DC433D2; Tue, 4 Apr 2023 07:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680593145; bh=KrpEnfXrN/ILXoJPn/Dt8b528GB6V4SV+63rAt0irQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sepDq3Z8l/XByMhI2fKijIQx1dPOlFmgxe69kiRmQ+cuFs8RLh/ZW45N5dRSH2xWv G262nYdA3W/c6xMbUsneyyUZqiRXVmoKg9h2pNkKAZrWwGgmLboVADDzd6mtSYOJbI CshFGH8ZsUCtZld0WZRtL3xhnXEDzVBiqr2+XotFwt+OfDF9MOnmnK0DCXzK0cWSFc MjP5huxKD8/KIVaAEttY3xk6qeXy5LzX+ORD7Lw48avk/PQa1gfGdh4szD+lxSpRzA h/9PpwApdGOxBqsY3tpza8raZNe1/2bkrntT3Q8S4//cqORin10UNtHV/YUShFK5LP c8LtBvnahjTzw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pjb3U-0004xS-OF; Tue, 04 Apr 2023 09:26:12 +0200 From: Johan Hovold To: Thinh Nguyen Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Li Jun Subject: [PATCH 02/11] USB: dwc3: fix runtime pm imbalance on unbind Date: Tue, 4 Apr 2023 09:25:15 +0200 Message-Id: <20230404072524.19014-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404072524.19014-1-johan+linaro@kernel.org> References: <20230404072524.19014-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make sure to balance the runtime PM usage count on driver unbind by adding back the pm_runtime_allow() call that had been erroneously removed. Fixes: 266d0493900a ("usb: dwc3: core: don't trigger runtime pm when remove driver") Cc: stable@vger.kernel.org # 5.9 Cc: Li Jun Signed-off-by: Johan Hovold --- drivers/usb/dwc3/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 5058bd8d56ca..9f8c988c25cb 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1979,6 +1979,7 @@ static int dwc3_remove(struct platform_device *pdev) dwc3_core_exit(dwc); dwc3_ulpi_exit(dwc); + pm_runtime_allow(&pdev->dev); pm_runtime_disable(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); -- 2.39.2